This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add new DMR register classes to Future CPU.
ClosedPublic

Authored by stefanp on Oct 20 2022, 9:12 AM.

Details

Summary

A new register class as well as a number of related subregisters are being added
to Future CPU. These registers are Dense Math Registers (DMR) and are 1024 bits
long. These regsiters can also be used in consecutive pairs which leads to a
register that is 2048 bits.

This patch also adds 7 new instructions that use these registers. More
instructions will be added in future patches.

Diff Detail

Event Timeline

stefanp created this revision.Oct 20 2022, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 9:12 AM
stefanp requested review of this revision.Oct 20 2022, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 9:12 AM
stefanp added a reviewer: Restricted Project.Oct 20 2022, 9:12 AM
stefanp updated this revision to Diff 469255.Oct 20 2022, 9:18 AM

nit: Fixed some spacing.

amyk accepted this revision as: amyk.Oct 24 2022, 4:06 PM

I have a couple minor nit comments but I think it overall LGTM.

llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
367

Unrelated space change?

llvm/lib/Target/PowerPC/PPCInstrFutureMMA.td
38

nit: Align spacing.

llvm/test/CodeGen/PowerPC/future-check-features.ll
1

nit: Are these run lines too long?

This revision is now accepted and ready to land.Oct 24 2022, 4:06 PM
stefanp updated this revision to Diff 471261.Oct 27 2022, 12:32 PM

Rebased patch to top of main and addressed a couple of nits.

llvm/test/CodeGen/PowerPC/future-check-features.ll
1

nit: Are these run lines too long?

Yes, they are too long.
I actually think they were too long in the original test too but I'll fix it with this patch.

saghir accepted this revision as: saghir.Oct 28 2022, 4:09 PM
saghir added a subscriber: saghir.

LGTM. Thanks!

stefanp updated this revision to Diff 472744.Nov 2 2022, 1:36 PM

Rebased patch to top of main branch.

stefanp updated this revision to Diff 472824.Nov 2 2022, 6:32 PM

Moved the include location for PPCInstrFutureMMA.td.

This revision was landed with ongoing or failed builds.Nov 3 2022, 6:29 AM
This revision was automatically updated to reflect the committed changes.