Page MenuHomePhabricator

[AArch64] Refactor opcode selection for LowerMUL (NFC)
ClosedPublic

Authored by zjaffal on Sep 29 2022, 6:35 AM.

Details

Summary

Move the logic for selecting NewOpc out of LowerMUL

Diff Detail

Event Timeline

zjaffal created this revision.Sep 29 2022, 6:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 6:35 AM
zjaffal requested review of this revision.Sep 29 2022, 6:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 6:35 AM
zjaffal retitled this revision from [AArch64] refactor Opcode selection for LowerMUL (NFC) to [AArch64] Refactor opcode selection for LowerMUL (NFC).Sep 29 2022, 6:44 AM
dmgreen added inline comments.Sep 29 2022, 9:34 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4430–4431

Make sure you format what needs to be formatted.

zjaffal updated this revision to Diff 464177.Sep 30 2022, 1:21 AM

Reformat file

fhahn accepted this revision.Sep 30 2022, 7:30 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 30 2022, 7:30 AM
fhahn added inline comments.Sep 30 2022, 8:40 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4380

this should be static unsigned, I'll fix before committing.

4382

While changing the code, we should also use the opportunity to update the variable names to be in line with the coding standard. Will also update before committing.

fhahn added inline comments.Sep 30 2022, 8:46 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4381

DL is also unused in the function, will also fix before committing.

This revision was automatically updated to reflect the committed changes.