Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D134678

[Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)
ClosedPublic
Actions

Authored by bryanpkc on Sep 26 2022, 2:47 PM.

Details

Reviewers
sdesmalen
rsandifo-arm
david-arm
sagarkulkarni19
Commits
rGf225898a7c61: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)
Summary

This patch adds support for the following SME ACLE intrinsics (as defined
in https://arm-software.github.io/acle/main/acle.html):

  • svldr_vnum_za
  • svstr_vnum_za

Co-authored-by: Sagar Kulkarni <sagar.kulkarni1@huawei.com>

Diff Detail

Event Timeline

sagarkulkarni19 created this revision.Sep 26 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2022, 2:47 PM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
sagarkulkarni19 requested review of this revision.Sep 26 2022, 2:47 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptSep 26 2022, 2:47 PM
Harbormaster completed remote builds in B188794: Diff 463027.Sep 26 2022, 2:47 PM
sagarkulkarni19 added a child revision: D134681: [Clang][AArch64][SME] Add outer product intrinsics.Sep 26 2022, 2:57 PM
sagarkulkarni19 added a child revision: D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.
sagarkulkarni19 added a child revision: D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length.
sagarkulkarni19 added parent revisions: D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics, D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics , D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
bryanpkc commandeered this revision.Jan 21 2023, 2:18 PM
bryanpkc added a reviewer: sagarkulkarni19.
bryanpkc updated this revision to Diff 492679.Jan 27 2023, 2:43 AM
bryanpkc retitled this revision from [Clang][AArch64] Add SME ldr and str intrinsic to [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR).
bryanpkc edited the summary of this revision. (Show Details)

Rebased and cleaned up the patch.

Harbormaster completed remote builds in B210301: Diff 492679.Jan 27 2023, 2:44 AM
bryanpkc updated this revision to Diff 526361.May 28 2023, 8:30 PM
Harbormaster completed remote builds in B235092: Diff 526361.May 28 2023, 8:31 PM
bryanpkc removed parent revisions: D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics, D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .Jun 4 2023, 11:18 PM
bryanpkc removed a child revision: D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.
bryanpkc removed a child revision: D134681: [Clang][AArch64][SME] Add outer product intrinsics.
Matt added a subscriber: Matt.Jun 5 2023, 12:24 PM
bryanpkc updated this revision to Diff 531949.Jun 15 2023, 5:14 PM

Instead of defining new type flags, EmitAArch64SMEBuiltinExpr is updated to switch on BuiltinID, as suggested by @sdesmalen.

bryanpkc updated this revision to Diff 531953.Jun 15 2023, 5:25 PM

Also added SME attributes to the tests.

Harbormaster completed remote builds in B239268: Diff 531953.Jun 15 2023, 6:17 PM
bryanpkc updated this revision to Diff 540839.Jul 16 2023, 5:40 PM

Removed the attribute macro from tests, as @sdesmalen suggested.

Harbormaster completed remote builds in B245706: Diff 540839.Jul 16 2023, 6:26 PM
sdesmalen added inline comments.Jul 17 2023, 6:43 AM
clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_str.c
25

This is missing an add of 15 to %slice_base.

bryanpkc marked an inline comment as done.Jul 17 2023, 10:41 AM
bryanpkc added inline comments.
clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_str.c
25

Thanks for catching that. Fixed.

bryanpkc updated this revision to Diff 541132.Jul 17 2023, 10:43 AM
bryanpkc marked an inline comment as done.
sdesmalen accepted this revision.Jul 17 2023, 12:18 PM

Thanks for the quick fix!

This revision is now accepted and ready to land.Jul 17 2023, 12:18 PM
Harbormaster completed remote builds in B245928: Diff 541132.Jul 17 2023, 4:07 PM
This revision was landed with ongoing or failed builds.Jul 20 2023, 2:57 AM
Closed by commit rGf225898a7c61: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR) (authored by bryanpkc). · Explain Why
This revision was automatically updated to reflect the committed changes.
bryanpkc added a commit: rGf225898a7c61: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR).

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
10 lines
lib/
CodeGen/
19 lines
3 lines
test/
CodeGen/
aarch64-sme-intrinsics/
30 lines
30 lines
Sema/
aarch64-sme-intrinsics/
8 lines

Diff 542395

View Options

clang/include/clang/Basic/arm_sme.td

Loading...
View Options

clang/lib/CodeGen/CGBuiltin.cpp

Loading...
View Options

clang/lib/CodeGen/CodeGenFunction.h

Loading...
View Options

clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_ldr.c

Loading...
View Options

clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_str.c

Loading...
View Options

clang/test/Sema/aarch64-sme-intrinsics/acle_sme_imm.cpp

Loading...