Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People sagarkulkarni19

sagarkulkarni19 (Sagar Kulkarni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2022, 11:57 AM (67 w, 2 d)

Recent Activity
View All

Oct 17 2022

sagarkulkarni19 added a comment to D134681: [Clang][AArch64][SME] Add outer product intrinsics.
In D134681#3858849, @rsandifo-arm wrote:

Thanks for the patch. This is going to be inconvenient, sorry, but: while implementing the specification in GCC, I noticed that the ZA functions weren't consistent about whether they had an _m suffix. svwrite (MOVA) had one, but the MOP intrinsics that you're implementing here didn't. Since SME2 does have some unpredicated instructions, it seems like it would be better to make the MOP intrinsics consistent with svwrite, with an _m suffix.

I've created https://github.com/ARM-software/acle/pull/218 for that change. Please let me know if it looks reasonable to you.

Oct 17 2022, 5:53 AM · Restricted Project, Restricted Project

Sep 26 2022

sagarkulkarni19 requested review of D134681: [Clang][AArch64][SME] Add outer product intrinsics.
Sep 26 2022, 2:57 PM · Restricted Project, Restricted Project
sagarkulkarni19 requested review of D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile.
Sep 26 2022, 2:52 PM · Restricted Project, Restricted Project
sagarkulkarni19 requested review of D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length.
Sep 26 2022, 2:49 PM · Restricted Project, Restricted Project
sagarkulkarni19 requested review of D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR).
Sep 26 2022, 2:47 PM · Restricted Project, Restricted Project
sagarkulkarni19 updated the summary of D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.
Sep 26 2022, 2:43 PM · Restricted Project, Restricted Project
sagarkulkarni19 requested review of D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics.
Sep 26 2022, 2:40 PM · Restricted Project, Restricted Project
sagarkulkarni19 updated the diff for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .
  • Decorate intrinsics with SME attributes.
  • Update testcases by adding "arm_streaming" attribute to the callee.
Sep 26 2022, 2:37 PM · Restricted Project, Restricted Project
sagarkulkarni19 updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Update testcases by adding "arm_streaming" attribute to the callee.

Sep 26 2022, 2:34 PM · Restricted Project, Restricted Project

Sep 13 2022

sagarkulkarni19 updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
  • Support Opaque pointers
  • Correct predicate types for the intrinsics.
  • Decorate intrinsics with SME attributes.
Sep 13 2022, 10:54 AM · Restricted Project, Restricted Project

Jun 27 2022

sagarkulkarni19 added reviewers for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics: rsandifo-arm, david-arm.
Jun 27 2022, 7:24 AM · Restricted Project, Restricted Project
sagarkulkarni19 added reviewers for D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics : rsandifo-arm, david-arm.
Jun 27 2022, 7:23 AM · Restricted Project, Restricted Project
sagarkulkarni19 requested review of D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics .
Jun 27 2022, 7:15 AM · Restricted Project, Restricted Project

Jun 24 2022

sagarkulkarni19 added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Jun 24 2022, 4:40 PM · Restricted Project, Restricted Project
sagarkulkarni19 updated the diff for D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.

Updated testcases and also added the vnum variant of the ld1 and st1 intrinsics.

Jun 24 2022, 4:38 PM · Restricted Project, Restricted Project

Jun 23 2022

sagarkulkarni19 added inline comments to D127861: [AArch64][SME] Add SME addha/va intrinsics.
Jun 23 2022, 12:46 PM · Restricted Project, Restricted Project

Jun 16 2022

sagarkulkarni19 added inline comments to D127843: [AArch64][SME] Add the zero intrinsic.
Jun 16 2022, 1:17 PM · Restricted Project, Restricted Project
sagarkulkarni19 added inline comments to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Jun 16 2022, 11:39 AM · Restricted Project, Restricted Project
sagarkulkarni19 added a comment to D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
In D127910#3589068, @sdesmalen wrote:

Hi @sagarkulkarni19, this patch will have to wait until the ABI is implemented so that the builtins can be decorated with the attributes. A first patch proposing these attributes is in D127762. LLVM patches that use these attributes to implement the ABI will follow soon. We could add you as reviewer to these patches if you'd like to help us with that?

Jun 16 2022, 11:02 AM · Restricted Project, Restricted Project

Jun 15 2022

sagarkulkarni19 requested review of D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics.
Jun 15 2022, 3:44 PM · Restricted Project, Restricted Project