[Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is not deleted before attempting to call DefineDefaultedFunction(...)

[shafik]

Summary

I discovered this additional bug at the end of working on D132906

In Sema::CheckCompletedCXXClass(...) uses a lambda CheckForDefaultedFunction to verify each CXXMethodDecl holds to the expected invariants before passing them on to CheckForDefaultedFunction.

It is currently missing a check that it is not deleted, this adds that check and a test that crashed without this check.

This fixes: https://github.com/llvm/llvm-project/issues/57516

[shafik]

• Add Release note.

clang/docs/ReleaseNotes.rst

 - Fix assert that triggers a crash during template name lookup when a type was
   incomplete but was not also a TagType. This fixes
   `Issue 57387 <https://github.com/llvm/llvm-project/issues/57387>`_.
 - Fix a crash when emitting a concept-related diagnostic. This fixes
   `Issue 57415 <https://github.com/llvm/llvm-project/issues/57415>`_.
 - Fix a crash when attempting to default a virtual constexpr non-special member
   function in a derived class. This fixes
   `Issue 57431 <https://github.com/llvm/llvm-project/issues/57431>`_
+- Fix a crash where we attempt to define a deleted destructor. This fixes
+  `Issue 57516 <https://github.com/llvm/llvm-project/issues/57516>`_
 
 
 Improvements to Clang's diagnostics
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 - Clang will now correctly diagnose as ill-formed a constant expression where an
   enum without a fixed underlying type is set to a value outside the range of
   the enumeration's values. Due to the extended period of time this bug was
   present in major C++ implementations (including Clang), this error has the

clang/lib/Sema/SemaDeclCXX.cpp

if (!M->isInvalidDecl() && M->isExplicitlyDefaulted() &&
         // Define after any fields with in-class initializers have been parsed.
         DelayedDllExportMemberFunctions.push_back(M);
       }
     }
 
     // Define defaulted constexpr virtual functions that override a base class
     // function right away.
     // FIXME: We can defer doing this until the vtable is marked as used.
-    if (CSM != CXXInvalid && M->isDefaulted() && M->isConstexpr() &&
-        M->size_overridden_methods())
+    if (CSM != CXXInvalid && !M->isDeleted() && M->isDefaulted() &&
+        M->isConstexpr() && M->size_overridden_methods())
       DefineDefaultedFunction(*this, M, M->getLocation());
 
     if (!Incomplete)
       CheckCompletedMemberFunction(M);
   };
 
   // Check the destructor before any other member function. We need to
   // determine whether it's trivial in order to determine whether the claas

clang/test/SemaCXX/constant-expression-cxx2a.cpp

 class B {
   virtual int constexpr f() = 0;
 };
 
 class D : B {
   virtual int constexpr f() = default; // expected-error {{only special member functions and comparison operators may be defaulted}}
 };
 }
+
+namespace GH57516 {
+class B{
+  virtual constexpr ~B() = 0; // expected-note {{overridden virtual function is here}}
+};
+
+class D : B{}; // expected-error {{deleted function '~D' cannot override a non-deleted function}}
+// expected-note@-1 {{destructor of 'D' is implicitly deleted because base class 'B' has an inaccessible destructor}}
+}