This patch supports the tail agnostic part of D130442.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2655 | How about using RISCVII::TAIL_AGNOSTIC to replace 1? |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-peephole-vmerge-vops.ll | ||
---|---|---|
346 | This comment is incorrect |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2715–2716 | Why you test vector policy of MaskedOpc here? |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2715–2716 | Thanks, it's a mistake, I am intended to check whether MaskedOpc has mergeop here. Fixed now. |
Can you land the new tests and rebase please? I want to be able to study the test diffs.
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2656 | This else handles everything which isn't a vmerge right? If so, the code would be cleaner if it could be written as: if (not a vmerge) continue; if (TA) { } else { } | |
2715 | Do we have an example of masked pseudo without a merge operand? If not, this if-clause should be assert instead. |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2618 | Is it better to rewrite to /* TUMU */ 0? |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
2618 | Sorry that I am late to ask the question. |
Is it better to rewrite to /* TUMU */ 0?