This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Refactor fadd test to match the code.
ClosedPublic

Authored by jacquesguan on Aug 26 2022, 1:21 AM.

Details

Summary

Change fadd test case in D122563 to match the fold base case.

Diff Detail

Event Timeline

jacquesguan created this revision.Aug 26 2022, 1:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 1:21 AM
jacquesguan requested review of this revision.Aug 26 2022, 1:21 AM
reames accepted this revision.Aug 26 2022, 7:44 AM
reames added a subscriber: reames.

LGTM

However, we really should have tests for both forms. Please land, but then add another test with the source operand being used instead. Please add a corresponding test for each intrinsic with a scalar fold start operand.

llvm/test/CodeGen/RISCV/rvv/fold-binary-reduce.ll
257

Use fast here.

This revision is now accepted and ready to land.Aug 26 2022, 7:44 AM

Address comment.

This revision was landed with ongoing or failed builds.Aug 28 2022, 7:46 PM
This revision was automatically updated to reflect the committed changes.