Page MenuHomePhabricator

[clangd] Implement textDocument/codeLens
Needs ReviewPublic

Authored by Trass3r on Aug 5 2022, 2:26 PM.

Details

Reviewers
nridge
Summary

Let's gather some feedback on the code changes for codelens support, they've been rotting since 2 years already.
I started on it back then and it got taken further by @lightmelodies.
Some small issues remain: https://github.com/clangd/clangd/issues/442#issuecomment-1125056812

Diff Detail

Event Timeline

Trass3r created this revision.Aug 5 2022, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 2:26 PM
Trass3r edited the summary of this revision. (Show Details)Aug 5 2022, 2:33 PM
Trass3r edited projects, added Restricted Project; removed Restricted Project.
Trass3r edited subscribers, added: sammccall; removed: mgorny, javed.absar, arphaman, usaxena95.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 2:33 PM
Trass3r edited the summary of this revision. (Show Details)Aug 5 2022, 2:37 PM
Trass3r added a subscriber: lightmelodies.
Trass3r updated this revision to Diff 450421.Aug 5 2022, 2:51 PM

"base" refs are only useful on class forward decls
but for some reasons this still shows up on dtor implementations

Trass3r updated this revision to Diff 450422.Aug 5 2022, 2:55 PM

squashed

Trass3r added inline comments.Aug 5 2022, 2:59 PM
clang-tools-extra/clangd/CodeLens.cpp
86

they still show up on dtor implementations iirc

Trass3r published this revision for review.Aug 5 2022, 2:59 PM
Trass3r added a comment.EditedAug 5 2022, 3:04 PM

I just searched again and found https://reviews.llvm.org/D91930.
But seems like it never got updated with the latest code featured here. Though looks like the test got dropped.