Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

SR_team (SR_team)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2022, 11:54 AM (45 w, 6 d)

Recent Activity

Aug 6 2023

SR_team added a comment to D157205: [clangd] Add hexadecimal member offsets and sizes to hover popup.

Until a 10, we don't have difference between DEC and HEX, may be print only DEC in these cases?

Aug 6 2023, 4:38 AM · Restricted Project, Restricted Project

Jun 5 2023

SR_team updated the diff for D151128: [clangd] Show size, offset and padding for bit fields on hover.
  • moved lambda FormatSize to static function formatSize();
  • extracted offset format code to static function formatOffset();
  • always shows bytes in offset (for offset 4 showed Offset: 0 bytes and 4 bits)
  • added render test for bit-fields
Jun 5 2023, 8:38 AM · Restricted Project, Restricted Project

May 27 2023

SR_team added a comment to D151128: [clangd] Show size, offset and padding for bit fields on hover.

@sammccall review my code please

May 27 2023, 5:20 PM · Restricted Project, Restricted Project

May 24 2023

SR_team updated the summary of D151128: [clangd] Show size, offset and padding for bit fields on hover.
May 24 2023, 12:40 PM · Restricted Project, Restricted Project

May 23 2023

SR_team updated the summary of D151128: [clangd] Show size, offset and padding for bit fields on hover.
May 23 2023, 5:59 PM · Restricted Project, Restricted Project
SR_team updated the diff for D151128: [clangd] Show size, offset and padding for bit fields on hover.

Extract formatting to lambda, for simplify code modification

May 23 2023, 5:25 PM · Restricted Project, Restricted Project
SR_team updated the diff for D151128: [clangd] Show size, offset and padding for bit fields on hover.

Stores Offset, Size and Padding fields of HoverInfo in bits. When hover present bits converted to bytes, if possible.

May 23 2023, 4:58 PM · Restricted Project, Restricted Project
SR_team updated the diff for D151128: [clangd] Show size, offset and padding for bit fields on hover.
May 23 2023, 4:50 PM · Restricted Project, Restricted Project
SR_team added a comment to D151128: [clangd] Show size, offset and padding for bit fields on hover.

I do see the appeal of making this work for bitfields, but I think silently rounding offset/size/padding to whole bytes is pretty misleading.
For bitfields we'd really need to talk about layout at a bit level.
But we don't want to talk about regular fields in bits (I think?!)
And having a mixture seems like it's going to be pretty complicated both in implementation and for users, for a smallish feature.

I don't see a great sweet-spot design, maybe you/others have ideas (or can explain why the rounding behavior in this patch is reasonable.

May 23 2023, 10:32 AM · Restricted Project, Restricted Project

May 22 2023

SR_team requested review of D151128: [clangd] Show size, offset and padding for bit fields on hover.
May 22 2023, 11:24 AM · Restricted Project, Restricted Project

Apr 23 2023

SR_team added a comment to D125224: [CodeComplete] prototype of contextual postfix completions.

Iterator checks may crash in current state. Also, pointeeType may return invalid type of iterator store (T* instead of T)

Apr 23 2023, 9:00 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2023

SR_team awarded D145228: [clangd] Add clangd headers to install targets a Like token.
Mar 6 2023, 1:26 AM · Restricted Project, Restricted Project

Nov 12 2022

SR_team awarded D131295: [clangd] Implement textDocument/codeLens a Like token.
Nov 12 2022, 1:58 PM · Restricted Project, Restricted Project