[clang-tidy] Rename the make-confusable-table executable

[mstorsjo]

Summary

Rename it to clang-tidy-confusable-chars-gen, to make its role clearer in a wider context.

In cross builds, the caller might want to provide this tool externally (to avoid needing to rebuild it in the cross build). In such a case, having the tool properly namespaced makes its role clearer.

This matches how the clang-pseudo-gen tool was renamed in a43fef05d4fae32f02365c7b8fef2aa631d23628 / D126725.

[serge-sans-paille]

LGTM, thanks for doing this.

[mstorsjo]

Updated with the new suggested executable name from https://reviews.llvm.org/D129799#3681524. Will push this change tomorrow if there's no further objections.

[sammccall]

clang-tools-extra/clang-tidy/misc/CMakeLists.txt

10–11

(Should the variable names also be updated?

[mstorsjo]

clang-tools-extra/clang-tidy/misc/CMakeLists.txt

10–11

I guess I could do that for consistency too. (Sorry for not noticing your comment before pushing!)

[thakis]

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn

1

Thanks for attempting to update the GN build, but if you don't test it it's less confusing to not touch it at all. I fixed it in dd428a571c69621d5b6eb2e0e3ce5497c304fb2c and I was confused for a bit since this file here was already updated.

(I suppose the GN build wouldn't have broken if you hadn't changed this file and I wouldn't have noticed and not renamed the executable there for a while…)

[mstorsjo]

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn

1

Oops, sorry about that! I'll keep my hands off of the GN parts in the future.

clang-tools-extra/clang-tidy/misc/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   FrontendOpenMP
   Support
   )
 
 if(LLVM_USE_HOST_TOOLS)
-  build_native_tool(make-confusable-table make_confusable_table)
+  build_native_tool(clang-tidy-confusable-chars-gen make_confusable_table)
   set(make_confusable_table_target "${make_confusable_table}")
 else()
-  set(make_confusable_table $<TARGET_FILE:make-confusable-table>)
-  set(make_confusable_table_target make-confusable-table)
+  set(make_confusable_table $<TARGET_FILE:clang-tidy-confusable-chars-gen>)
+  set(make_confusable_table_target clang-tidy-confusable-chars-gen)
 endif()
 
 add_subdirectory(ConfusableTable)
 
 
 add_custom_command(
     OUTPUT Confusables.inc
     COMMAND ${make_confusable_table} ${CMAKE_CURRENT_SOURCE_DIR}/ConfusableTable/confusables.txt ${CMAKE_CURRENT_BINARY_DIR}/Confusables.inc

clang-tools-extra/clang-tidy/misc/ConfusableTable/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS Support)
 list(REMOVE_ITEM LLVM_COMMON_DEPENDS clang-tablegen-targets)
 
-add_llvm_executable(make-confusable-table
+add_llvm_executable(clang-tidy-confusable-chars-gen
   BuildConfusableTable.cpp
   )

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn

-executable("make-confusable-table") {
+executable("clang-tidy-confusable-chars-gen") {
   deps = [ "//llvm/lib/Support" ]
   sources = [ "BuildConfusableTable.cpp" ]
 }