This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Reduce the dependencies for the "make-confusable-table" tool
ClosedPublic

Authored by mstorsjo on Jul 14 2022, 1:25 PM.

Details

Summary

When cross compiling llvm, a separate recursive native cmake build
is generated, for building the tools that generate code (unless they're
provided externally by the caller).

This reduces the number of build steps for that native build from
1000+ steps to 162.

This matches how the clang-pseudo-gen tool is set up in
clang-tools-extra/pseudo/gen/CMakeLists.txt.

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 14 2022, 1:25 PM
mstorsjo requested review of this revision.Jul 14 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2022, 1:25 PM

This matches what I did for clang-pseudo-gen. It looks reasonable to me, but I'd love to get a third opinion...
(If none in a couple of days, happy to stamp it)

I'm fine with this too.

This revision is now accepted and ready to land.Jul 18 2022, 12:09 AM