This is an archive of the discontinued LLVM Phabricator instance.

[pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC
ClosedPublic

Authored by sammccall on May 31 2022, 3:07 PM.

Details

Summary

This name is not namespaced. Requested in D126717

Diff Detail

Event Timeline

sammccall created this revision.May 31 2022, 3:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 3:07 PM
Herald added a subscriber: mgorny. · View Herald Transcript
sammccall requested review of this revision.May 31 2022, 3:07 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 31 2022, 3:07 PM
hokein accepted this revision.Jun 1 2022, 12:31 AM
hokein added inline comments.
llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
1

I was skeptical there should be an additional change in the gn build (building the inc file), but it looks like the gn file is incomplete, the cxx doesn't compile in gn build, there is a fixme, I think it is ok.

This revision is now accepted and ready to land.Jun 1 2022, 12:31 AM
thakis added a subscriber: thakis.Jun 3 2022, 7:44 AM

Renaming this seems like a great change to me fwiw :)

llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
1

(fwiw we usually only add things to the gn build covered by tests. nothing in the test suite needs this at the moment, so i haven't ported it. i have a local branch ready to go in case it's needed, it looks like D126966.)

This revision was landed with ongoing or failed builds.Jun 3 2022, 11:46 AM
This revision was automatically updated to reflect the committed changes.