This is an archive of the discontinued LLVM Phabricator instance.

[mlir][tblgen] Consistently use `$_ctxt` instead of `$_ctx`
ClosedPublic

Authored by zero9178 on Jul 5 2022, 10:43 AM.

Details

Summary

With the exceptions of AttrOrTypeParameter and DerivedAttr, all of MLIR consistently uses $_ctxt as the substitute variable for the MLIRContext in TableGen C++ code.
Usually this does not matter unless one where to reuse some code in multiple fields but it still needlessly inconsistent and prone to error.

This patch fixes that by consistently using _$ctxt everywhere.

Diff Detail

Event Timeline

zero9178 created this revision.Jul 5 2022, 10:43 AM
zero9178 requested review of this revision.Jul 5 2022, 10:43 AM
Mogball accepted this revision.Jul 5 2022, 10:58 AM
This revision is now accepted and ready to land.Jul 5 2022, 10:58 AM
rriddle accepted this revision.Jul 5 2022, 11:01 AM