[flang][OpenMP] Added semantic checks for 'operator' in atomic update assignment statements

[NimishMishra]

Summary

This patch adds the following semantics check for operator in atomic update statements of the form x = x operator expr and x = expr operator x:

• "operator must refer to the intrinsic operator and not to a user-defined operator"

[peixin]

flang/lib/Semantics/check-omp-structure.cpp

1546

It seems that you can support this semantic check all in here.

flang/test/Semantics/OpenMP/omp-atomic-user-defined-operators.f90

46

This is not a valid atomic update statement since * is not one intrinsic operator in this case.

[NimishMishra]

flang/test/Semantics/OpenMP/omp-atomic-user-defined-operators.f90

46

Yes. Do you have any idea on dealing with overloaded intrinsic operators? One way could be to do something with typed expressions; but in case you have some idea, do share.

flang/lib/Semantics/check-omp-structure.cpp

common::visit(
               if (!foundMatch) {
                 context_.Say(expr.source,
                     "Atomic update variable '%s' not found in the "
                     "argument list of intrinsic procedure"_err_en_US,
                     var.GetSource().ToString());
               }
             }
           },
+          [&](const parser::Expr::DefinedUnary &) {
+              context_.Say(expr.source,
+                  "User defined operator not allowed in"
+                  " OpenMP ATOMIC (UPDATE) statement"_err_en_US); 
+          },
+          [&](const parser::Expr::DefinedBinary &) {
+              context_.Say(expr.source,
+                  "User defined operator not allowed in"
+                  " OpenMP ATOMIC (UPDATE) statement"_err_en_US);
+          },
           [&](const auto &x) {
             if (!IsOperatorValid(x, var)) {
               context_.Say(expr.source,
                   "Invalid operator in OpenMP ATOMIC (UPDATE) statement"_err_en_US);
             }
           },
       },
       expr.u);
 }
 

flang/test/Semantics/OpenMP/omp-atomic-user-defined-operators.f90

+! RUN: %python %S/../test_errors.py %s %flang_fc1 -fopenmp
+! Semantics checks on user defined operators on atomic update statement
+
+module overload_asterisk
+    implicit none
+    private
+    public operator (*)
+
+    interface operator(*)
+        module procedure logical_and
+    end interface
+
+contains
+    pure logical function logical_and(log1, log2)
+        logical, intent(in) :: log1, log2
+
+        logical_and = (log1 .and. log2)
+    end function
+end module
+
+module new_operator
+    implicit none
+    private
+    public operator(.MYOPERATOR.)
+
+    interface operator(.MYOPERATOR.)
+       module procedure myprocedure
+    end interface
+contains
+    pure integer function myprocedure(param1, param2)
+        integer, intent(in) :: param1, param2
+        myprocedure = param1 + param2
+    end function
+end module
+
+program sample
+    use omp_lib
+    use overload_asterisk
+    use new_operator
+    implicit none
+
+    logical  :: T = .true., F = .false.
+    integer :: x, y 
+    !$omp atomic
+        T = T*T
+    
+    !$omp atomic update
+        x = x / y
+     
+    !$omp atomic update
+    !ERROR: User defined operator not allowed in OpenMP ATOMIC (UPDATE) statement
+        x = x .MYOPERATOR. y
+
+    !$omp atomic
+    !ERROR: User defined operator not allowed in OpenMP ATOMIC (UPDATE) statement
+        x = x .MYOPERATOR. y
+end program