This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement P0618R0 (Deprecating <codecvt>)
ClosedPublic

Authored by philnik on Jun 8 2022, 8:46 AM.

Details

Diff Detail

Event Timeline

philnik created this revision.Jun 8 2022, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 8:46 AM
philnik requested review of this revision.Jun 8 2022, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 8:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik retitled this revision from [libc++] Implement P0618R0 (Deprecationg <codecvt>) to [libc++] Implement P0618R0 (Deprecating <codecvt>).Jun 8 2022, 9:42 AM
philnik updated this revision to Diff 435227.Jun 8 2022, 9:57 AM
  • Try to fix CI
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project, cfe-commits and 60 others. · View Herald Transcript
philnik updated this revision to Diff 435230.Jun 8 2022, 10:01 AM

Fix Patch

philnik removed projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project.
philnik removed subscribers: emaste, mgorny, sbc100 and 58 others.
ldionne accepted this revision.Jun 10 2022, 8:17 AM

LGTM with changes applied and passing CI.

libcxx/docs/ReleaseNotes.rst
178–181

This should be under API Changes, not ABI Changes

libcxx/include/codecvt
261–262

Here and elsewhere, let's use _LIBCPP_SUPPRESS_DEPRECATED_PUSH and _LIBCPP_SUPPRESS_DEPRECATED_POP instead.

libcxx/src/locale.cpp
1834–1835

_LIBCPP_SUPPRESS_DEPRECATED_PUSH

libcxx/test/std/localization/locales/locale.convenience/conversions/conversions.buffer/depr.verify.cpp
8

I think you'll need to handle no-localization and no-wide-characters here.

This revision is now accepted and ready to land.Jun 10 2022, 8:17 AM
philnik updated this revision to Diff 436032.Jun 10 2022, 1:39 PM
philnik marked 3 inline comments as done.
  • Address comments
philnik updated this revision to Diff 436126.Jun 11 2022, 4:14 AM

Rebased to fix CI

philnik updated this revision to Diff 437951.Jun 17 2022, 9:57 AM
  • Try to fix CI
philnik updated this revision to Diff 438407.Jun 20 2022, 8:21 AM
  • Try to fix CI
philnik updated this revision to Diff 438486.Jun 20 2022, 3:09 PM
  • Try to fix CI
philnik updated this revision to Diff 441353.Jun 30 2022, 4:47 AM
  • Try to fix CI
This revision was automatically updated to reflect the committed changes.