Details
Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project - Commits
- rG3ee9a50a146c: [libc++] Implement P0618R0 (Deprecating <codecvt>)
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM with changes applied and passing CI.
libcxx/docs/ReleaseNotes.rst | ||
---|---|---|
187–190 | This should be under API Changes, not ABI Changes | |
libcxx/include/codecvt | ||
261–262 | Here and elsewhere, let's use _LIBCPP_SUPPRESS_DEPRECATED_PUSH and _LIBCPP_SUPPRESS_DEPRECATED_POP instead. | |
libcxx/src/locale.cpp | ||
1834–1835 | _LIBCPP_SUPPRESS_DEPRECATED_PUSH | |
libcxx/test/std/localization/locales/locale.convenience/conversions/conversions.buffer/depr.verify.cpp | ||
8 | I think you'll need to handle no-localization and no-wide-characters here. |
This should be under API Changes, not ABI Changes