This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.
ClosedPublic

Authored by khchen on May 31 2022, 6:22 PM.

Diff Detail

Event Timeline

khchen created this revision.May 31 2022, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 6:22 PM
khchen requested review of this revision.May 31 2022, 6:22 PM
kito-cheng accepted this revision.Jul 26 2022, 12:49 AM

LGTM, and verified with internal testsuite :)

This revision is now accepted and ready to land.Jul 26 2022, 12:49 AM

While at it, could you switch those UndefValue with PoisonValue if possible? Thank you!

While at it, could you switch those UndefValue with PoisonValue if possible? Thank you!

I'm not sure UndefValue will work because the backend would only check isUndef() to generate correct code...

While at it, could you switch those UndefValue with PoisonValue if possible? Thank you!

I'm not sure UndefValue will work because the backend would only check isUndef() to generate correct code...

PoisonValue and UndefValue are both turned into undef in SelectionDAG today.

While at it, could you switch those UndefValue with PoisonValue if possible? Thank you!

I'm not sure UndefValue will work because the backend would only check isUndef() to generate correct code...

PoisonValue and UndefValue are both turned into undef in SelectionDAG today.

thanks @craig.topper, I will switch UndefValue with PoisonValue.

oops.. all tests need to updated and include all intrinsic IR tests...
Is there any benefit to switch UndefValue to PoisonValue?
maybe those changed should be in other follow-up patches?

khchen added a comment.Aug 2 2022, 9:15 AM

@nlopes we will update all undef to poison in follow up patches.

This revision was landed with ongoing or failed builds.Aug 2 2022, 10:31 AM
This revision was automatically updated to reflect the committed changes.
nlopes added a comment.Aug 8 2022, 2:36 AM

@nlopes we will update all undef to poison in follow up patches.

Thank you!
The benefit is that we want to remove undef altogether, so I'm trying to avoid having more undefs introduced, and if possible have everyone help reducing its usage whenever possible.
Thank you for your help!