This is an archive of the discontinued LLVM Phabricator instance.

Differential D125363

[RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s
ClosedPublic

Authored by Pretty-box on May 11 2022, 2:28 AM.

Details

Reviewers
benshi001
sunshaoce
Toppole69
craig.topper
asb
Commits
rG62cb208375ea: [RISCV][NFC] Add an RV64 RUN line to rv32zfhmin-invalid.s

Diff Detail

Event Timeline

Pretty-box created this revision.May 11 2022, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 2:28 AM
Herald added subscribers: VincentWu, luke957, vkmr and 27 others. · View Herald Transcript
Pretty-box requested review of this revision.May 11 2022, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 2:28 AM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B163858: Diff 428593.May 11 2022, 3:14 AM
Pretty-box edited the summary of this revision. (Show Details)May 11 2022, 6:55 PM
Pretty-box added a reviewer: craig.topper.May 11 2022, 7:31 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptMay 11 2022, 7:31 PM
sunshaoce added a comment.May 11 2022, 7:35 PM

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

Pretty-box added a comment.May 11 2022, 7:54 PM
In D125363#3507916, @sunshaoce wrote:

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

This is a good suggestion, I will add these instructions in the next patch.

asb requested changes to this revision.May 12 2022, 12:33 AM

Thanks for working to improve our test coverage! In this particular case, I think it would be better handled by adding an RV64 RUN line to rv32zfhmin-invalid.s (given the contents of the file is identical).

This revision now requires changes to proceed.May 12 2022, 12:33 AM
Pretty-box updated this revision to Diff 428874.May 12 2022, 1:14 AM
Pretty-box retitled this revision from [RISCV] Add RV64Zfhmin invalid tests to [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .
Pretty-box edited the summary of this revision. (Show Details)
Pretty-box added a comment.May 12 2022, 1:20 AM
In D125363#3507916, @sunshaoce wrote:

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

This is a good suggestion, I will add these instructions in the next patch.

In D125363#3508212, @asb wrote:

Thanks for working to improve our test coverage! In this particular case, I think it would be better handled by adding an RV64 RUN line to rv32zfhmin-invalid.s (given the contents of the file is identical).

done

Harbormaster completed remote builds in B164054: Diff 428874.May 12 2022, 3:14 AM
craig.topper accepted this revision.May 12 2022, 12:36 PM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2022, 7:21 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG62cb208375ea: [RISCV][NFC] Add an RV64 RUN line to rv32zfhmin-invalid.s (authored by Pretty-box, committed by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG62cb208375ea: [RISCV][NFC] Add an RV64 RUN line to rv32zfhmin-invalid.s.

Revision Contents

PathSize
llvm/
test/
MC/
RISCV/
2 lines

Diff 429117

llvm/test/MC/RISCV/rv32zfhmin-invalid.s

# RUN: not llvm-mc -triple riscv32 -mattr=+zfhmin < %s 2>&1 | \ # RUN: not llvm-mc -triple riscv32 -mattr=+zfhmin < %s 2>&1 | \
# RUN: FileCheck %s # RUN: FileCheck %s
# RUN: not llvm-mc -triple riscv64 -mattr=+zfhmin < %s 2>&1 | \
# RUN: FileCheck %s
# Out of range immediates # Out of range immediates
## simm12 ## simm12
flh ft1, -2049(a0) # CHECK: :[[@LINE]]:10: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047] flh ft1, -2049(a0) # CHECK: :[[@LINE]]:10: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
fsh ft2, 2048(a1) # CHECK: :[[@LINE]]:10: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047] fsh ft2, 2048(a1) # CHECK: :[[@LINE]]:10: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
# Memory operand not formatted correctly # Memory operand not formatted correctly
flh ft1, a0, -200 # CHECK: :[[@LINE]]:14: error: invalid operand for instruction flh ft1, a0, -200 # CHECK: :[[@LINE]]:14: error: invalid operand for instruction
Show All 13 Lines