Page MenuHomePhabricator

Pretty-box
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2021, 11:38 PM (27 w, 6 d)

Recent Activity

Fri, Jun 24

Pretty-box added inline comments to D128334: [LegalizeTypes][X86] Add SoftPromoteHalfOperand support for STRICT_FP_TO_SINT/STRICT_FP_TO_UINT.
Fri, Jun 24, 1:05 AM · Restricted Project, Unknown Object (Project)

Wed, Jun 22

Pretty-box requested review of D128334: [LegalizeTypes][X86] Add SoftPromoteHalfOperand support for STRICT_FP_TO_SINT/STRICT_FP_TO_UINT.
Wed, Jun 22, 4:34 AM · Restricted Project, Unknown Object (Project)

Tue, Jun 21

Pretty-box abandoned D128246: [ADT][NFC] Remove unuse code.
Tue, Jun 21, 1:02 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Pretty-box requested review of D128246: [ADT][NFC] Remove unuse code.
Tue, Jun 21, 12:28 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Fri, Jun 17

Pretty-box committed rG880ac5189d63: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s (authored by Pretty-box).
[RISCV][NFC] Add load/store instructions in rv64*-invalid.s
Fri, Jun 17, 12:18 AM · Unknown Object (Project), Restricted Project
Pretty-box closed D127721: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s.
Fri, Jun 17, 12:18 AM · Restricted Project, Unknown Object (Project)

Tue, Jun 14

Pretty-box added inline comments to D127721: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s.
Tue, Jun 14, 11:19 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D127721: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s.
Tue, Jun 14, 8:28 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).
Tue, Jun 14, 7:19 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D127475: [RISCV][NFC] precommit tests for D127474.
Tue, Jun 14, 7:15 PM · Restricted Project, Unknown Object (Project)

Mon, Jun 13

Pretty-box requested review of D127721: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s.
Mon, Jun 13, 11:56 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).
Mon, Jun 13, 6:41 PM · Unknown Object (Project), Restricted Project

Sun, Jun 12

Pretty-box added a comment to D127475: [RISCV][NFC] precommit tests for D127474.

Please include [RISCV] in the title. I'd drop the [tests] and include NFC instead.

Sun, Jun 12, 8:37 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).
Sun, Jun 12, 8:34 PM · Unknown Object (Project), Restricted Project
Pretty-box retitled D127475: [RISCV][NFC] precommit tests for D127474 from [tests] precommit tests for D127474 to [RISCV][NFC] precommit tests for D127474.
Sun, Jun 12, 6:40 PM · Restricted Project, Unknown Object (Project)

Thu, Jun 9

Pretty-box requested review of D127475: [RISCV][NFC] precommit tests for D127474.
Thu, Jun 9, 11:18 PM · Restricted Project, Unknown Object (Project)
Pretty-box requested review of D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).
Thu, Jun 9, 11:11 PM · Unknown Object (Project), Restricted Project

Tue, Jun 7

Pretty-box abandoned D127080: [DAGCombiner][RISCV] Improve computeKnownBits for (smin X, C) where C is negative..
Tue, Jun 7, 7:49 PM · Unknown Object (Project), Restricted Project

Sun, Jun 5

Pretty-box requested review of D127080: [DAGCombiner][RISCV] Improve computeKnownBits for (smin X, C) where C is negative..
Sun, Jun 5, 8:22 PM · Unknown Object (Project), Restricted Project

Wed, Jun 1

Pretty-box abandoned D126646: [DAGCombine] fold (A+B)-(A-C) -> B+C.
Wed, Jun 1, 2:14 AM · Unknown Object (Project), Restricted Project

May 30 2022

Pretty-box requested review of D126646: [DAGCombine] fold (A+B)-(A-C) -> B+C.
May 30 2022, 6:03 AM · Unknown Object (Project), Restricted Project

May 29 2022

Pretty-box added a reviewer for D126624: [DAGCombine][NFC] Add braces to 'else' to match braced 'if': craig.topper.
May 29 2022, 11:04 PM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D126624: [DAGCombine][NFC] Add braces to 'else' to match braced 'if'.
May 29 2022, 8:07 PM · Unknown Object (Project), Restricted Project
Pretty-box added a comment to D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.

ping

May 29 2022, 6:34 PM · Unknown Object (Project), Restricted Project

May 26 2022

Pretty-box requested review of D126520: [RISCV] Support VP_REDUCE_MUL mask operation.
May 26 2022, 9:33 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D126516: [RISCV][NFC] Simplified code for integer promotion setcc/vp.setcc.
May 26 2022, 7:29 PM · Restricted Project, Unknown Object (Project)
Pretty-box requested review of D126516: [RISCV][NFC] Simplified code for integer promotion setcc/vp.setcc.
May 26 2022, 7:04 PM · Restricted Project, Unknown Object (Project)

May 23 2022

Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 23 2022, 2:31 AM · Unknown Object (Project), Restricted Project

May 19 2022

Pretty-box updated the diff for D125960: [LegalizeTypes][VP] Add integer promotion support for vp.sitofp/vp.uitofp.
May 19 2022, 11:32 PM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D125960: [LegalizeTypes][VP] Add integer promotion support for vp.sitofp/vp.uitofp.
May 19 2022, 3:25 AM · Unknown Object (Project), Restricted Project

May 18 2022

Pretty-box added inline comments to D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 8:49 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 8:46 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 8:37 PM · Unknown Object (Project), Restricted Project
Pretty-box added inline comments to D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 8:27 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 8:25 PM · Unknown Object (Project), Restricted Project
Pretty-box added inline comments to D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 12:15 AM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 18 2022, 12:12 AM · Unknown Object (Project), Restricted Project

May 17 2022

Pretty-box updated the diff for D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 17 2022, 8:07 PM · Unknown Object (Project), Restricted Project
Pretty-box added inline comments to D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 17 2022, 8:01 PM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D125760: [LegalizeTypes][VP] Add integer promotion support for vp.fptosi/vp.fptoui.
May 17 2022, 3:36 AM · Unknown Object (Project), Restricted Project

May 12 2022

Pretty-box added a comment to D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

May 12 2022, 1:20 AM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .
May 12 2022, 1:15 AM · Unknown Object (Project), Restricted Project

May 11 2022

Pretty-box added a comment to D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

May 11 2022, 7:54 PM · Unknown Object (Project), Restricted Project
Pretty-box added a reviewer for D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s : craig.topper.
May 11 2022, 7:31 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125354: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
May 11 2022, 7:16 PM · Unknown Object (Project), Restricted Project
Pretty-box updated the summary of D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .
May 11 2022, 6:55 PM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .
May 11 2022, 2:28 AM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D125354: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
May 11 2022, 12:29 AM · Unknown Object (Project), Restricted Project

May 9 2022

Pretty-box added a comment to D125157: [clang][Driver] Add more tests for riscv.

Change the title to [clang][Driver] Add more tests for riscv

May 9 2022, 3:10 AM · Restricted Project, Unknown Object (Project), Restricted Project
Pretty-box retitled D125157: [clang][Driver] Add more tests for riscv from [RISCV][NFC] Add more tests for clang driver. to [clang][Driver] Add more tests for riscv.
May 9 2022, 3:10 AM · Restricted Project, Unknown Object (Project), Restricted Project
Pretty-box added a reviewer for D125210: [RISCV] Add 'rv32izvfh' invalid arch test: craig.topper.
May 9 2022, 1:11 AM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D125210: [RISCV] Add 'rv32izvfh' invalid arch test.
May 9 2022, 1:09 AM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D125157: [clang][Driver] Add more tests for riscv.
May 9 2022, 12:08 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 7 2022

Pretty-box updated the diff for D125157: [clang][Driver] Add more tests for riscv.
May 7 2022, 1:09 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 6 2022

Pretty-box requested review of D125157: [clang][Driver] Add more tests for riscv.
May 6 2022, 11:13 PM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 26 2022

Pretty-box updated the summary of D124428: [RISCV] Add RV64Zbs invalid tests.
Apr 26 2022, 6:33 PM · Unknown Object (Project), Restricted Project

Apr 25 2022

Pretty-box added inline comments to D124428: [RISCV] Add RV64Zbs invalid tests.
Apr 25 2022, 7:29 PM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D124428: [RISCV] Add RV64Zbs invalid tests.
Apr 25 2022, 7:06 PM · Unknown Object (Project), Restricted Project

Apr 15 2022

Pretty-box added a comment to D123839: [RISCV][NFC] Use defvar to simplify pattern definations..

Address comment

Apr 15 2022, 2:29 AM · Unknown Object (Project), Restricted Project
Pretty-box updated the diff for D123839: [RISCV][NFC] Use defvar to simplify pattern definations..
Apr 15 2022, 1:49 AM · Unknown Object (Project), Restricted Project
Pretty-box added a reviewer for D123839: [RISCV][NFC] Use defvar to simplify pattern definations.: jacquesguan.
Apr 15 2022, 12:50 AM · Unknown Object (Project), Restricted Project
Pretty-box requested review of D123839: [RISCV][NFC] Use defvar to simplify pattern definations..
Apr 15 2022, 12:36 AM · Unknown Object (Project), Restricted Project

Apr 13 2022

Pretty-box added a comment to D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.

Patch application failed, apparently. Maybe you need to rebase?

Apr 13 2022, 2:22 AM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 13 2022, 2:21 AM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 13 2022, 12:42 AM · Restricted Project, Unknown Object (Project)

Apr 11 2022

Pretty-box added inline comments to D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 11 2022, 7:26 PM · Restricted Project, Unknown Object (Project)

Apr 6 2022

Pretty-box updated the diff for D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 6 2022, 8:42 PM · Restricted Project, Unknown Object (Project)
Pretty-box added a comment to D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.

address comments

Apr 6 2022, 7:06 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 6 2022, 6:58 PM · Restricted Project, Unknown Object (Project)
Pretty-box updated the diff for D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 6 2022, 1:37 AM · Restricted Project, Unknown Object (Project)

Apr 5 2022

Pretty-box requested review of D123176: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
Apr 5 2022, 8:24 PM · Restricted Project, Unknown Object (Project)
Pretty-box retitled D122961: [RISCV][NFC] Remove some check prefixes as it works the same as FileCheck from [RISCV][NFC] Update RISCV rvv test cases to [RISCV][NFC] Remove some check prefixes as it works the same as FileCheck.
Apr 5 2022, 6:34 PM · Restricted Project, Unknown Object (Project)

Apr 1 2022

Pretty-box updated the diff for D122961: [RISCV][NFC] Remove some check prefixes as it works the same as FileCheck.
Apr 1 2022, 11:17 PM · Restricted Project, Unknown Object (Project)
Pretty-box requested review of D122961: [RISCV][NFC] Remove some check prefixes as it works the same as FileCheck.
Apr 1 2022, 8:43 PM · Restricted Project, Unknown Object (Project)

Dec 15 2021

Pretty-box updated Pretty-box.
Dec 15 2021, 11:42 PM
Pretty-box updated Pretty-box.
Dec 15 2021, 11:42 PM