This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines
ClosedPublic

Authored by Pretty-box on May 11 2022, 12:29 AM.

Diff Detail

Event Timeline

Pretty-box created this revision.May 11 2022, 12:29 AM
Pretty-box requested review of this revision.May 11 2022, 12:29 AM

Would it be better to change the common CHECK to RV32 in rv32 tests, and RV64 in rv64 tests ?

asb accepted this revision.May 11 2022, 6:13 AM

LGTM, thanks for the cleanup. I though update_llc_test_checks struggled with these combinations but it seems not (or at least, not any more).

This revision is now accepted and ready to land.May 11 2022, 6:13 AM
asb added a comment.May 11 2022, 6:15 AM

Would it be better to change the common CHECK to RV32 in rv32 tests, and RV64 in rv64 tests ?

I don't feel overly strongly CHECK vs RV32/RV64, but I can see the logic to that change.

This revision was landed with ongoing or failed builds.May 11 2022, 7:25 PM
This revision was automatically updated to reflect the committed changes.