Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Would it be better to change the common CHECK to RV32 in rv32 tests, and RV64 in rv64 tests ?
Comment Actions
LGTM, thanks for the cleanup. I though update_llc_test_checks struggled with these combinations but it seems not (or at least, not any more).
Comment Actions
I don't feel overly strongly CHECK vs RV32/RV64, but I can see the logic to that change.