This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Remove special case parsing/printing of `func` operations
ClosedPublic

Authored by rriddle on Apr 20 2022, 10:44 PM.

Details

Summary

This was leftover from when the standard dialect was destroyed, and
when FuncOp moved to the func dialect. Now that these transitions
have settled a bit we can drop these.

Diff Detail

Event Timeline

rriddle created this revision.Apr 20 2022, 10:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Apr 20 2022, 10:44 PM

After approval, I'm planning to make a post on discourse before landing a week or so afterwards.

jpienaar accepted this revision.Apr 21 2022, 1:12 AM

Conceptually Module had func as default dialect before too but having Builtin know of Func feels weird, so LGTM.

This revision is now accepted and ready to land.Apr 21 2022, 1:12 AM
rriddle updated this revision to Diff 424276.Apr 21 2022, 1:02 PM

Can you please include the regex for the update of mlir files in the description?

This revision was landed with ongoing or failed builds.May 6 2022, 1:48 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald Transcript