Page MenuHomePhabricator
Differential D124086

[AMDGPU] Remove no-ret atomic ops selection in the post-isel hook
ClosedPublic
Actions

Authored by abinavpp on Apr 20 2022, 4:01 AM.

Details

Reviewers
arsenm
foad
Petar.Avramovic
rampitec
Commits
rG2147b6c89d44: [AMDGPU] Remove no-ret atomic ops selection in the post-isel hook
Summary

No-ret atomic ops are now selected in tblgen.

Diff Detail

Unit TestsFailed
View All

TimeTest
210 msx64 debian > LLVM.CodeGen/AMDGPU::fp-atomics-gfx940.ll
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/fp-atomics-gfx940.ll -march=amdgcn -mcpu=gfx940 -verify-machineinstrs | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/fp-atomics-gfx940.ll -check-prefix=GFX940
180 msx64 debian > LLVM.CodeGen/AMDGPU/GlobalISel::fp-atomics-gfx940.ll
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/GlobalISel/fp-atomics-gfx940.ll -march=amdgcn -mcpu=gfx940 -verify-machineinstrs | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/GlobalISel/fp-atomics-gfx940.ll -check-prefix=GFX940
60,060 msx64 debian > MLIR.Examples/standalone::test.toy
Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir ; /usr/bin/cmake --build . --target check-standalone | tee /var/lib/buildkite-agent/builds/llvm-project/build/tools/mlir/test/Examples/standalone/Output/test.toy.tmp | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Examples/standalone/test.toy
60,030 msx64 debian > libFuzzer.libFuzzer::large.test
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LargeTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/large.test.tmp-LargeTest

Event Timeline

abinavpp created this revision.Apr 20 2022, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 4:01 AM
Herald added subscribers: hsmhsm, kerbowa, hiraditya and 7 others. · View Herald Transcript
abinavpp requested review of this revision.Apr 20 2022, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 4:01 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
abinavpp added a parent revision: D124084: [AMDGPU] Remove atomic pattern args in FLAT_[Global_]Atomic_Pseudo defs.Apr 20 2022, 4:05 AM
foad accepted this revision.Apr 20 2022, 4:20 AM
This revision is now accepted and ready to land.Apr 20 2022, 4:20 AM
Harbormaster completed remote builds in B160427: Diff 423866.Apr 20 2022, 5:31 AM
arsenm accepted this revision.Apr 20 2022, 6:12 AM
abinavpp mentioned this in D123583: [AMDGPU] Select no-return atomic intrinsics in tblgen.Apr 20 2022, 10:56 PM
This revision was landed with ongoing or failed builds.Apr 21 2022, 9:19 PM
Closed by commit rG2147b6c89d44: [AMDGPU] Remove no-ret atomic ops selection in the post-isel hook (authored by abinavpp). · Explain Why
This revision was automatically updated to reflect the committed changes.
abinavpp added a commit: rG2147b6c89d44: [AMDGPU] Remove no-ret atomic ops selection in the post-isel hook.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
41 lines

Diff 423866

View Options

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Loading...