Page MenuHomePhabricator

[AMDGPU] Select no-return atomic intrinsics in tblgen
ClosedPublic

Authored by abinavpp on Apr 12 2022, 3:44 AM.

Details

Summary

This is to avoid relying on the post-isel hook.

This change also enable the saddr pattern selection for atomic
intrinsics in GlobalISel.

Diff Detail

Event Timeline

abinavpp created this revision.Apr 12 2022, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 3:44 AM
abinavpp requested review of this revision.Apr 12 2022, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 3:44 AM
arsenm added inline comments.Apr 12 2022, 5:57 AM
llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
558–566

I don't like using int_ prefixes here. This is deceptive and makes it look like you are using raw intrinsics

abinavpp updated this revision to Diff 422279.Apr 12 2022, 10:11 AM

Addressed review comment

abinavpp marked an inline comment as done.Apr 12 2022, 10:12 AM
arsenm added inline comments.Apr 12 2022, 3:49 PM
llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
559

This just moved the int_ prefix, and doesn't eliminate it. I just realized these are the cases that only come from the intrinsics, so maybe this is fine (but just directly using int_ before would be better)

abinavpp updated this revision to Diff 422385.Apr 12 2022, 8:15 PM

Revert to Diff 1

abinavpp marked an inline comment as done.Apr 12 2022, 8:15 PM

Ping; This is required for D124086

arsenm accepted this revision.Apr 21 2022, 6:40 AM
This revision is now accepted and ready to land.Apr 21 2022, 6:40 AM
This revision was landed with ongoing or failed builds.Apr 21 2022, 9:10 PM
This revision was automatically updated to reflect the committed changes.