Page MenuHomePhabricator
Differential D123584

[AMDGPU] Select no-return DS_PK_ADD_F16 in tblgen
ClosedPublic
Actions

Authored by abinavpp on Apr 12 2022, 3:46 AM.

Details

Reviewers
arsenm
foad
Petar.Avramovic
rampitec
Commits
rGf935908d7b62: [AMDGPU] Select no-return DS_PK_ADD_F16 in tblgen

Diff Detail

Event Timeline

abinavpp created this revision.Apr 12 2022, 3:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 3:46 AM
Herald added subscribers: hsmhsm, kerbowa, hiraditya and 6 others. · View Herald Transcript
abinavpp requested review of this revision.Apr 12 2022, 3:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 3:46 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B159191: Diff 422168.Apr 12 2022, 3:46 AM
abinavpp added a parent revision: D123583: [AMDGPU] Select no-return atomic intrinsics in tblgen.Apr 12 2022, 3:47 AM
arsenm accepted this revision.Apr 12 2022, 5:53 AM

LGTM. Is this missing code removal for the manual selection?

This revision is now accepted and ready to land.Apr 12 2022, 5:53 AM
abinavpp added a child revision: D124084: [AMDGPU] Remove atomic pattern args in FLAT_[Global_]Atomic_Pseudo defs.Apr 20 2022, 4:06 AM
This revision was landed with ongoing or failed builds.Apr 21 2022, 9:17 PM
Closed by commit rGf935908d7b62: [AMDGPU] Select no-return DS_PK_ADD_F16 in tblgen (authored by abinavpp). · Explain Why
This revision was automatically updated to reflect the committed changes.
abinavpp added a commit: rGf935908d7b62: [AMDGPU] Select no-return DS_PK_ADD_F16 in tblgen.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
3 lines

Diff 424369

View Options

llvm/lib/Target/AMDGPU/DSInstructions.td

Loading...