This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][HIP] Fix gpu.used.external
ClosedPublic

Authored by yaxunl on Apr 18 2022, 8:13 AM.

Details

Summary

Rename gpu.used.external as __clang_gpu_used_external as ptxas does not
allow . in global variable name.

Fixes: https://github.com/llvm/llvm-project/issues/54934

Diff Detail

Event Timeline

yaxunl created this revision.Apr 18 2022, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 8:13 AM
Herald added a subscriber: mattd. · View Herald Transcript
yaxunl requested review of this revision.Apr 18 2022, 8:13 AM
jhuber6 accepted this revision.Apr 18 2022, 8:20 AM

LGTM

This revision is now accepted and ready to land.Apr 18 2022, 8:20 AM
tra accepted this revision.Apr 18 2022, 10:21 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 8:11 PM