This is an archive of the discontinued LLVM Phabricator instance.

Differential D123141

[clang][DOC] Document module mangler changes
ClosedPublic

Authored by urnathan on Apr 5 2022, 9:38 AM.

Details

Reviewers
iains
bruno
dblaikie
Commits
rG482fad4a3fcb: [clang][DOC] Document module mangler changes
Summary

Now the updated module mangling and demangling are in, here's a release note patch.

Diff Detail

Event Timeline

urnathan created this revision.Apr 5 2022, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 9:38 AM
urnathan requested review of this revision.Apr 5 2022, 9:38 AM
bruno added a comment.Apr 5 2022, 9:48 AM

Nice!

clang/docs/ReleaseNotes.rst
204

Probably worth saying "...scheme for C++20 modules" to avoid confusion that clang modules might have changed too.

Harbormaster completed remote builds in B158018: Diff 420557.Apr 5 2022, 10:51 AM
urnathan updated this revision to Diff 420783.Apr 6 2022, 4:47 AM

'c++20 modules' ...

urnathan marked an inline comment as done.Apr 6 2022, 4:48 AM
Harbormaster completed remote builds in B158173: Diff 420783.Apr 6 2022, 5:52 AM
bruno accepted this revision.Apr 6 2022, 10:38 AM
This revision is now accepted and ready to land.Apr 6 2022, 10:38 AM
Closed by commit rG482fad4a3fcb: [clang][DOC] Document module mangler changes (authored by urnathan). · Explain WhyApr 6 2022, 11:13 AM
This revision was automatically updated to reflect the committed changes.
urnathan added a commit: rG482fad4a3fcb: [clang][DOC] Document module mangler changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 11:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
docs/
7 lines

Diff 420951

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 195 Lines • ▼ Show 20 Lines
- Diagnose consteval and constexpr issues that happen at namespace scope. This - Diagnose consteval and constexpr issues that happen at namespace scope. This
partially addresses `Issue 51593 <https://github.com/llvm/llvm-project/issues/51593>`_. partially addresses `Issue 51593 <https://github.com/llvm/llvm-project/issues/51593>`_.
- No longer attempt to evaluate a consteval UDL function call at runtime when - No longer attempt to evaluate a consteval UDL function call at runtime when
it is called through a template instantiation. This fixes it is called through a template instantiation. This fixes
`Issue 54578 <https://github.com/llvm/llvm-project/issues/54578>`_. `Issue 54578 <https://github.com/llvm/llvm-project/issues/54578>`_.
- Implemented `__builtin_source_location()` which enables library support for std::source_location. - Implemented `__builtin_source_location()` which enables library support for std::source_location.
- The mangling scheme for C++20 modules has incompatibly changed. The
brunoUnsubmitted
Done
ReplyInline Actions

Probably worth saying "...scheme for C++20 modules" to avoid confusion that clang modules might have changed too.

bruno: Probably worth saying "...scheme for C++20 modules" to avoid confusion that clang modules might…
initial mangling was discovered not to be reversible, and the weak
ownership design decision did not give the backwards compatibility
that was hoped for. C++20 since added ``extern "C++"`` semantics
that can be used for such compatibility. The demangler now demangles
symbols with named module attachment.
C++2b Feature Support C++2b Feature Support
^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
- Implemented `P2128R6: Multidimensional subscript operator <https://wg21.link/P2128R6>`_. - Implemented `P2128R6: Multidimensional subscript operator <https://wg21.link/P2128R6>`_.
- Implemented `P0849R8: auto(x): decay-copy in the language <https://wg21.link/P0849R8>`_. - Implemented `P0849R8: auto(x): decay-copy in the language <https://wg21.link/P0849R8>`_.
- Implemented `P2242R3: Non-literal variables (and labels and gotos) in constexpr functions <https://wg21.link/P2242R3>`_. - Implemented `P2242R3: Non-literal variables (and labels and gotos) in constexpr functions <https://wg21.link/P2242R3>`_.
CUDA Language Changes in Clang CUDA Language Changes in Clang
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines