[flang][cmake] Move the CMake set-up for intrinsic module files

[awarzynski]

Summary

The CMake definitions for intrinsic module files are moved to the
directory that contains the modules' source files. As these modules are
generated using flang-new, the driver is added to the list of
dependencies.

[clementval]

Can you check why the patch application is failing?

[awarzynski]

In D122833#3421508, @clementval wrote:

Can you check why the patch application is failing?

That was due to missing patch dependency (there should be no colon in "Depends on D122015", which I did put there initially) . Fixed.

[kiranchandramohan]

flang/module/CMakeLists.txt

39

Why the name change? *.mod, as you know, is not a source file (although in flang it looks like one).

[awarzynski]

flang/module/CMakeLists.txt

39

My bad, I misread this. Thanks for catching it!

[awarzynski]

Revert change in spelling, re-base.

[sscalpone]

flang/CMakeLists.txt

415

The modules are more like the runtime than the tools. Is there a reason to keep this as part of the tools conditional?

flang/module/CMakeLists.txt

17

I don't know the answer: Do you need to keep the ${FLANG_INTRINSIC_MODULES_DIR} prefix?

flang/tools/f18/CMakeLists.txt

15

You might want to adjust the ambiguous pronoun reference "this" to be specific. Or just execute the TODO.

[awarzynski]

Feel free to commandeer this change, I'm no longer active in this area.

flang/CMakeLists.txt

 add_subdirectory(include)
 add_subdirectory(lib)
 add_subdirectory(cmake/modules)
 
 option(FLANG_BUILD_TOOLS
   "Build the Flang tools. If OFF, just generate build targets." ON)
 if (FLANG_BUILD_TOOLS)
   add_subdirectory(tools)
+  add_subdirectory(module)
 endif()
 add_subdirectory(runtime)
 
 option(FLANG_BUILD_EXAMPLES "Build Flang example programs by default." OFF)
 if (FLANG_BUILD_EXAMPLES AND FLANG_STANDALONE_BUILD)
   message(FATAL_ERROR "Examples are not supported in out-of-tree builds.")
 endif()
 add_subdirectory(examples)

flang/module/CMakeLists.txt

-set(LLVM_LINK_COMPONENTS
-  FrontendOpenACC
-  FrontendOpenMP
-  Support
-  )
-
 set(MODULES
   "__fortran_builtins"
   "__fortran_ieee_exceptions"
   "__fortran_type_info"
   "ieee_arithmetic"
   "ieee_exceptions"
   "ieee_features"
   "iso_c_binding"
   "iso_fortran_env"
   "omp_lib"
   "__fortran_builtins"
   "__fortran_type_info"
 )
 
-# Create module files directly from the top-level module source directory
+# Create module files
 foreach(filename ${MODULES})
   set(base ${FLANG_INTRINSIC_MODULES_DIR}/${filename})
   if(${filename} STREQUAL "__fortran_builtins")
     set(depends "")
   else()
     set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_builtins.mod)
     if(NOT ${filename} STREQUAL "__fortran_type_info")
       set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_type_info.mod)
     endif()
     if(${filename} STREQUAL "ieee_arithmetic" OR
        ${filename} STREQUAL "ieee_exceptions")
       set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_ieee_exceptions.mod)
     endif()
   endif()
   add_custom_command(OUTPUT ${base}.mod
     COMMAND ${CMAKE_COMMAND} -E make_directory ${FLANG_INTRINSIC_MODULES_DIR}
     COMMAND flang-new -fc1 -fsyntax-only -module-dir ${FLANG_INTRINSIC_MODULES_DIR}
       ${FLANG_SOURCE_DIR}/module/${filename}.f90
     DEPENDS flang-new ${FLANG_SOURCE_DIR}/module/${filename}.f90 ${depends}
   )
   add_custom_command(OUTPUT ${base}.f18.mod
     DEPENDS ${base}.mod
     COMMAND ${CMAKE_COMMAND} -E copy ${base}.mod ${base}.f18.mod)
-  list(APPEND MODULE_FILES ${base}.mod ${base}.f18.mod)
+  list(APPEND MODULE_SRC_FILES ${base}.mod ${base}.f18.mod)
   install(FILES ${base}.mod ${base}.f18.mod DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/flang")
 endforeach()
 
-add_custom_target(module_files ALL DEPENDS ${MODULE_FILES})
+set(FLANG_MODULES_DEPENDS
+  flang-new
+)
+list(APPEND FLANG_MODULE_DEPENDS ${MODULE_SRC_FILES})
 
-# This flang shell script will only work in a POSIX shell.
-if (NOT WIN32)
-  add_custom_command(
-    OUTPUT ${CMAKE_BINARY_DIR}/bin/flang
-    DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/flang
-    COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/flang ${CMAKE_BINARY_DIR}/bin)
-  add_custom_target(flang ALL DEPENDS ${CMAKE_BINARY_DIR}/bin/flang)
-  install(PROGRAMS ${CMAKE_BINARY_DIR}/bin/flang DESTINATION "${CMAKE_INSTALL_BINDIR}")
-endif()
+add_custom_target(module_files ALL DEPENDS ${FLANG_MODULE_DEPENDS})
 
 # TODO Move this to a more suitable location
 file(COPY ${FLANG_SOURCE_DIR}/module/omp_lib.h DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/flang/OpenMP/" FILE_PERMISSIONS OWNER_READ OWNER_WRITE)

flang/tools/f18/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   FrontendOpenACC
   FrontendOpenMP
   Support
   )
 
-set(MODULES
-  "__fortran_builtins"
-  "__fortran_ieee_exceptions"
-  "__fortran_type_info"
-  "ieee_arithmetic"
-  "ieee_exceptions"
-  "ieee_features"
-  "iso_c_binding"
-  "iso_fortran_env"
-  "omp_lib"
-  "__fortran_builtins"
-  "__fortran_type_info"
-)
-
-# Create module files directly from the top-level module source directory
-foreach(filename ${MODULES})
-  set(base ${FLANG_INTRINSIC_MODULES_DIR}/${filename})
-  if(${filename} STREQUAL "__fortran_builtins")
-    set(depends "")
-  else()
-    set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_builtins.mod)
-    if(NOT ${filename} STREQUAL "__fortran_type_info")
-      set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_type_info.mod)
-    endif()
-    if(${filename} STREQUAL "ieee_arithmetic" OR
-       ${filename} STREQUAL "ieee_exceptions")
-      set(depends ${FLANG_INTRINSIC_MODULES_DIR}/__fortran_ieee_exceptions.mod)
-    endif()
-  endif()
-  add_custom_command(OUTPUT ${base}.mod
-    COMMAND ${CMAKE_COMMAND} -E make_directory ${FLANG_INTRINSIC_MODULES_DIR}
-    COMMAND flang-new -fc1 -fsyntax-only -module-dir ${FLANG_INTRINSIC_MODULES_DIR}
-      ${FLANG_SOURCE_DIR}/module/${filename}.f90
-    DEPENDS flang-new ${FLANG_SOURCE_DIR}/module/${filename}.f90 ${depends}
-  )
-  add_custom_command(OUTPUT ${base}.f18.mod
-    DEPENDS ${base}.mod
-    COMMAND ${CMAKE_COMMAND} -E copy ${base}.mod ${base}.f18.mod)
-  list(APPEND MODULE_FILES ${base}.mod ${base}.f18.mod)
-  install(FILES ${base}.mod ${base}.f18.mod DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/flang")
-endforeach()
-
-add_custom_target(module_files ALL DEPENDS ${MODULE_FILES})
-
 # This flang shell script will only work in a POSIX shell.
 if (NOT WIN32)
   add_custom_command(
     OUTPUT ${CMAKE_BINARY_DIR}/bin/flang
     DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/flang
     COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/flang ${CMAKE_BINARY_DIR}/bin)
   add_custom_target(flang ALL DEPENDS ${CMAKE_BINARY_DIR}/bin/flang)
   install(PROGRAMS ${CMAKE_BINARY_DIR}/bin/flang DESTINATION "${CMAKE_INSTALL_BINDIR}")
 endif()
-
-# TODO Move this to a more suitable location
-file(COPY ${FLANG_SOURCE_DIR}/module/omp_lib.h DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/flang/OpenMP/" FILE_PERMISSIONS OWNER_READ OWNER_WRITE)