This is an archive of the discontinued LLVM Phabricator instance.

[flang][cmake] Move the CMake set-up for intrinsic module files

Authored by awarzynski on Mar 31 2022, 9:45 AM.



The CMake definitions for intrinsic module files are moved to the
directory that contains the modules' source files. As these modules are
generated using flang-new, the driver is added to the list of

Diff Detail

Event Timeline

awarzynski created this revision.Mar 31 2022, 9:45 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
awarzynski requested review of this revision.Mar 31 2022, 9:45 AM

Can you check why the patch application is failing?

Can you check why the patch application is failing?

That was due to missing patch dependency (there should be no colon in "Depends on D122015", which I did put there initially) . Fixed.


Why the name change? *.mod, as you know, is not a source file (although in flang it looks like one).

awarzynski added inline comments.Apr 6 2022, 8:34 AM

My bad, I misread this. Thanks for catching it!

awarzynski updated this revision to Diff 420889.Apr 6 2022, 8:35 AM

Revert change in spelling, re-base.

sscalpone added inline comments.Apr 6 2022, 9:47 PM

The modules are more like the runtime than the tools. Is there a reason to keep this as part of the tools conditional?


I don't know the answer: Do you need to keep the ${FLANG_INTRINSIC_MODULES_DIR} prefix?


You might want to adjust the ambiguous pronoun reference "this" to be specific. Or just execute the TODO.

klausler resigned from this revision.Feb 8 2023, 2:33 PM
awarzynski abandoned this revision.Feb 9 2023, 12:11 AM

Feel free to commandeer this change, I'm no longer active in this area.