This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][GlobalISel] Add new MOVI pattern for fp constants
ClosedPublic

Authored by Allen on Mar 28 2022, 12:43 AM.

Diff Detail

Event Timeline

Allen created this revision.Mar 28 2022, 12:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 12:43 AM
Allen requested review of this revision.Mar 28 2022, 12:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 12:43 AM

Optimizations specifically for -O0 are not usually needed, but it's good to add the optimization for global-isel.

llvm/test/CodeGen/AArch64/fast-isel-const-float.ll
2

This isn't testing fast-isel. Can you just add a -global-isel run line for the tests you already added for using movi?

Allen updated this revision to Diff 418533.Mar 28 2022, 3:40 AM
paquette accepted this revision.Mar 28 2022, 10:17 AM

Code looks equivalent to the fpimm32SIMDModImmType4XForm in AArch64InstrFormats.td, which looks fine to me.

This revision is now accepted and ready to land.Mar 28 2022, 10:17 AM
This revision was landed with ongoing or failed builds.Mar 28 2022, 7:57 PM
This revision was automatically updated to reflect the committed changes.