Page MenuHomePhabricator

Allen (Allen zhong)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 25 2020, 11:39 PM (117 w, 1 d)

Recent Activity

Fri, Mar 24

Allen added inline comments to D146702: [MergeICmps] Attach metadata to new created loads.
Fri, Mar 24, 8:47 PM · Restricted Project, Restricted Project

Thu, Mar 23

Allen added a reviewer for D146702: [MergeICmps] Attach metadata to new created loads: nikic.
Thu, Mar 23, 2:17 AM · Restricted Project, Restricted Project
Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.
  • the metadata for the loads in the entry block don't need to be dropped? hi @aeubanks, I try to address above metadata issue on D146702.
Thu, Mar 23, 2:10 AM · Restricted Project, Restricted Project
Allen requested review of D146702: [MergeICmps] Attach metadata to new created loads.
Thu, Mar 23, 2:07 AM · Restricted Project, Restricted Project

Wed, Mar 22

Allen committed rG7949a2a802f0: [InstCombine] enhance icmp with sub folds (authored by Allen).
[InstCombine] enhance icmp with sub folds
Wed, Mar 22, 4:57 AM · Restricted Project, Restricted Project
Allen closed D145846: [InstCombine] enhance icmp with sub folds.
Wed, Mar 22, 4:57 AM · Restricted Project, Restricted Project
Allen abandoned D146268: [tests] precommit tests for D145846.
Wed, Mar 22, 4:51 AM · Restricted Project, Restricted Project
Allen added a comment to D146268: [tests] precommit tests for D145846.

close as commit e2f6ebe8ca15

Wed, Mar 22, 4:50 AM · Restricted Project, Restricted Project
Allen committed rGe2f6ebe8ca15: [tests] precommit tests for D145846 (authored by Allen).
[tests] precommit tests for D145846
Wed, Mar 22, 4:48 AM · Restricted Project, Restricted Project
Allen updated the diff for D145846: [InstCombine] enhance icmp with sub folds.

Address comment
1、delete the repeat ICMP_NE check, as isEquality() already include it
2、use "thwart complexity-based canonicalization" for commuted case

Wed, Mar 22, 12:52 AM · Restricted Project, Restricted Project
Allen updated the diff for D146268: [tests] precommit tests for D145846.

Add "thwart complexity-based canonicalization"

Wed, Mar 22, 12:49 AM · Restricted Project, Restricted Project

Sun, Mar 19

Allen added a reviewer for D145846: [InstCombine] enhance icmp with sub folds: nikic.
Sun, Mar 19, 10:18 PM · Restricted Project, Restricted Project
Allen updated the diff for D145846: [InstCombine] enhance icmp with sub folds.

address commet
1、Add more cases (also update on D146268)
2、update with getScalarSizeInBits and add related vector case
3、use ICmpInst::isEquality(Pred) to replace Pred == ICmpInst::ICMP_EQ
4、I.getPredicate() --> Pred

Sun, Mar 19, 10:18 PM · Restricted Project, Restricted Project
Allen updated the diff for D146268: [tests] precommit tests for D145846.
Sun, Mar 19, 10:13 PM · Restricted Project, Restricted Project
Allen updated the diff for D146268: [tests] precommit tests for D145846.

Add more tests according comment

Sun, Mar 19, 9:42 PM · Restricted Project, Restricted Project

Sat, Mar 18

Allen added a comment to D145846: [InstCombine] enhance icmp with sub folds.

ping ?

Sat, Mar 18, 10:51 PM · Restricted Project, Restricted Project
Allen committed rG22c3ba4bb519: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode (authored by lizhijin).
[SVE] Add patterns for shift intrinsics with FalseLanesZero mode
Sat, Mar 18, 10:49 PM · Restricted Project, Restricted Project
Allen closed D145551: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode.
Sat, Mar 18, 10:49 PM · Restricted Project, Restricted Project

Thu, Mar 16

Allen added a reviewer for D145846: [InstCombine] enhance icmp with sub folds: goldstein.w.n.
Thu, Mar 16, 8:27 PM · Restricted Project, Restricted Project
Allen added a comment to D145846: [InstCombine] enhance icmp with sub folds.

The new IR with and removes a use of the input variable, which is better for analysis.

"and" -> And (otherwise it looks like the conjugation, not the operator.

Thu, Mar 16, 7:38 PM · Restricted Project, Restricted Project
Allen updated the diff for D145846: [InstCombine] enhance icmp with sub folds.

1、Precommit the test
2、Add m_OneUse

Thu, Mar 16, 7:37 PM · Restricted Project, Restricted Project
Allen requested review of D146268: [tests] precommit tests for D145846.
Thu, Mar 16, 6:55 PM · Restricted Project, Restricted Project
Allen updated the summary of D145846: [InstCombine] enhance icmp with sub folds.
Thu, Mar 16, 4:26 AM · Restricted Project, Restricted Project

Tue, Mar 14

Allen added reviewers for D145846: [InstCombine] enhance icmp with sub folds: efriedma, RKSimon.
Tue, Mar 14, 2:34 AM · Restricted Project, Restricted Project

Sat, Mar 11

Allen requested review of D145846: [InstCombine] enhance icmp with sub folds.
Sat, Mar 11, 6:30 AM · Restricted Project, Restricted Project
Allen abandoned D144324: [AArch64][SelectionDAG] Perfer CMN for (0 - Y) == Y.

Agree with @spatel , should be redesign in IR level

Sat, Mar 11, 3:02 AM · Restricted Project, Restricted Project

Thu, Mar 9

Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

I'm continuing to see the same unit test failure as https://crbug.com/1420824#c2 after including the latest commit

Thu, Mar 9, 5:12 PM · Restricted Project, Restricted Project
Allen committed rG818e554e251c: [MergeICmps] Adapt to non-eq comparisons, fix bug for cases need be spilted (authored by Allen).
[MergeICmps] Adapt to non-eq comparisons, fix bug for cases need be spilted
Thu, Mar 9, 7:54 AM · Restricted Project, Restricted Project
Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

Thank for your carefully examine.

Thu, Mar 9, 2:47 AM · Restricted Project, Restricted Project

Wed, Mar 8

Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

The crash comes from D143225.

Wed, Mar 8, 11:04 PM · Restricted Project, Restricted Project
Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

Thanks @glandium and @ayzhao, I'm trying to reproduce the above issue with chromium's code

Wed, Mar 8, 8:47 PM · Restricted Project, Restricted Project

Tue, Mar 7

Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

FYI this patch also caused some of Firefox's unit tests to fail, e.g. https://treeherder.mozilla.org/logviewer?job_id=407511605&repo=toolchains&lineNumber=32470

Tue, Mar 7, 2:53 AM · Restricted Project, Restricted Project
Allen updated the diff for D141188: [MergeICmps] Adapt to non-eq comparisons.

Fix the runtime issue related to test unittests/ProfileData/ProfileDataTests.

Tue, Mar 7, 2:51 AM · Restricted Project, Restricted Project

Mon, Mar 6

Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

For the runtime fails of unittests/ProfileData/ProfileDataTests, there is 2 points important

  • a) build without -g fall as it transform code (From function _ZN12_GLOBAL__N_152CoverageMappingTest_test_line_coverage_iterator_Test8TestBodyEv)
_ZNK4llvm14iterator_rangeINS_8coverage20LineCoverageIteratorEE3endEv.exit: ; preds = %_ZNK4llvm14iterator_rangeINS_8coverage20LineCoverageIteratorEE5beginEv.exit, %if.then.i.i.i294
  %Stats.i.i295 = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__end1, i64 0, i32 6
  %Stats4.i.i296 = getelementptr inbounds %"class.llvm::iterator_range", ptr %ref.tmp32, i64 0, i32 1, i32 6
  call void @llvm.memcpy.p0.p0.i64(ptr noundef nonnull align 8 dereferenceable(40) %Stats.i.i295, ptr noundef nonnull align 8 dereferenceable(40) %Stats4.i.i296, i64 40, i1 false), !tbaa.struct !339
  %Next.i.i299 = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__begin1, i64 0, i32 2
  %Next3.i.i = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__end1, i64 0, i32 2
  %Ended.i.i301 = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__begin1, i64 0, i32 3
  %Ended4.i.i = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__end1, i64 0, i32 3
  %Line.i = getelementptr inbounds %"class.llvm::coverage::LineCoverageIterator", ptr %__begin1, i64 0, i32 6, i32 3
  %message_.i320 = getelementptr inbounds %"class.testing::AssertionResult", ptr %gtest_ar35, i64 0, i32 1
  %message_.i386 = getelementptr inbounds %"class.testing::AssertionResult", ptr %gtest_ar55, i64 0, i32 1
  br label %for.cond
Mon, Mar 6, 4:56 AM · Restricted Project, Restricted Project

Wed, Mar 1

Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

@Allen test unittests/ProfileData/ProfileDataTests fails when built with optimisations level -O1 with clang including this patch.

When building the test with -O3 (Release) or -O1 -g it passes.

Not sure if this patch triggers some other bug in clang or the test has UB or the patch itself is to blame.
Please revert this patch and investigate the issue without any pressure.

Wed, Mar 1, 5:13 PM · Restricted Project, Restricted Project
Allen added a reverting change for rG74ad19c25d72: [MergeICmps] Adapt to non-eq comparisons, retry: rGaf2969fd46b7: Revert "[MergeICmps] Adapt to non-eq comparisons, retry".
Wed, Mar 1, 5:11 PM · Restricted Project, Restricted Project
Allen committed rGaf2969fd46b7: Revert "[MergeICmps] Adapt to non-eq comparisons, retry" (authored by Allen).
Revert "[MergeICmps] Adapt to non-eq comparisons, retry"
Wed, Mar 1, 5:11 PM · Restricted Project, Restricted Project
Allen added a reverting change for D141188: [MergeICmps] Adapt to non-eq comparisons: rGaf2969fd46b7: Revert "[MergeICmps] Adapt to non-eq comparisons, retry".
Wed, Mar 1, 5:11 PM · Restricted Project, Restricted Project
Allen committed rG15d5c59280c9: [InstCombine] Improvement the analytics through the dominating condition (authored by Allen).
[InstCombine] Improvement the analytics through the dominating condition
Wed, Mar 1, 1:04 AM · Restricted Project, Restricted Project
Allen closed D144248: [InstCombine] Improvement the analytics through the dominating condition.
Wed, Mar 1, 1:03 AM · Restricted Project, Restricted Project

Tue, Feb 28

Allen added reviewers for D144248: [InstCombine] Improvement the analytics through the dominating condition: arsenm, dmgreen.
Tue, Feb 28, 5:00 AM · Restricted Project, Restricted Project
Allen updated the diff for D144248: [InstCombine] Improvement the analytics through the dominating condition.
  1. Rebase to update test after precommit
  2. modify some cases's condition to avoid being their BBs optimizing away through the domination
Tue, Feb 28, 4:57 AM · Restricted Project, Restricted Project

Mon, Feb 27

Herald added a project to D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.: Restricted Project.
Mon, Feb 27, 5:57 PM · Restricted Project, Restricted Project, Restricted Project
Allen committed rGd514726d3132: [AMDGPU] Update the CHECK autogenerated as it's expired (authored by Allen).
[AMDGPU] Update the CHECK autogenerated as it's expired
Mon, Feb 27, 10:09 AM · Restricted Project, Restricted Project
Allen closed D144771: [AMDGPU] Update the CHECK autogenerated as it's expired.
Mon, Feb 27, 10:08 AM · Restricted Project, Restricted Project
Allen committed rGec67d703cfb0: [SVE] Add intrinsics for uniform dsp operations that explicitly undefine the… (authored by dewen).
[SVE] Add intrinsics for uniform dsp operations that explicitly undefine the…
Mon, Feb 27, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
Allen closed D144704: [SVE] Add intrinsics for uniform dsp operations that explicitly undefine the result for inactive lanes..
Mon, Feb 27, 2:45 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Feb 26

Allen updated the diff for D144771: [AMDGPU] Update the CHECK autogenerated as it's expired.

rebase to top and fix the missing match

Sun, Feb 26, 6:19 PM · Restricted Project, Restricted Project
Herald added a reviewer for D62306: [AArch64][SVE2] Asm: support SVE2 Histogram Computation Groups: efriedma.
Sun, Feb 26, 6:02 PM · Restricted Project, Restricted Project
Allen committed rG74ad19c25d72: [MergeICmps] Adapt to non-eq comparisons, retry (authored by Allen).
[MergeICmps] Adapt to non-eq comparisons, retry
Sun, Feb 26, 9:28 AM · Restricted Project, Restricted Project
Allen closed D141188: [MergeICmps] Adapt to non-eq comparisons.
Sun, Feb 26, 9:27 AM · Restricted Project, Restricted Project

Fri, Feb 24

Allen added a comment to D144248: [InstCombine] Improvement the analytics through the dominating condition.

I will precommit to update the expired check on D144771

Fri, Feb 24, 7:57 PM · Restricted Project, Restricted Project
Allen added reviewers for D144771: [AMDGPU] Update the CHECK autogenerated as it's expired: nikic, arsenm, dmgreen.
Fri, Feb 24, 7:55 PM · Restricted Project, Restricted Project
Allen requested review of D144771: [AMDGPU] Update the CHECK autogenerated as it's expired.
Fri, Feb 24, 7:53 PM · Restricted Project, Restricted Project

Feb 22 2023

Allen added a comment to D144248: [InstCombine] Improvement the analytics through the dominating condition.

hi @arsenm, as the CHECK of these case are not updated with update_llc_test_checks.py, so it is a bit hard to update, do you mind I Precommit the CHECK regenerated with update_llc_test_checks.py for these 4 cases ?

Feb 22 2023, 8:04 PM · Restricted Project, Restricted Project

Feb 21 2023

Allen updated the diff for D144248: [InstCombine] Improvement the analytics through the dominating condition.

Fix 4 AMDGPU backend failed cases

LLVM :: CodeGen/AMDGPU/branch-relaxation.ll
LLVM :: CodeGen/AMDGPU/collapse-endcf.ll
LLVM :: CodeGen/AMDGPU/infinite-loop.ll
LLVM :: CodeGen/AMDGPU/uniform-cfg.ll
Feb 21 2023, 7:37 PM · Restricted Project, Restricted Project
Allen updated the diff for D144248: [InstCombine] Improvement the analytics through the dominating condition.

Address comments

  1. Add return false and its test case urem_with_dominating_condition_false
  2. Delete some calls in function simplifyBinaryIntrinsic and foldICmpWithDominatingICmp, and update its case affected
  3. update tile
Feb 21 2023, 2:56 AM · Restricted Project, Restricted Project
Allen added a comment to D144248: [InstCombine] Improvement the analytics through the dominating condition.

Why was this abandoned? Just to be clear, I did not commit anything, just testing behavior.

Feb 21 2023, 2:18 AM · Restricted Project, Restricted Project
Allen abandoned D144248: [InstCombine] Improvement the analytics through the dominating condition.

I see. It looks like this much is safe to do without causing any regressions: https://github.com/nikic/llvm-project/commit/37366dc6bc6d168f081510a603982802a6964221 The ones in simplifyBinaryIntrinsic() and foldICmpWithDominatingICmp() are completely redundant.

The one in simplifySelectInst() is not redundant, because it uses a different context instruction: We would miss cases where we have br i1 %c followed by select i1 %c, because the comparison is not in the same block as the select. This is unfortunate...

Feb 21 2023, 1:09 AM · Restricted Project, Restricted Project
Allen added a comment to D144248: [InstCombine] Improvement the analytics through the dominating condition.

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=45a0b812fa13ec255cae91f974540a4d805a8d79&to=787c3e2333e8d655a61ef013f7006d7675c03574&stat=instructions%3Au Some impact, but less than I expected, so I think we can do this.

This patch should also remove the isImpliedByDomCondition() calls in simplifySelectInst() and simplifyBinaryIntrinsic(), because they are subsumed by this one.

Feb 21 2023, 12:03 AM · Restricted Project, Restricted Project

Feb 20 2023

Allen added a comment to D144324: [AArch64][SelectionDAG] Perfer CMN for (0 - Y) == Y.

Yes, Agree your idea, thanks @spatel. I also realize that the cmn directive may not exist on all backends? so this is not appropriate.

Feb 20 2023, 5:13 PM · Restricted Project, Restricted Project
Allen added a comment to D141188: [MergeICmps] Adapt to non-eq comparisons.

hi @vitalybuka, as the issue can't be repoduced locally, do you object to retry again ?

Feb 20 2023, 8:32 AM · Restricted Project, Restricted Project
Allen committed rGee9a0f30ca8a: [InstCombine] canonicalize urem as cmp+select (authored by Allen).
[InstCombine] canonicalize urem as cmp+select
Feb 20 2023, 7:53 AM · Restricted Project, Restricted Project
Allen closed D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 20 2023, 7:53 AM · Restricted Project, Restricted Project
Allen committed rG2e0f91739ecc: [test] precommit some tests for D143883 NFC (authored by Allen).
[test] precommit some tests for D143883 NFC
Feb 20 2023, 7:48 AM · Restricted Project, Restricted Project
Allen closed D144372: [test] precommit some tests for D143883 NFC.
Feb 20 2023, 7:47 AM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

update as precommit test in D144372 according review.

Feb 20 2023, 2:46 AM · Restricted Project, Restricted Project
Allen requested review of D144372: [test] precommit some tests for D143883 NFC.
Feb 20 2023, 2:44 AM · Restricted Project, Restricted Project

Feb 18 2023

Allen planned changes to D144324: [AArch64][SelectionDAG] Perfer CMN for (0 - Y) == Y.
Feb 18 2023, 1:12 AM · Restricted Project, Restricted Project
Allen updated the diff for D144324: [AArch64][SelectionDAG] Perfer CMN for (0 - Y) == Y.

update comment

Feb 18 2023, 12:50 AM · Restricted Project, Restricted Project
Allen requested review of D144324: [AArch64][SelectionDAG] Perfer CMN for (0 - Y) == Y.
Feb 18 2023, 12:49 AM · Restricted Project, Restricted Project

Feb 17 2023

Allen added inline comments to D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 17 2023, 5:50 PM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

Address comments:
a) Drop all the attribute noundef on the argument and return value
b) Change all the value type to i8 as Alive2 can run quickly on all tests to verify correctness
c) Update case urem_without_assume

Feb 17 2023, 5:47 PM · Restricted Project, Restricted Project
Allen updated the diff for D144248: [InstCombine] Improvement the analytics through the dominating condition.

update upstream test case

Feb 17 2023, 2:23 AM · Restricted Project, Restricted Project
Allen requested review of D144248: [InstCombine] Improvement the analytics through the dominating condition.
Feb 17 2023, 2:11 AM · Restricted Project, Restricted Project

Feb 16 2023

Allen added inline comments to D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 16 2023, 6:10 PM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

Add a new case urem_with_dominating_condition

Feb 16 2023, 6:09 PM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

Address comments:
a) Adding a new case urem_without_assume
b) Update the code comment to match the code
c) Rename the FreezeX to FreezeOp0 as the name suggests

Feb 16 2023, 5:40 PM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

Address comments

  • use match(Val, m_One()) to replace CVal->isOneValue()
  • Drop the attribute noundef of function urem_assume_without_nuw, then it will see freeze
  • Add a new negative case urem_assume_with_unexpected_const
Feb 16 2023, 4:39 AM · Restricted Project, Restricted Project
Allen added inline comments to D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 16 2023, 1:05 AM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

use SQ.getWithInstruction(&I) to to change the context instruction

Feb 16 2023, 1:03 AM · Restricted Project, Restricted Project

Feb 15 2023

Allen added inline comments to D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 15 2023, 5:18 PM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

update to use dyn_cast_or_null according comment

Feb 15 2023, 5:14 PM · Restricted Project, Restricted Project
Allen added inline comments to D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 15 2023, 4:26 AM · Restricted Project, Restricted Project
Allen updated the diff for D143883: [InstCombine] canonicalize urem as cmp+select.

Address comments:
a) check the assume with more generate API simplifyICmpInst
b) Add 3 test cases, including some Negative tests
c) Fix the checking and only do this when the return value is isOneValue()
d) Add the logic of frozen

Feb 15 2023, 4:23 AM · Restricted Project, Restricted Project

Feb 13 2023

Allen abandoned D143705: [LoopBoundSplit] Delete redundant loop guard.

Thanks @mkazantsev for correcting

Feb 13 2023, 12:41 AM · Restricted Project, Restricted Project
Allen requested review of D143883: [InstCombine] canonicalize urem as cmp+select.
Feb 13 2023, 12:36 AM · Restricted Project, Restricted Project

Feb 10 2023

Allen added a comment to D102234: [SimpleLoopBoundSplit] Split Bound of Loop which has conditional branch with IV.

I add a MR, try to remove the loop guard in loop guard D143705.

Feb 10 2023, 12:40 AM · Restricted Project, Restricted Project
Allen requested review of D143705: [LoopBoundSplit] Delete redundant loop guard.
Feb 10 2023, 12:37 AM · Restricted Project, Restricted Project

Feb 9 2023

Allen committed rGb1c4ceccf993: [SVE] Add intrinsics for logical/bitwise operations that explicitly undefine… (authored by lizhijin).
[SVE] Add intrinsics for logical/bitwise operations that explicitly undefine…
Feb 9 2023, 10:54 PM · Restricted Project, Restricted Project, Restricted Project
Allen closed D143499: [SVE] Add intrinsics for logical/bitwise operations that explicitly undefine the result for inactive lanes..
Feb 9 2023, 10:54 PM · Restricted Project, Restricted Project, Restricted Project
Allen added a comment to D138652: [SVE][AArch64] Use WHILEWR to check write-after-read conflicts.

Thanks very much for detail idea.

Feb 9 2023, 5:01 PM · Restricted Project, Restricted Project

Feb 7 2023

Allen committed rGe80f461d99ed: [AArch64] Fix missing comment on D138888, NFC (authored by Allen).
[AArch64] Fix missing comment on D138888, NFC
Feb 7 2023, 6:01 PM · Restricted Project, Restricted Project
Allen closed D143459: [AArch64] Fix missing comment on D138888, NFC.
Feb 7 2023, 6:00 PM · Restricted Project, Restricted Project

Feb 6 2023

Allen requested review of D143459: [AArch64] Fix missing comment on D138888, NFC.
Feb 6 2023, 7:52 PM · Restricted Project, Restricted Project
Allen added reviewers for D138652: [SVE][AArch64] Use WHILEWR to check write-after-read conflicts: david-arm, sdesmalen.
Feb 6 2023, 7:45 PM · Restricted Project, Restricted Project
Allen added a comment to D138888: [AArch64][SVE] Replace destructive operand of vector zeros with a bundled MOVPRFX instruction.

sorry, missing the above review, and I'll fix that.

Feb 6 2023, 7:19 PM · Restricted Project, Restricted Project
Allen committed rG341b1df5bc7e: [AArch64][SVE] Fix crash for DestructiveBinaryCommWithRev zero merging (authored by Allen).
[AArch64][SVE] Fix crash for DestructiveBinaryCommWithRev zero merging
Feb 6 2023, 7:14 PM · Restricted Project, Restricted Project
Allen closed D142978: [AArch64][SVE] Fix crash for DestructiveBinaryCommWithRev zero merging.
Feb 6 2023, 7:14 PM · Restricted Project, Restricted Project
Allen committed rG39af4659f240: [AArch64][SVE] Replace destructive operand of vector zeros with a bundled… (authored by Allen).
[AArch64][SVE] Replace destructive operand of vector zeros with a bundled…
Feb 6 2023, 7:04 PM · Restricted Project, Restricted Project