This is an archive of the discontinued LLVM Phabricator instance.

[VPlan] VPInterleaveRecipe only requires the first lane of the address.
ClosedPublic

Authored by fhahn on Mar 14 2022, 9:41 AM.

Details

Summary

VPInterleaveRecipe only uses the first lane of the address. Add
onlyFirstLaneUsed implementation. This is needed for a follow-up patch.

Diff Detail

Event Timeline

fhahn created this revision.Mar 14 2022, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 9:41 AM
fhahn requested review of this revision.Mar 14 2022, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 9:41 AM
Herald added a subscriber: vkmr. · View Herald Transcript
Ayal accepted this revision.Mar 15 2022, 7:43 AM

Ship it!
Address clearly uses first lane only, as evident in VPInterleaveGroup::execute(), and the other operands Stored values and Mask clearly use all lanes.
This will be exercised/tested by follow-up patch only?

This revision is now accepted and ready to land.Mar 15 2022, 7:43 AM
fhahn added a comment.Mar 17 2022, 4:54 AM

Ship it!
Address clearly uses first lane only, as evident in VPInterleaveGroup::execute(), and the other operands Stored values and Mask clearly use all lanes.

Thanks!

This will be exercised/tested by follow-up patch only?

Yes unfortunately it will only be exercised by a follow up patch. I'll land them close together.

This revision was landed with ongoing or failed builds.Mar 17 2022, 4:57 AM
This revision was automatically updated to reflect the committed changes.