Non-static class members declared under #ifndef NDEBUG should be declared
under #if LLVM_ENABLE_ABI_BREAKING_CHECKS to make headers library-friendly and
allow cross-linking, as discussed in D120714.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Target/SPIRV/Deserialization/Deserializer.h | ||
---|---|---|
601 ↗ | (On Diff #414929) | This is a private header (you're in the lib directory and not in the include directory) Same for the SystemZ one above I believe. |
mlir/lib/Target/SPIRV/Deserialization/Deserializer.h | ||
---|---|---|
601 ↗ | (On Diff #414929) | Makes sense, fixed, thanks! |
Comment Actions
Accidentally placed this revision ID in commit message related to other patch. Reverted that.