Implements the compile-time checking of the formatting arguments.
Completes:
- P2216 std::format improvements
Differential D121530
[libc++][format] Implement format-string. Mordante on Mar 12 2022, 10:55 AM. Authored by
Details
Implements the compile-time checking of the formatting arguments. Completes:
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions Should probably be mentioned in the release notes...?
Comment Actions Good point, thanks!
Comment Actions In general looks good but I would strongly recommend not to instantiate all of formatting path just to validate width/precision (see an inline comment).
Comment Actions Thanks for the review! I've addressed some of the smaller comments, will look at the others tomorrow.
Comment Actions This LGTM. I think most comments by @vitaut have been applied, and while I have a couple of comments, I think this is good to go.
Comment Actions Thanks for the review!
|