Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This is an incomplete not yet ready for review version of the code.

Since the output of these formatters are locale dependant it's expected
to fail on a lot of non-Linux platforms. There the list of CI's used has
been limited. There's no need to test every iteration of this patch on
all CI's.

It's intended to split this review in smaller parts for its real review.

Depends on D125606

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Mordante created this revision.May 28 2022, 3:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 3:45 AM

Herald added subscribers: mstorsjo, arphaman, arichardson, mgorny. · View Herald Transcript

Mordante requested review of this revision.May 28 2022, 3:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 3:45 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B166759: Diff 432709.May 28 2022, 3:46 AM

Rebased to trigger CI

Harbormaster completed remote builds in B166764: Diff 432714.May 28 2022, 6:35 AM

Rebased to fix CI and attempts fixing several other build issues.

Harbormaster completed remote builds in B166770: Diff 432721.May 28 2022, 10:48 AM

Rebased and applies several locale fixes.

Harbormaster completed remote builds in B166809: Diff 432773.May 29 2022, 3:52 AM

Try to fix CI.

Harbormaster completed remote builds in B166814: Diff 432781.May 29 2022, 8:06 AM

More CI fixes.

Harbormaster completed remote builds in B166821: Diff 432791.May 29 2022, 10:44 AM

Another CI test, disable AIX and GCC since they have hard failures and not test failures.

Harbormaster completed remote builds in B166827: Diff 432799.May 29 2022, 11:53 AM

More Windows fixes.

Harbormaster completed remote builds in B166828: Diff 432802.May 29 2022, 12:35 PM

Mordante mentioned this in D128577: [libc++][chrono] Implements formatter day..Jun 25 2022, 11:03 AM

Mordante mentioned this in D133490: [libc++] Fix compilation error on platforms that don't implement std::tm.Sep 8 2022, 8:56 AM

[libc++] DO NOT REVIEW chrono formattingNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 432802

libcxx/include/CMakeLists.txt

libcxx/include/__chrono/formatter.h

libcxx/include/__chrono/ostream.h

libcxx/include/__chrono/parser_std_format_spec.h

libcxx/include/__chrono/statically_widen.h

libcxx/include/__format/parser_std_format_spec.h

libcxx/include/chrono

libcxx/include/module.modulemap

libcxx/test/libcxx/private_headers.verify.cpp

libcxx/test/libcxx/utilities/format/format.formatter/format.formatter.spec/formattable.compile.pass.cpp

libcxx/test/std/time/time.hms/time.hms.nonmembers/ostream.pass.cpp

libcxx/test/std/time/time.cal/time.cal.day/time.cal.day.nonmembers/ostream.pass.cpp

libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.nonmembers/ostream.pass.cpp

libcxx/test/std/time/time.cal/time.cal.year/time.cal.year.nonmembers/ostream.pass.cpp

libcxx/test/std/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/op.sys_days.pass.cpp

libcxx/test/std/time/time.clock/time.clock.file/consistency.pass.cpp

libcxx/test/std/time/time.clock/time.clock.system/ostream.pass.cpp

libcxx/test/std/time/time.duration/time.duration.nonmember/ostream.pass.cpp

libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp

libcxx/test/std/time/time.syn/formatter.day.pass.cpp

libcxx/test/std/time/time.syn/formatter.duration.pass.cpp

libcxx/test/std/time/time.syn/formatter.month.pass.cpp

libcxx/test/std/time/time.syn/formatter.month_day.pass.cpp

libcxx/test/std/time/time.syn/formatter.month_day_last.pass.cpp

libcxx/test/std/time/time.syn/formatter.month_weekday.pass.cpp

libcxx/test/std/time/time.syn/formatter.sys_time.pass.cpp

libcxx/test/std/time/time.syn/formatter.weekday.pass.cpp

libcxx/test/std/time/time.syn/formatter.weekday_index.pass.cpp

libcxx/test/std/time/time.syn/formatter.weekday_last.pass.cpp

libcxx/test/std/time/time.syn/formatter.year.pass.cpp

libcxx/test/std/time/time.syn/formatter.year_month.pass.cpp

libcxx/test/std/time/time.syn/formatter.year_month_day.pass.cpp

libcxx/test/std/time/time.syn/formatter.year_month_day_last.pass.cpp

libcxx/test/std/time/time.syn/formatter.year_month_weekday.pass.cpp

libcxx/test/std/time/time.syn/formatter.year_month_weekday_last.pass.cpp

libcxx/test/std/time/time.syn/formatter_tests.h

libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/types.compile.pass.cpp

libcxx/utils/ci/buildkite-pipeline.yml

[libc++] DO NOT REVIEW chrono formatting
Needs ReviewPublic
Actions

Revision Contents
Changeset List