Page MenuHomePhabricator

vitaut (Victor Zverovich)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2018, 10:28 AM (158 w, 19 h)

Recent Activity

Wed, Jul 28

vitaut added inline comments to D103357: [libc++][format] Add __format_arg_store..
Wed, Jul 28, 1:52 PM · Restricted Project
vitaut added inline comments to D103357: [libc++][format] Add __format_arg_store..
Wed, Jul 28, 11:36 AM · Restricted Project

Sun, Jul 25

vitaut accepted D103433: [libc++][format] Adds integer formatter..

Looks good, thanks for addressing the comments.

Sun, Jul 25, 8:27 AM · Restricted Project

Sun, Jul 18

vitaut accepted D103413: [libc++][format] Implement Unicode support..

LGTM

Sun, Jul 18, 7:21 AM · Restricted Project
vitaut added inline comments to D103670: [libc++][format] Adds bool formatter..
Sun, Jul 18, 6:29 AM · Restricted Project
vitaut added inline comments to D103433: [libc++][format] Adds integer formatter..
Sun, Jul 18, 6:13 AM · Restricted Project

Sat, Jul 17

vitaut added inline comments to D103466: [libc++][format] Adds char formatter..
Sat, Jul 17, 9:09 AM · Restricted Project
vitaut added inline comments to D103466: [libc++][format] Adds char formatter..
Sat, Jul 17, 8:59 AM · Restricted Project
vitaut requested changes to D103433: [libc++][format] Adds integer formatter..
Sat, Jul 17, 8:48 AM · Restricted Project
vitaut accepted D103425: [libc++][format] Adds string formatter..

Some nits inline, otherwise LGTM.

Sat, Jul 17, 7:48 AM · Restricted Project
vitaut added inline comments to D103413: [libc++][format] Implement Unicode support..
Sat, Jul 17, 7:20 AM · Restricted Project
vitaut added inline comments to D103413: [libc++][format] Implement Unicode support..
Sat, Jul 17, 7:17 AM · Restricted Project
vitaut added inline comments to D103368: [libc++][format] Adds parser std-format-spec..
Sat, Jul 17, 7:00 AM · Restricted Project
vitaut accepted D103368: [libc++][format] Adds parser std-format-spec..

Looks great, thanks for addressing the comments!

Sat, Jul 17, 6:31 AM · Restricted Project
vitaut added inline comments to D103357: [libc++][format] Add __format_arg_store..
Sat, Jul 17, 6:28 AM · Restricted Project
vitaut accepted D103357: [libc++][format] Add __format_arg_store..

LGTM

Sat, Jul 17, 6:18 AM · Restricted Project

Tue, Jul 13

vitaut added inline comments to D103368: [libc++][format] Adds parser std-format-spec..
Tue, Jul 13, 8:40 AM · Restricted Project

Sun, Jul 11

vitaut added inline comments to D96664: [libc++][format] Implement formatters..
Sun, Jul 11, 10:41 AM · Restricted Project
vitaut added inline comments to D103413: [libc++][format] Implement Unicode support..
Sun, Jul 11, 9:48 AM · Restricted Project
vitaut added inline comments to D103413: [libc++][format] Implement Unicode support..
Sun, Jul 11, 9:44 AM · Restricted Project
vitaut added inline comments to D103413: [libc++][format] Implement Unicode support..
Sun, Jul 11, 9:17 AM · Restricted Project
vitaut accepted D103379: [libc++][format] Add a CMake Unicode option..

LGTM

Sun, Jul 11, 9:13 AM · Restricted Project
vitaut requested changes to D103368: [libc++][format] Adds parser std-format-spec..
Sun, Jul 11, 9:01 AM · Restricted Project
vitaut requested changes to D103357: [libc++][format] Add __format_arg_store..
Sun, Jul 11, 7:25 AM · Restricted Project

Sat, Jul 10

vitaut added inline comments to D96664: [libc++][format] Implement formatters..
Sat, Jul 10, 9:38 AM · Restricted Project
vitaut accepted D96664: [libc++][format] Implement formatters..

Looks great, just a few nits inline. Accepting the diff mostly as a reminder for myself that I've already looked at it.

Sat, Jul 10, 9:28 AM · Restricted Project

Jun 23 2021

vitaut added inline comments to D96664: [libc++][format] Implement formatters..
Jun 23 2021, 4:17 PM · Restricted Project
vitaut added inline comments to D96664: [libc++][format] Implement formatters..
Jun 23 2021, 11:05 AM · Restricted Project

Jun 20 2021

vitaut requested changes to D103425: [libc++][format] Adds string formatter..
Jun 20 2021, 7:41 AM · Restricted Project
vitaut accepted D103357: [libc++][format] Add __format_arg_store..

LGTM but this will need to be reviewed by someone familiar with libc++ of course =).

Jun 20 2021, 6:44 AM · Restricted Project

Jun 18 2021

vitaut requested changes to D103413: [libc++][format] Implement Unicode support..
Jun 18 2021, 7:56 AM · Restricted Project
vitaut added a comment to D103379: [libc++][format] Add a CMake Unicode option..

LGTM

Jun 18 2021, 7:23 AM · Restricted Project
vitaut added inline comments to D103368: [libc++][format] Adds parser std-format-spec..
Jun 18 2021, 7:21 AM · Restricted Project

Jun 17 2021

vitaut requested changes to D103368: [libc++][format] Adds parser std-format-spec..
Jun 17 2021, 9:02 AM · Restricted Project

Jun 15 2021

vitaut requested changes to D103357: [libc++][format] Add __format_arg_store..

"the function make_format_args," appears twice in the summary. I guess the second one was supposed to be "make_wformat_args".

Jun 15 2021, 7:30 AM · Restricted Project

Jun 13 2021

vitaut added inline comments to D96664: [libc++][format] Implement formatters..
Jun 13 2021, 8:45 AM · Restricted Project
vitaut requested changes to D96664: [libc++][format] Implement formatters..

Overall looks good, some comments inline.

Jun 13 2021, 8:22 AM · Restricted Project

Aug 19 2018

vitaut added inline comments to D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing.
Aug 19 2018, 7:33 AM

Jul 30 2018

vitaut added a comment to D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler.

Do you need someone to commit this for you?

Jul 30 2018, 12:43 PM
vitaut updated the summary of D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler.
Jul 30 2018, 12:24 PM
vitaut updated the summary of D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler.
Jul 30 2018, 12:24 PM
vitaut created D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler.
Jul 30 2018, 12:24 PM

Jul 25 2018

vitaut added a comment to D49813: [libc++] Make <experimental/filesystem> compile with gcc 4.8.5.

@EricWF could you or someone else commit this as I don't have commit access? Thanks.

Jul 25 2018, 1:54 PM
vitaut created D49813: [libc++] Make <experimental/filesystem> compile with gcc 4.8.5.
Jul 25 2018, 11:44 AM