- User Since
- Jul 25 2018, 10:28 AM (158 w, 19 h)
Wed, Jul 28
Sun, Jul 25
Looks good, thanks for addressing the comments.
Sun, Jul 18
Sat, Jul 17
Some nits inline, otherwise LGTM.
Looks great, thanks for addressing the comments!
Tue, Jul 13
Sun, Jul 11
Sat, Jul 10
Looks great, just a few nits inline. Accepting the diff mostly as a reminder for myself that I've already looked at it.
Jun 23 2021
Jun 20 2021
LGTM but this will need to be reviewed by someone familiar with libc++ of course =).
Jun 18 2021
Jun 17 2021
Jun 15 2021
"the function make_format_args," appears twice in the summary. I guess the second one was supposed to be "make_wformat_args".
Jun 13 2021
Overall looks good, some comments inline.
Aug 19 2018
Jul 30 2018
Do you need someone to commit this for you?
Jul 25 2018
@EricWF could you or someone else commit this as I don't have commit access? Thanks.