This is an archive of the discontinued LLVM Phabricator instance.

[libc++][format] Improves the handle test.
ClosedPublic

Authored by Mordante on Jun 14 2022, 10:29 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rG5517bc6c4a05: [libc++][format] Improves the handle test.
Summary

A formatter using a handle only needs to satisfy the BasicFormatter
requirements. The current test allowed more than that minimum. Changed
it to the minimum to make sure it works.

This was due to a post-commit review comment of @vitaut in D121530.

Diff Detail

Event Timeline

Mordante created this revision.Jun 14 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2022, 10:29 AM
Mordante requested review of this revision.Jun 14 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2022, 10:29 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
vitaut accepted this revision.Jun 19 2022, 8:03 AM

LGTM

ldionne accepted this revision.Jun 20 2022, 12:07 PM
This revision is now accepted and ready to land.Jun 20 2022, 12:07 PM
This revision was automatically updated to reflect the committed changes.