This is an archive of the discontinued LLVM Phabricator instance.

Differential D120967

[NFC] Divide tests into smaller files
ClosedPublic

Authored by 4vtomat on Mar 3 2022, 8:14 PM.

Details

Reviewers
fhahn
craig.topper
khchen
kito-cheng
Commits
rG5a148869d336: [NFC] Divide tests into smaller files
Summary

Solved issue 54168
This commit divides the large test files(over 30k lines) under clang/test/CodeGen/RISCV including:

  • rvv-intrinsics/vloxseg.c
  • rvv-intrinsics/vluxseg.c
  • rvv-intrinsics-overloaded/vloxseg.c
  • rvv-intrinsics-overloaded/vluxseg.c

into "non-masked" version and "masked" version which can reduce the test cases by 50% in a single file.

Diff Detail

Event Timeline

4vtomat created this revision.Mar 3 2022, 8:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 8:14 PM
Herald added subscribers: luke957, frasercrmck, luismarques and 19 others. · View Herald Transcript
4vtomat requested review of this revision.Mar 3 2022, 8:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 8:14 PM
Herald added subscribers: cfe-commits, • pcwang-thead, MaskRay. · View Herald Transcript
4vtomat added reviewers: fhahn, craig.topper, khchen.Mar 3 2022, 8:54 PM
4vtomat edited the summary of this revision. (Show Details)Mar 3 2022, 8:58 PM
Harbormaster completed remote builds in B152525: Diff 412918.Mar 3 2022, 9:08 PM
kito-cheng accepted this revision.EditedMar 3 2022, 10:51 PM
kito-cheng added a subscriber: kito-cheng.

LGTM, but do you mind give more comment on SUMMARY to describe what you did?

This revision is now accepted and ready to land.Mar 3 2022, 10:51 PM
4vtomat edited the summary of this revision. (Show Details)Mar 3 2022, 11:00 PM
In D120967#3359188, @kito-cheng wrote:

LGTM, but do you mind give more comment on SUMMARY to describe what you did?

You are right lol. I've added some~

fhahn accepted this revision.Mar 4 2022, 3:15 AM

Thanks for splitting up the tests! Looks like pre-commit CI is happy again!

Closed by commit rG5a148869d336: [NFC] Divide tests into smaller files (authored by 4vtomat). · Explain WhyMar 4 2022, 4:18 AM
This revision was automatically updated to reflect the committed changes.
4vtomat added a commit: rG5a148869d336: [NFC] Divide tests into smaller files.
jrtc27 added a comment.Mar 4 2022, 9:16 AM

With one exception, every RISC-V Clang CodeGen test (and with 9 exceptions, every RISC-V LLVM CodeGen test) is kebab-case not snake_case

Revision Contents

PathSize
clang/
test/
CodeGen/
RISCV/
rvv-intrinsics-overloaded/
14389 lines
14389 lines
14389 lines
14389 lines
rvv-intrinsics/
18018 lines
14388 lines
18018 lines
14388 lines

Diff 412981

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c

  • This file was copied to clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg_mask.c.
This file has a very large number of changes (14,389 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg_mask.c

  • This file was copied from clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c.
This file has a very large number of changes (14,389 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c

  • This file was copied to clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg_mask.c.
This file has a very large number of changes (14,389 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg_mask.c

  • This file was copied from clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c.
This file has a very large number of changes (14,389 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c

  • This file was copied to clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg_mask.c.
This file has a very large number of changes (18,018 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg_mask.c

  • This file was copied from clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c.
This file has a very large number of changes (14,388 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c

  • This file was copied to clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg_mask.c.
This file has a very large number of changes (18,018 lines). Show File Contents

clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg_mask.c

  • This file was copied from clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c.
This file has a very large number of changes (14,388 lines). Show File Contents