[MLIR][OpenMP][NFC] Move the modifier testcases to correct directory

[shraiysh]

Summary

This patch moves the testcases from
mlir/test/Target/LLVMIR/openmp-llvm-bad-schedule-modifier.mlir to
mlir/test/Dialect/OpenMP/invalid.mlir as they test the verifier
(not the translation to LLVM IR).

[shraiysh]

Ping!

[NimishMishra]

Hello @shraiysh. I noticed the build has failed for this. Can we have a rebase with main and a rebuild, just in case? Or if that failure was because of anything else, then we can let it be maybe.

[shraiysh]

In D120877#3372286, @NimishMishra wrote:

Hello @shraiysh. I noticed the build has failed for this. Can we have a rebase with main and a rebuild, just in case? Or if that failure was because of anything else, then we can let it be maybe.

It is an unrelated failure.

[shraiysh]

Rebase with main.

[NimishMishra]

In D120877#3372306, @shraiysh wrote:

In D120877#3372286, @NimishMishra wrote:

Hello @shraiysh. I noticed the build has failed for this. Can we have a rebase with main and a rebuild, just in case? Or if that failure was because of anything else, then we can let it be maybe.

It is an unrelated failure.

LGTM in that case

mlir/test/Dialect/OpenMP/invalid.mlir

func @proc_bind_not_allowed(%lb : index, %ub : index, %step : index) {
   // expected-error @below {{proc_bind is not a valid clause}}
   omp.wsloop (%iv) : index = (%lb) to (%ub) step (%step) proc_bind(close) {
     omp.yield
   }
 }
 
 // -----
 
+llvm.func @test_omp_wsloop_dynamic_bad_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
+  // expected-error @+1 {{unknown modifier type: ginandtonic}}
+  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, ginandtonic) {
+    omp.yield
+  }
+  llvm.return
+}
+
+// -----
+
+llvm.func @test_omp_wsloop_dynamic_many_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
+  // expected-error @+1 {{unexpected modifier(s)}}
+  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, monotonic, monotonic, monotonic) {
+    omp.yield
+  }
+  llvm.return
+}
+
+// -----
+
+llvm.func @test_omp_wsloop_dynamic_wrong_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
+  // expected-error @+1 {{incorrect modifier order}}
+  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, simd, monotonic) {
+    omp.yield
+  }
+  llvm.return
+}
+
+// -----
+
+llvm.func @test_omp_wsloop_dynamic_wrong_modifier2(%lb : i64, %ub : i64, %step : i64) -> () {
+  // expected-error @+1 {{incorrect modifier order}}
+  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, monotonic, monotonic) {
+    omp.yield
+  }
+  llvm.return
+}
+
+// -----
+
+llvm.func @test_omp_wsloop_dynamic_wrong_modifier3(%lb : i64, %ub : i64, %step : i64) -> () {
+  // expected-error @+1 {{incorrect modifier order}}
+  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, simd, simd) {
+    omp.yield
+  }
+  llvm.return
+}
+
+// -----
+
 // expected-error @below {{op expects initializer region with one argument of the reduction type}}
 omp.reduction.declare @add_f32 : f64
 init {
 ^bb0(%arg: f32):
   %0 = arith.constant 0.0 : f32
   omp.yield (%0 : f32)
 }
 combiner {

mlir/test/Target/LLVMIR/openmp-llvm-bad-schedule-modifier.mlir

-// RUN: not mlir-translate -mlir-to-llvmir -split-input-file %s 2>&1 | FileCheck %s
-
-llvm.func @test_omp_wsloop_dynamic_bad_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
-  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, ginandtonic) {
-    // CHECK: unknown modifier type: ginandtonic
-    omp.yield
-  }
-  llvm.return
-}
-
-// -----
-
-llvm.func @test_omp_wsloop_dynamic_many_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
-  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, monotonic, monotonic, monotonic) {
-    // CHECK: unexpected modifier(s)
-    omp.yield
-  }
-  llvm.return
-}
-
-// -----
-
-llvm.func @test_omp_wsloop_dynamic_wrong_modifier(%lb : i64, %ub : i64, %step : i64) -> () {
-  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, simd, monotonic) {
-    // CHECK: incorrect modifier order
-    omp.yield
-  }
-  llvm.return
-}
-
-// -----
-
-llvm.func @test_omp_wsloop_dynamic_wrong_modifier2(%lb : i64, %ub : i64, %step : i64) -> () {
-  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, monotonic, monotonic) {
-    // CHECK: incorrect modifier order
-    omp.yield
-  }
-  llvm.return
-}
-
-// -----
-
-llvm.func @test_omp_wsloop_dynamic_wrong_modifier3(%lb : i64, %ub : i64, %step : i64) -> () {
-  omp.wsloop (%iv) : i64 = (%lb) to (%ub) step (%step) schedule(dynamic, simd, simd) {
-    // CHECK: incorrect modifier order
-    omp.yield
-  }
-  llvm.return
-}