This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Update some tests to use floating point ABI where it makes sense.
ClosedPublic

Authored by craig.topper on Feb 23 2022, 6:36 PM.

Details

Summary

Trying to reduce the diffs from D118333 for cases where it makes
more sense to use an FP ABI.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 23 2022, 6:36 PM
craig.topper requested review of this revision.Feb 23 2022, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2022, 6:36 PM
kito-cheng accepted this revision.Feb 23 2022, 10:22 PM

LGTM, this change dig out few potential ABI implementation bug for half!

llvm/test/CodeGen/RISCV/fpclamptosat.ll
446

This seems wrong for ilp32d/ilp32f (and also for lp64d/lp64f) since we should pass half in fa0? but I think it's out of scope of this patch.

This revision is now accepted and ready to land.Feb 23 2022, 10:22 PM

LGTM, @craig.topper Thanks for your help on land D118333!

asb accepted this revision.Feb 24 2022, 3:35 AM

LGTM, thanks.

This revision was landed with ongoing or failed builds.Feb 24 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/RISCV/fpclamptosat.ll