This is an archive of the discontinued LLVM Phabricator instance.

Differential D119137

Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives
ClosedPublic

Authored by pietroalbini on Feb 7 2022, 6:55 AM.

Details

Reviewers
ab
apilipenko
dim
emaste
george.burgess.iv
kristof.beyls
mattdr
nikhgupt
ojhunt
probinson
peter.smith
serge-sans-paille
Shayne
tpenge
andrew.w.kaylor
smaslov
shayne.hietblock
Commits
rGfdd019530680: [Security Group] Update representative for Rust.
Summary

Steve Klabnik recently left the Rust project, so I'm nominating Josh Stone (the other member of the Rust Security Response WG) to replace him as one of the vendor contacts for Rust, along with me.

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > MLIR.Examples/standalone::test.toy
60,020 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,160 msx64 debian > libFuzzer.libFuzzer::large.test
60,040 msx64 debian > libFuzzer.libFuzzer::out-of-process-fuzz.test
60,070 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

pietroalbini created this revision.Feb 7 2022, 6:55 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 7 2022, 6:55 AM
pietroalbini requested review of this revision.Feb 7 2022, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 6:55 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
pietroalbini added a comment.Feb 7 2022, 6:55 AM

By the way, the Phabricator usernames of the two Intel representatives seem to be incorrect, anyone knows the right usernames?

dim added subscribers: smaslov, andrew.w.kaylor.Feb 7 2022, 7:16 AM

As far as I know:
Andy Kaylor = @andrew.w.kaylor
Sergey Maslov = @smaslov

Harbormaster completed remote builds in B147972: Diff 406441.Feb 7 2022, 8:15 AM
dim added a comment.Feb 7 2022, 10:20 AM

Note: andykaylor is Andy's GitHub username: https://github.com/andykaylor
and similarly, smaslov-intel is Sergey's: https://github.com/smaslov-intel

pietroalbini added reviewers: andrew.w.kaylor, smaslov.Feb 7 2022, 10:22 AM

Added the two Intel representatives as reviewers!

dim added a comment.Feb 7 2022, 10:22 AM

Having said that, if this document is supposed to be published on GitHub, and read by people primarily via GitHub, I suppose it would make sense to change all the mentioned usernames to GitHub usernames instead of Phabricator usernames?

dim accepted this revision.Feb 7 2022, 10:23 AM

In any case, LGTM for this review itself of course.

This revision is now accepted and ready to land.Feb 7 2022, 10:23 AM
pietroalbini added a comment.Feb 7 2022, 10:24 AM

Having said that, if this document is supposed to be published on GitHub, and read by people primarily via GitHub, I suppose it would make sense to change all the mentioned usernames to GitHub usernames instead of Phabricator usernames?

I guess it depends on the goal of those usernames. I personally use them to get the list of names I should ask for review for changes, which currently happen on Phabricator.

kristof.beyls accepted this revision.Feb 8 2022, 12:02 AM
peter.smith accepted this revision.Feb 8 2022, 1:11 AM
mattdr accepted this revision.Mar 17 2022, 9:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2022, 9:37 PM
probinson accepted this revision.Mar 18 2022, 8:02 AM
shayne.hietblock accepted this revision.Apr 19 2022, 11:28 AM
tpenge accepted this revision.Apr 19 2022, 11:45 AM
apilipenko accepted this revision.Apr 19 2022, 12:21 PM
george.burgess.iv accepted this revision.Apr 19 2022, 5:03 PM

LGTM, thanks!

ab accepted this revision.Apr 20 2022, 10:50 AM
This revision was landed with ongoing or failed builds.May 18 2022, 5:21 AM
Closed by commit rGfdd019530680: [Security Group] Update representative for Rust. (authored by pietroalbini, committed by kristof.beyls). · Explain Why
This revision was automatically updated to reflect the committed changes.
kristof.beyls added a commit: rGfdd019530680: [Security Group] Update representative for Rust..

Revision Contents

PathSize
llvm/
docs/
2 lines

Diff 406441

llvm/docs/Security.rst

Show All 33 Lines
The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below. The list is in the format `* ${full_name} (${affiliation}) [${phabricator_username}]`. If a phabricator username for an individual isn't available, the brackets will be empty. The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below. The list is in the format `* ${full_name} (${affiliation}) [${phabricator_username}]`. If a phabricator username for an individual isn't available, the brackets will be empty.
* Ahmed Bougacha (Apple) [ab] * Ahmed Bougacha (Apple) [ab]
* Andy Kaylor (Intel) [andykaylor] * Andy Kaylor (Intel) [andykaylor]
* Artur Pilipenko (Azul Systems Inc) [apilipenko] * Artur Pilipenko (Azul Systems Inc) [apilipenko]
* Dimitry Andric (individual; FreeBSD) [dim] * Dimitry Andric (individual; FreeBSD) [dim]
* Ed Maste (individual; FreeBSD) [emaste] * Ed Maste (individual; FreeBSD) [emaste]
* George Burgess IV (Google) [george.burgess.iv] * George Burgess IV (Google) [george.burgess.iv]
* Josh Stone (RedHat; Rust) [cuviper]
* Kate McInnes (Apple) [] * Kate McInnes (Apple) []
* Kristof Beyls (ARM) [kristof.beyls] * Kristof Beyls (ARM) [kristof.beyls]
* Matthew Riley (Google) [mattdr] * Matthew Riley (Google) [mattdr]
* Nikhil Gupta (Nvidia) [nikhgupt] * Nikhil Gupta (Nvidia) [nikhgupt]
* Oliver Hunt (Apple) [ojhunt] * Oliver Hunt (Apple) [ojhunt]
* Paul Robinson (Sony) [probinson] * Paul Robinson (Sony) [probinson]
* Peter Smith (ARM) [peter.smith] * Peter Smith (ARM) [peter.smith]
* Pietro Albini (Ferrous Systems; Rust) [pietroalbini] * Pietro Albini (Ferrous Systems; Rust) [pietroalbini]
* Serge Guelton (RedHat) [serge-sans-paille] * Serge Guelton (RedHat) [serge-sans-paille]
* Sergey Maslov (Intel) [smaslov-intel] * Sergey Maslov (Intel) [smaslov-intel]
* Shayne Hiet-Block (Microsoft) [Shayne] * Shayne Hiet-Block (Microsoft) [Shayne]
* Steve Klabnik (Oxide Computer Company; Rust) [steveklabnik]
* Tim Penge (Sony) [tpenge] * Tim Penge (Sony) [tpenge]
Criteria Criteria
-------- --------
* Nominees for LLVM Security Group membership should fall in one of these groups: * Nominees for LLVM Security Group membership should fall in one of these groups:
- Individual contributors: - Individual contributors:
▲ Show 20 Lines • Show All 174 Lines • Show Last 20 Lines