This is an archive of the discontinued LLVM Phabricator instance.

Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives
ClosedPublic

Authored by pietroalbini on Feb 7 2022, 6:55 AM.

Diff Detail

Event Timeline

pietroalbini created this revision.Feb 7 2022, 6:55 AM
pietroalbini requested review of this revision.Feb 7 2022, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 6:55 AM

By the way, the Phabricator usernames of the two Intel representatives seem to be incorrect, anyone knows the right usernames?

As far as I know:
Andy Kaylor = @andrew.w.kaylor
Sergey Maslov = @smaslov

dim added a comment.Feb 7 2022, 10:20 AM

Note: andykaylor is Andy's GitHub username: https://github.com/andykaylor
and similarly, smaslov-intel is Sergey's: https://github.com/smaslov-intel

Added the two Intel representatives as reviewers!

dim added a comment.Feb 7 2022, 10:22 AM

Having said that, if this document is supposed to be published on GitHub, and read by people primarily via GitHub, I suppose it would make sense to change all the mentioned usernames to GitHub usernames instead of Phabricator usernames?

dim accepted this revision.Feb 7 2022, 10:23 AM

In any case, LGTM for this review itself of course.

This revision is now accepted and ready to land.Feb 7 2022, 10:23 AM

Having said that, if this document is supposed to be published on GitHub, and read by people primarily via GitHub, I suppose it would make sense to change all the mentioned usernames to GitHub usernames instead of Phabricator usernames?

I guess it depends on the goal of those usernames. I personally use them to get the list of names I should ask for review for changes, which currently happen on Phabricator.

kristof.beyls accepted this revision.Feb 8 2022, 12:02 AM
peter.smith accepted this revision.Feb 8 2022, 1:11 AM
mattdr accepted this revision.Mar 17 2022, 9:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2022, 9:37 PM
probinson accepted this revision.Mar 18 2022, 8:02 AM
tpenge accepted this revision.Apr 19 2022, 11:45 AM
apilipenko accepted this revision.Apr 19 2022, 12:21 PM

LGTM, thanks!

ab accepted this revision.Apr 20 2022, 10:50 AM
This revision was landed with ongoing or failed builds.May 18 2022, 5:21 AM
This revision was automatically updated to reflect the committed changes.