Page MenuHomePhabricator

george.burgess.iv (George Burgess IV)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2014, 12:28 PM (410 w, 2 d)

Recent Activity

Apr 19 2022

george.burgess.iv accepted D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.

LGTM, thanks!

Apr 19 2022, 5:03 PM · Restricted Project, Restricted Project

Mar 30 2022

george.burgess.iv accepted D122772: [Utils] Add URL formatting for revert_checker.

Do you have commit access, or should I land this for you?

Mar 30 2022, 5:21 PM · Restricted Project, Restricted Project

Dec 15 2021

george.burgess.iv accepted D115657: [Nomination] Adding Intel representatives to security group.

LGTM :)

Dec 15 2021, 10:13 AM · Restricted Project

Nov 12 2021

george.burgess.iv added inline comments to D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins..
Nov 12 2021, 3:57 PM · Restricted Project
george.burgess.iv accepted D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins..

LGTM % 2 nits. Please feel free to commit after it LGT @aaron.ballman too. :)

Nov 12 2021, 10:17 AM · Restricted Project

Oct 20 2021

george.burgess.iv accepted D111833: [clang] Fortify warning for scanf calls with field width too big..

LGTM. Thanks again!

Oct 20 2021, 2:15 PM · Restricted Project

Oct 19 2021

george.burgess.iv added a comment to D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins..

Thanks for this! The idea LGTM, and sounds like a solid way for us to do better about diagnosing FORTIFY'ed calls in Clang. I have a handful of mostly nits/questions for you :)

Oct 19 2021, 6:49 PM · Restricted Project
george.burgess.iv accepted D111833: [clang] Fortify warning for scanf calls with field width too big..

LGTM % nits -- thanks for this! :)

Oct 19 2021, 6:25 PM · Restricted Project

Aug 3 2021

george.burgess.iv added a comment to D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.

...This entirely dropped off my radar. Will try to land it now; thanks, all!

Aug 3 2021, 12:07 PM · Restricted Project, Restricted Project
george.burgess.iv accepted D106906: [Nomination] Adding an Nvidia representative to security group.
Aug 3 2021, 11:50 AM · Restricted Project

Jul 29 2021

george.burgess.iv accepted D106964: [Security] Replace a Sony member.

Welcome! :)

Jul 29 2021, 3:50 PM · Restricted Project

Jul 28 2021

george.burgess.iv added a comment to D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.

Thanks for the reviews and commentary!

Jul 28 2021, 2:19 PM · Restricted Project

Jul 27 2021

george.burgess.iv updated the diff for D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.

Added steveklabnik to the doc as requested -- thanks!

Jul 27 2021, 3:29 PM · Restricted Project
george.burgess.iv requested review of D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.
Jul 27 2021, 2:25 PM · Restricted Project

Jul 26 2021

george.burgess.iv added a comment to D106503: MCSubtargetInfo: Add debugging 'features' that dump current CPU bit state.

I'm curious, as X86 is probably one of the more complicated targets, does rust make use of llvm::X86::updateImpliedFeatures and llvm::X86::getFeaturesForCPU from llvm/lib/Support/X86TargetParser.cpp? That's a large chunk of the code clang uses for feature interactions.

Jul 26 2021, 5:13 PM · Restricted Project
george.burgess.iv updated the summary of D106838: revert_checker: guarantee a commit ordering.
Jul 26 2021, 5:05 PM · Restricted Project
george.burgess.iv requested review of D106838: revert_checker: guarantee a commit ordering.
Jul 26 2021, 5:05 PM · Restricted Project

Jul 22 2021

george.burgess.iv added a comment to D106503: MCSubtargetInfo: Add debugging 'features' that dump current CPU bit state.

Why not add a separate flag instead of polluting the feature string?

Jul 22 2021, 11:08 AM · Restricted Project

Jul 21 2021

george.burgess.iv requested review of D106503: MCSubtargetInfo: Add debugging 'features' that dump current CPU bit state.
Jul 21 2021, 3:27 PM · Restricted Project

Jul 20 2021

george.burgess.iv accepted D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source..

please give a day for other reviewers to add any last minute comments, then i think we can land this.

Jul 20 2021, 9:51 AM · Restricted Project

Jul 15 2021

george.burgess.iv added inline comments to D105578: utils: add a revert checker.
Jul 15 2021, 1:09 PM · Restricted Project
george.burgess.iv committed rG3a7ca4cad4dd: utils: fix broken assertion in revert_checker (authored by george.burgess.iv).
utils: fix broken assertion in revert_checker
Jul 15 2021, 1:08 PM
george.burgess.iv added a comment to D106030: [Clang] add support for error+warning fn attrs.

Adding something to the IR for the sole purpose of producing a diagnostic feels really weird. I'm not sure I see why the frontend can't see this attribute and directly warn

Jul 15 2021, 12:12 PM · Restricted Project, Restricted Project

Jul 14 2021

george.burgess.iv added a comment to D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source..

thanks for this! mostly just nits from me

Jul 14 2021, 3:15 PM · Restricted Project

Jul 7 2021

george.burgess.iv committed rG81ee4952f122: utils: add a revert checker (authored by george.burgess.iv).
utils: add a revert checker
Jul 7 2021, 2:20 PM
george.burgess.iv closed D105578: utils: add a revert checker.
Jul 7 2021, 2:20 PM · Restricted Project
george.burgess.iv added a comment to D105578: utils: add a revert checker.

Thanks for the quick review! :)

Jul 7 2021, 2:18 PM · Restricted Project
george.burgess.iv updated the summary of D105578: utils: add a revert checker.
Jul 7 2021, 11:44 AM · Restricted Project
george.burgess.iv requested review of D105578: utils: add a revert checker.
Jul 7 2021, 11:44 AM · Restricted Project

Jun 14 2021

george.burgess.iv committed rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile. (authored by mbenfield).
[Clang] Test case for -Wunused-but-set-variable, warn for volatile.
Jun 14 2021, 10:28 AM
george.burgess.iv closed D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile..
Jun 14 2021, 10:28 AM · Restricted Project

Jun 1 2021

george.burgess.iv committed rGcf49cae278b4: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable (authored by mbenfield).
[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable
Jun 1 2021, 3:41 PM
george.burgess.iv committed rG00d19c6704f4: [various] Remove or use variables which are unused but set. (authored by mbenfield).
[various] Remove or use variables which are unused but set.
Jun 1 2021, 3:41 PM
george.burgess.iv closed D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.
Jun 1 2021, 3:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
george.burgess.iv closed D102942: Remove or use variables which are unused but set..
Jun 1 2021, 3:40 PM · Restricted Project, Restricted Project

May 13 2021

george.burgess.iv accepted D102367: [LowerConstantIntrinsics] reuse isManifestLogic from ConstantFolding.

one drive-by nit and lgtm -- thanks!

May 13 2021, 11:41 AM · Restricted Project

Apr 21 2021

george.burgess.iv added a comment to D100873: [docs] Describe reporting security issues on the chromium tracker..

Thanks for this!

Apr 21 2021, 6:40 AM · Restricted Project
george.burgess.iv accepted D100864: Replace Apple representative to security group..
Apr 21 2021, 6:31 AM · Restricted Project

Apr 19 2021

george.burgess.iv added a reviewer for D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable: rtrieu.

Just a few more nits and LGTM. We probably want the thoughts of someone with ownership in warnings to be sure. +rtrieu might be good?

Apr 19 2021, 12:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
george.burgess.iv added a comment to D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.

friendly ping :)

Apr 19 2021, 11:59 AM · Restricted Project, Restricted Project

Apr 15 2021

george.burgess.iv added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Thanks for this! I think this warning looks valuable.

Apr 15 2021, 1:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 9 2021

george.burgess.iv accepted D100163: [MSSA] Rename uses in IDF regardless of new def position in basic block..

Thanks for this!

Apr 9 2021, 11:48 AM · Restricted Project

Apr 6 2021

george.burgess.iv added a comment to D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.

Thanks for the comment!

Apr 6 2021, 3:37 PM · Restricted Project, Restricted Project
george.burgess.iv requested review of D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.
Apr 6 2021, 2:29 PM · Restricted Project, Restricted Project

Mar 26 2021

george.burgess.iv committed rG5079bc8a2303: docs: Adding Google representative to the security group (authored by george.burgess.iv).
docs: Adding Google representative to the security group
Mar 26 2021, 6:56 PM
george.burgess.iv closed D99232: [Nomination] Adding new Google representative to security group.
Mar 26 2021, 6:56 PM · Restricted Project

Mar 25 2021

george.burgess.iv added a comment to D99232: [Nomination] Adding new Google representative to security group.

Thank you all for your support!

Mar 25 2021, 12:42 PM · Restricted Project

Mar 23 2021

george.burgess.iv requested review of D99232: [Nomination] Adding new Google representative to security group.
Mar 23 2021, 6:07 PM · Restricted Project

Jan 20 2021

george.burgess.iv added a comment to D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.

reverted in https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea until we can figure out how to address the issues outlined above. thanks!

Jan 20 2021, 11:06 AM · Restricted Project
george.burgess.iv added a reverting change for rG275f30df8ad6: [clang] Change builtin object size when subobject is invalid: rGb270fd59f0a8: Revert "[clang] Change builtin object size when subobject is invalid".
Jan 20 2021, 11:05 AM
george.burgess.iv committed rGb270fd59f0a8: Revert "[clang] Change builtin object size when subobject is invalid" (authored by george.burgess.iv).
Revert "[clang] Change builtin object size when subobject is invalid"
Jan 20 2021, 11:05 AM
george.burgess.iv added a reverting change for D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid: rGb270fd59f0a8: Revert "[clang] Change builtin object size when subobject is invalid".
Jan 20 2021, 11:05 AM · Restricted Project

Jan 7 2021

george.burgess.iv committed rG275f30df8ad6: [clang] Change builtin object size when subobject is invalid (authored by jtmott-intel).
[clang] Change builtin object size when subobject is invalid
Jan 7 2021, 12:38 PM
george.burgess.iv closed D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.
Jan 7 2021, 12:38 PM · Restricted Project

Jan 6 2021

george.burgess.iv accepted D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.

thanks for working on this!

Jan 6 2021, 9:23 AM · Restricted Project

Dec 7 2020

george.burgess.iv accepted D92768: docs: Add pointer to cmake caches for PGO.

thanks!

Dec 7 2020, 9:11 AM · Restricted Project

Nov 30 2020

george.burgess.iv accepted D92328: collect_and_build_with_pgo.py: adapt to monorepo.

thanks for this!

Nov 30 2020, 9:44 AM · Restricted Project

Nov 12 2020

george.burgess.iv accepted D91372: Some updates/fixes to the creduce script..

thanks!

Nov 12 2020, 12:55 PM · Restricted Project

Nov 2 2020

george.burgess.iv committed rGba18bc4925d8: [Sema] adds -Wfree-nonheap-object member var checks (authored by cjdb).
[Sema] adds -Wfree-nonheap-object member var checks
Nov 2 2020, 11:07 AM
george.burgess.iv closed D90269: adds -Wfree-nonheap-object member var checks.
Nov 2 2020, 11:07 AM · Restricted Project

Oct 28 2020

george.burgess.iv committed rG425a83a5f069: [Sema] adds basic -Wfree-nonheap-object functionality (authored by cjdb).
[Sema] adds basic -Wfree-nonheap-object functionality
Oct 28 2020, 4:24 PM
george.burgess.iv closed D89988: adds basic -Wfree-nonheap-object functionality.
Oct 28 2020, 4:24 PM · Restricted Project
george.burgess.iv added a comment to D89988: adds basic -Wfree-nonheap-object functionality.

looks like all comments here are addressed, so i'll land this.

Oct 28 2020, 3:02 PM · Restricted Project

Oct 26 2020

george.burgess.iv added a comment to D89988: adds basic -Wfree-nonheap-object functionality.

If we want _full_ analysis, clang-analyzer-unix.Malloc is what originally flagged the free(function_pointer) case that I referenced above; its complaint was:

Oct 26 2020, 11:37 AM · Restricted Project
george.burgess.iv accepted D89988: adds basic -Wfree-nonheap-object functionality.

LGTM, though please wait for a review from someone with more expertise with clang's warnings (maybe Aaron or Richard?) to land.

Oct 26 2020, 10:43 AM · Restricted Project
george.burgess.iv added inline comments to D89988: adds basic -Wfree-nonheap-object functionality.
Oct 26 2020, 10:26 AM · Restricted Project

Oct 22 2020

george.burgess.iv added reviewers for D89988: adds basic -Wfree-nonheap-object functionality: rtrieu, aaron.ballman.

thanks for this! i like the idea of this warning; seems like a cheap way to catch ugly bugs early. +rtrieu and aaron.ballman, as this is a new diagnostic

Oct 22 2020, 3:36 PM · Restricted Project

Oct 1 2020

george.burgess.iv committed rG9d40fb808fd0: Allow to specify macro names for android-comparison-in-temp-failure-retry (authored by fmayer).
Allow to specify macro names for android-comparison-in-temp-failure-retry
Oct 1 2020, 10:12 AM
george.burgess.iv closed D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..
Oct 1 2020, 10:12 AM · Restricted Project

Sep 25 2020

george.burgess.iv accepted D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..
Sep 25 2020, 4:49 AM · Restricted Project

Sep 16 2020

george.burgess.iv added a comment to D87661: [MemorySSA] Rename uses in blocks with Phis..

(still lgtm. :) )

Sep 16 2020, 3:51 PM · Restricted Project

Sep 15 2020

george.burgess.iv accepted D87661: [MemorySSA] Rename uses in blocks with Phis..

but when prinitng we were still seeing an unoptimized access
as MustAlias due to the flag not being reset

Sep 15 2020, 5:27 PM · Restricted Project

Aug 3 2020

george.burgess.iv accepted D84905: [MemorySSA] Restrict optimizations after a PhiTranslation..

lgtm with a few tiny nits. thanks for working on this!

Aug 3 2020, 1:07 PM · Restricted Project

Jul 6 2020

george.burgess.iv added a reviewer for D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.: alexfh.

Concept and implementation LGTM. Please wait for comment from +alexfh before landing, since I think they have more ownership over clang-tidy in general than I do :)

Jul 6 2020, 12:57 PM · Restricted Project

Jun 9 2020

george.burgess.iv accepted D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Eesh -- sorry for taking forever. :)

Jun 9 2020, 8:57 PM · Restricted Project

May 26 2020

george.burgess.iv added a comment to D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.

thanks for this!

May 26 2020, 9:46 AM · Restricted Project

May 20 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Sorry for the latency :)

May 20 2020, 10:22 AM · Restricted Project

May 6 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Thanks for the patch :)

May 6 2020, 7:20 PM · Restricted Project

May 5 2020

george.burgess.iv accepted D79386: [MemorySSA] Make MemoryLocation unknown when phi translation cannot be performed..

lgtm with one nit. thanks!

May 5 2020, 9:41 AM · Restricted Project

May 4 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

sorry for the latency -- a bit busy now, but I hope to get to this by EOD Wednesday :)

May 4 2020, 2:32 PM · Restricted Project

Apr 29 2020

george.burgess.iv accepted D79068: [MemorySSA] Pass DT to the upward iterator for proper PhiTranslation..

oof. thanks for this!

Apr 29 2020, 12:29 AM · Restricted Project

Apr 16 2020

george.burgess.iv committed rG94908088a831: [CodeGen] fix inline builtin-related breakage from D78162 (authored by george.burgess.iv).
[CodeGen] fix inline builtin-related breakage from D78162
Apr 16 2020, 12:15 PM
george.burgess.iv added a comment to D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..

Thanks for the report! Looking now.

Apr 16 2020, 10:35 AM · Restricted Project

Apr 15 2020

george.burgess.iv committed rG2dd17ff08165: [CodeGen] only add nobuiltin to inline builtins if we'll emit them (authored by george.burgess.iv).
[CodeGen] only add nobuiltin to inline builtins if we'll emit them
Apr 15 2020, 11:32 AM
george.burgess.iv closed D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..
Apr 15 2020, 11:31 AM · Restricted Project
george.burgess.iv added a comment to D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..

thanks!

Apr 15 2020, 11:30 AM · Restricted Project

Apr 14 2020

george.burgess.iv created D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..
Apr 14 2020, 3:45 PM · Restricted Project
george.burgess.iv committed rG91c8c74180ce: [CodeGen] clarify a comment; NFC (authored by george.burgess.iv).
[CodeGen] clarify a comment; NFC
Apr 14 2020, 2:40 PM
george.burgess.iv abandoned D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion.

Nothing in the real world :)

Apr 14 2020, 2:39 PM · Restricted Project
george.burgess.iv created D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion.
Apr 14 2020, 1:30 PM · Restricted Project

Apr 13 2020

george.burgess.iv accepted D77736: [DSE] Lift post-dominance for objs not accessible in caller..

LGTM. If no one else comments within a day or so, feel free to land.

Apr 13 2020, 1:34 PM · Restricted Project

Apr 10 2020

george.burgess.iv added a comment to D77736: [DSE] Lift post-dominance for objs not accessible in caller..

Thanks for this!

Apr 10 2020, 3:04 PM · Restricted Project

Apr 7 2020

george.burgess.iv committed rGff30d015222e: [TLI] fix a function's (commented) signature; NFC (authored by george.burgess.iv).
[TLI] fix a function's (commented) signature; NFC
Apr 7 2020, 1:37 PM

Apr 6 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

IIUC, the additional set would be used for the non-alloca cases, as we have to ensure that there are overwrites along all paths to the exit.

Apr 6 2020, 10:51 AM · Restricted Project

Apr 3 2020

george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

For a more direct comparison, I offer https://godbolt.org/z/fqAhUC . The lack of optimization in the later case is because we're forced to mark the call to __builtin_memcpy in the inline memcpy as nobuiltin. If we instead rename things, this issue doesn't happen: https://godbolt.org/z/FKNTWo.

Apr 3 2020, 4:16 PM · Restricted Project

Apr 1 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

I think there are 2 cases to distinguish:

  1. For accesses to non-alloca objects, this matches what the intrinsic achieves I think. We can only eliminate stores to objects that are visible after the function returns, if they are overwritten along all paths to the exit. So if we have determined a set of blocks that overwrite A (and there are no reads in between), we could check if all paths to the exit from A must go through one of the overwriting blocks. I think that matches your suggestion.
Apr 1 2020, 7:04 PM · Restricted Project

Mar 30 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

Thanks for working on this!

Mar 30 2020, 6:03 PM · Restricted Project

Mar 17 2020

george.burgess.iv accepted D76249: [AliasAnalysis] Misc fixes for checking aliasing with scalable types..

(I really need to circle back and finish the LocationSize migration...)

Mar 17 2020, 3:40 PM · Restricted Project

Mar 10 2020

george.burgess.iv accepted D75942: [x86][seses] No lfences in bb w/ 1 load and 0 stores.

Please wait for a stamp from another reviewer here, too.

Mar 10 2020, 6:05 PM · Restricted Project
george.burgess.iv accepted D75941: [x86][seses] No LFENCEs in basic blocks w/o loads.

LGTM modulo a few cosmetic nits. Similar to the previous review, please wait for approval from someone with more ownership here before landing.

Mar 10 2020, 5:33 PM · Restricted Project