george.burgess.iv (George Burgess IV)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2014, 12:28 PM (205 w, 2 d)

Recent Activity

Today

george.burgess.iv added a comment to D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..

Thanks for this!

Thu, Jun 21, 4:39 PM

Tue, Jun 19

george.burgess.iv accepted D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..

LGTM after two nits are addressed. Thank you!

Tue, Jun 19, 5:38 PM
george.burgess.iv accepted D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors..

LGTM after a nit is fixed; thanks!

Tue, Jun 19, 5:35 PM

Thu, Jun 14

george.burgess.iv added a comment to D47860: Print OptimizedAccessType in MemorySSA if it is set.

This revision was not accepted when it landed; it landed in state Needs Review.

Thu, Jun 14, 1:03 PM

Mon, Jun 11

george.burgess.iv closed D31315: Record command lines in objects built by clang, LLVM part.

(Committed as noted by echristo; just trying to clean my queue a bit. :) )

Mon, Jun 11, 1:46 PM
george.burgess.iv closed D30760: Record command lines in objects built by clang, Clang part.

(Committed as noted by echristo; just trying to clean my queue a bit. :) )

Mon, Jun 11, 1:46 PM
george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

Ping :)

Mon, Jun 11, 1:41 PM
george.burgess.iv added a comment to D47860: Print OptimizedAccessType in MemorySSA if it is set.

(Sorry for the double-post; one more bit that I noticed scrolling up)

Mon, Jun 11, 1:36 PM
george.burgess.iv added a comment to D47860: Print OptimizedAccessType in MemorySSA if it is set.

This LGTM after one last ultra-small nitpick is addressed. I don't see you in the commit logs, so will you need me to commit this for you?

Mon, Jun 11, 1:33 PM

Wed, Jun 6

george.burgess.iv added a reviewer for D47860: Print OptimizedAccessType in MemorySSA if it is set: george.burgess.iv.

Hi, and thanks for this patch!

Wed, Jun 6, 9:31 PM
george.burgess.iv created D47840: Make -Wgcc-compat complain about declarations in for loop init statements .
Wed, Jun 6, 11:59 AM

Wed, May 30

george.burgess.iv added inline comments to D44748: Track whether the size of a MemoryLocation is precise.
Wed, May 30, 12:02 AM
george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.

Rebase now that our LocationSize changes are in

Wed, May 30, 12:02 AM

Fri, May 25

george.burgess.iv abandoned D45581: Add a LocationSize type to represent the size of MemoryLocations.

Thanks for the clarification, and sorry about the misunderstanding. I submitted the bit-for-bit NFC patch as r333314, and will rebase the original review soon. :)

Fri, May 25, 2:24 PM

May 22 2018

george.burgess.iv added a comment to D45299: API to update MemorySSA for cloned blocks..

(FWIW, Alina and I chatted about this offline. She has a few changes queued up; I'm adding my nits on unchanged bits now, and will do a thorough code review once the new patch is posted)

May 22 2018, 5:23 PM

May 18 2018

george.burgess.iv added a comment to D45320: [MemDep] Fixed handling of invariant.group.

WFM; thanks for checking!

May 18 2018, 11:08 AM

May 11 2018

george.burgess.iv accepted D46779: [MemorySSA] getIncomingValueForBlock should return a MemoryAccess..

Thanks!

May 11 2018, 3:58 PM

May 10 2018

george.burgess.iv added a comment to D46343: [CFLGraph] Fixed Select instruction handling.

(Test committed as r332017)

May 10 2018, 11:42 AM
george.burgess.iv accepted D46343: [CFLGraph] Fixed Select instruction handling.

LGTM; thanks again.

May 10 2018, 12:20 AM

May 9 2018

george.burgess.iv added a comment to D45320: [MemDep] Fixed handling of invariant.group.

Adding George to see if he remembers any cases, so you have some stuff to test this all with.

May 9 2018, 2:45 PM

May 8 2018

george.burgess.iv added a comment to D46620: Fix side effect in debug code.

I don't know this code well enough to LGTM this, but can you talk a bit about why, please? This side-effect-inside-an-assert looks sane to me.

May 8 2018, 7:18 PM

May 4 2018

george.burgess.iv added a comment to D46343: [CFLGraph] Fixed Select instruction handling.

Hi, and thanks for the patch! I'm pretty familiar with this code and am happy to review it when I get back from vacation next week.

May 4 2018, 8:23 PM

Apr 12 2018

george.burgess.iv updated the diff for D45581: Add a LocationSize type to represent the size of MemoryLocations.

Accidentally left in LocationSize::precise. Oops. :)

Apr 12 2018, 11:09 AM
george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

I am concerned that you doing too many things in one patch and that the mix of refactoring and functional changes may contain hard to spot bugs.

Apr 12 2018, 10:59 AM
george.burgess.iv created D45581: Add a LocationSize type to represent the size of MemoryLocations.
Apr 12 2018, 10:59 AM

Apr 11 2018

george.burgess.iv added a comment to D45299: API to update MemorySSA for cloned blocks..

(Thanks for the patch, by the way!)

Apr 11 2018, 11:45 AM

Apr 10 2018

george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

Ping :)

Apr 10 2018, 3:55 PM

Apr 9 2018

george.burgess.iv added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

I plan to commit this tomorrow, to give time for any last-minute comments.

Apr 9 2018, 5:14 PM · Restricted Project
george.burgess.iv updated the diff for D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Address feedback

Apr 9 2018, 5:13 PM · Restricted Project
george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

Hi! It fell off my radar, but I'm happy to put it back on my queue. :)

Apr 9 2018, 11:14 AM
george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Rebased

Apr 9 2018, 11:14 AM
george.burgess.iv added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Thanks for the feedback!

Apr 9 2018, 10:54 AM · Restricted Project
george.burgess.iv updated the diff for D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Addressed feedback

Apr 9 2018, 10:54 AM · Restricted Project

Apr 4 2018

george.burgess.iv added a comment to D45299: API to update MemorySSA for cloned blocks..

This is a DRAFT API based on what I found needed in the old LoopUnswitch pass.

Apr 4 2018, 5:20 PM
george.burgess.iv added a comment to D44257: [MemorySSAUpdater] Mark non-trivial Phi for not to optimize.

Thanks for the patch!

Apr 4 2018, 12:18 PM

Apr 2 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

Ping :)

Apr 2 2018, 12:53 PM
george.burgess.iv added inline comments to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.
Apr 2 2018, 12:50 PM · Restricted Project
george.burgess.iv updated the diff for D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Addressed feedback

Apr 2 2018, 12:49 PM · Restricted Project
george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.

Addressed feedback

Apr 2 2018, 12:09 PM
george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

I would wait for another review

Apr 2 2018, 12:09 PM

Mar 30 2018

george.burgess.iv added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

C89 has no bool type and no stdbool.h but it has been added to later standards? That means the generalization could theoretically be done for later C standards, because we could check if the bool typedef had been used? If yes, would the check benefit?

Mar 30 2018, 2:30 PM · Restricted Project
george.burgess.iv added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Thanks for the feedback!

Mar 30 2018, 11:24 AM · Restricted Project
george.burgess.iv updated the diff for D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Addressed feedback

Mar 30 2018, 11:24 AM · Restricted Project

Mar 29 2018

george.burgess.iv added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Will be good idea to clarify where TEMP_FAILURE_RETRY come from.

Mar 29 2018, 1:55 PM · Restricted Project
george.burgess.iv updated the diff for D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Addressed feedback.

Mar 29 2018, 1:55 PM · Restricted Project
george.burgess.iv created D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.
Mar 29 2018, 12:32 PM · Restricted Project

Mar 28 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

Ping :)

Mar 28 2018, 3:17 PM
george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

Thanks for the comments!

Mar 28 2018, 3:13 PM
george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.

Addressed comments + tweaked mapTombstone and mapEntry so they call the hacky "direct" constructor.

Mar 28 2018, 3:13 PM

Mar 21 2018

george.burgess.iv created D44748: Track whether the size of a MemoryLocation is precise.
Mar 21 2018, 11:42 AM

Mar 19 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

ping :)

Mar 19 2018, 12:55 PM

Mar 7 2018

george.burgess.iv added inline comments to D38569: Expose must/may alias info in MemorySSA..
Mar 7 2018, 3:06 PM
george.burgess.iv accepted D38569: Expose must/may alias info in MemorySSA..

A bundle of nitpicks for you. LGTM assuming those get addressed.

Mar 7 2018, 10:42 AM

Mar 2 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

Gentle ping for confirmation from Hal or Philip that we're OK with ignoring lifetime intrinsics (as they exist today) in MSSA. :)

Mar 2 2018, 1:32 PM

Mar 1 2018

george.burgess.iv added a comment to D38569: Expose must/may alias info in MemorySSA..

Overall approach looks good to me. Just a few naming/refactoring nits and I'm happy to stamp this. Sorry for taking so long to get back to it

Mar 1 2018, 1:51 PM

Feb 26 2018

george.burgess.iv added inline comments to D40375: Use MemorySSA in LICM to do sinking and hoisting..
Feb 26 2018, 11:41 PM

Feb 22 2018

george.burgess.iv added inline comments to D40375: Use MemorySSA in LICM to do sinking and hoisting..
Feb 22 2018, 9:38 PM

Feb 18 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

So, we have to support them at the moment because, at the very least, the inliner will merge allocas with non-overlapping lifetimes (see mergeInlinedArrayAllocas in lib/Transforms/IPO/Inliner.cpp). I was surprised when I saw this. :)

Feb 18 2018, 10:29 AM

Feb 15 2018

george.burgess.iv added reviewers for D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start: reames, hfinkel.

+hal and philip, as requested. +gberry in case they have any earlycse thoughts

Feb 15 2018, 9:20 PM

Feb 13 2018

george.burgess.iv created D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.
Feb 13 2018, 4:35 PM

Jan 24 2018

george.burgess.iv added inline comments to D40375: Use MemorySSA in LICM to do sinking and hoisting..
Jan 24 2018, 7:58 PM

Dec 21 2017

george.burgess.iv added a comment to D40375: Use MemorySSA in LICM to do sinking and hoisting..

Only looked at the bit I was mentioned in.

Dec 21 2017, 5:19 PM
george.burgess.iv accepted D41525: [MemorySSA] Allow reordering of loads that alias in the presence of volatile loads..

Thanks for this! Just a few nitpicks.

Dec 21 2017, 3:43 PM

Dec 20 2017

george.burgess.iv added inline comments to D41405: Fix an assertion failure regression in isDesignatorAtObjectEnd for __builtin_object_size with incomplete array type in struct .
Dec 20 2017, 11:31 AM

Dec 19 2017

george.burgess.iv accepted D41405: Fix an assertion failure regression in isDesignatorAtObjectEnd for __builtin_object_size with incomplete array type in struct .

LGTM assuming my nit gets addressed.

Dec 19 2017, 1:28 PM

Dec 14 2017

george.burgess.iv added a comment to D41261: [libcxxabi][demangler] Special case demangling for pass_object_size attribute.

Thanks for working on this!

Dec 14 2017, 3:54 PM
george.burgess.iv abandoned D41152: Use a custom container to reduce AFDO's memory usage by ~60%.

I like that idea. :)

Dec 14 2017, 3:34 PM
george.burgess.iv added a comment to D41152: Use a custom container to reduce AFDO's memory usage by ~60%.

Is it enough to simply replace StringMap with std::map<std::string, ..> for small maps? Do you have memory data with that?

Dec 14 2017, 2:02 PM
george.burgess.iv updated the diff for D41152: Use a custom container to reduce AFDO's memory usage by ~60%.

Addressed feedback; thanks!

Dec 14 2017, 1:58 PM

Dec 12 2017

george.burgess.iv added inline comments to D41152: Use a custom container to reduce AFDO's memory usage by ~60%.
Dec 12 2017, 7:00 PM
george.burgess.iv created D41152: Use a custom container to reduce AFDO's memory usage by ~60%.
Dec 12 2017, 6:59 PM

Dec 8 2017

george.burgess.iv added a comment to D40940: [ubsan] Use pass_object_size info in bounds checks.

That said, one of the upsides of the current ubsan is that whether it will produce a diagnostic is predictable (as long as you don't use uninitialized data); you lose that to some extent with llvm.objectsize because it depends on the optimizer.

Dec 8 2017, 12:04 PM

Dec 7 2017

george.burgess.iv accepted D40941: [ubsan] Use pass_object_size info in bounds checks (compiler-rt).
Dec 7 2017, 4:28 PM
george.burgess.iv added a comment to D40941: [ubsan] Use pass_object_size info in bounds checks (compiler-rt).

If the answer to my question is "no, it'll just work," LGTM. Thanks!

Dec 7 2017, 4:26 PM
george.burgess.iv accepted D40940: [ubsan] Use pass_object_size info in bounds checks.

LGTM. Thanks again!

Dec 7 2017, 4:25 PM
george.burgess.iv added a comment to D40940: [ubsan] Use pass_object_size info in bounds checks.

Thanks for this!

Dec 7 2017, 11:53 AM

Dec 4 2017

george.burgess.iv edited reviewers for D40819: Implement Attribute Target MultiVersioning (Improved edition!), added: george.burgess.iv; removed: gbiv.
Dec 4 2017, 4:51 PM

Oct 23 2017

george.burgess.iv added a comment to D39030: Don't crash when we see unallocatable registers in clobbers.

Thanks again!

Oct 23 2017, 1:49 PM
george.burgess.iv updated the diff for D39030: Don't crash when we see unallocatable registers in clobbers.

Addressed all feedback. Thanks!

Oct 23 2017, 11:33 AM

Oct 18 2017

george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

However, the tests cover floating point, but they don't cover vector calls (arm_neon.h).

Oct 18 2017, 10:34 AM
george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Addressed feedback. Thanks!

Oct 18 2017, 10:33 AM

Oct 17 2017

george.burgess.iv updated the diff for D39030: Don't crash when we see unallocatable registers in clobbers.

Simplify test-case

Oct 17 2017, 6:15 PM
george.burgess.iv updated the summary of D39030: Don't crash when we see unallocatable registers in clobbers.
Oct 17 2017, 6:09 PM
george.burgess.iv created D39030: Don't crash when we see unallocatable registers in clobbers.
Oct 17 2017, 6:09 PM

Oct 12 2017

george.burgess.iv added inline comments to D38862: Add must alias info to ModRefInfo..
Oct 12 2017, 5:19 PM

Oct 4 2017

george.burgess.iv added a comment to D38569: Expose must/may alias info in MemorySSA..

Thanks for the patch!

Oct 4 2017, 8:09 PM

Oct 2 2017

george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

I like the idea of fixing those things, too; I'll start poking them soon. :)

Oct 2 2017, 9:17 PM
george.burgess.iv created D38479: Make -mgeneral-regs-only more like GCC's.
Oct 2 2017, 2:50 PM

Sep 27 2017

george.burgess.iv added a comment to D37880: Fix an out-of-bounds shufflevector index bug.

please run clang-format. over the changes for better inndentation

Sep 27 2017, 11:18 PM
george.burgess.iv updated the diff for D37880: Fix an out-of-bounds shufflevector index bug.

Address all feedback

Sep 27 2017, 8:17 PM

Sep 25 2017

george.burgess.iv added a comment to D37880: Fix an out-of-bounds shufflevector index bug.

Sorry for taking so long to get back to this, and thanks again for the comments/reviews!

Sep 25 2017, 1:45 PM

Sep 15 2017

george.burgess.iv added a comment to D37880: Fix an out-of-bounds shufflevector index bug.

Thanks for the comments!

Sep 15 2017, 2:15 PM
george.burgess.iv updated the diff for D37880: Fix an out-of-bounds shufflevector index bug.

Address all feedback

Sep 15 2017, 2:15 PM

Sep 14 2017

george.burgess.iv created D37880: Fix an out-of-bounds shufflevector index bug.
Sep 14 2017, 6:24 PM

Jul 18 2017

george.burgess.iv added a comment to D35338: Add the -fdestroy-globals flag.

Thanks for working on this!

Jul 18 2017, 7:58 PM

Jul 11 2017

george.burgess.iv abandoned D33904: Add a __has_attribute_enhancement macro to clang.

r306467 used __has_extension(overloadable_unmarked) instead.

Jul 11 2017, 12:26 PM
george.burgess.iv accepted D35003: [MemoryBuiltins] Allow truncation in visitAllocaInst().

Totally idiotic to not see them myself to begin with. Sorry and thanks!

Jul 11 2017, 11:26 AM

Jul 10 2017

george.burgess.iv added a comment to D35003: [MemoryBuiltins] Allow truncation in visitAllocaInst().

LGTM after a few stylistic nits are addressed. Thanks again!

Jul 10 2017, 7:57 AM

Jul 7 2017

george.burgess.iv added inline comments to D35003: [MemoryBuiltins] Allow truncation in visitAllocaInst().
Jul 7 2017, 6:11 AM
george.burgess.iv added a comment to D35003: [MemoryBuiltins] Allow truncation in visitAllocaInst().

Thanks for this! One nit, and I think it looks good.

Jul 7 2017, 5:34 AM