Page MenuHomePhabricator

george.burgess.iv (George Burgess IV)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2014, 12:28 PM (244 w, 1 d)

Recent Activity

Yesterday

george.burgess.iv committed rGae84e9ab4908: [MSSA] Delete move ctor; remove dynamic never-moved verification (authored by george.burgess.iv).
[MSSA] Delete move ctor; remove dynamic never-moved verification
Wed, Mar 20, 8:12 PM
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

The reason is that MemorySSA has to be moveable

Wed, Mar 20, 7:41 PM · Restricted Project
george.burgess.iv added inline comments to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
Wed, Mar 20, 7:19 PM · Restricted Project
george.burgess.iv committed rGeda3d11d1407: creduce-clang-crash.py: preprocess file + reduce commandline (authored by george.burgess.iv).
creduce-clang-crash.py: preprocess file + reduce commandline
Wed, Mar 20, 6:03 PM
george.burgess.iv accepted D59440: add steps to preprocess file and reduce command line args.

LGTM; thanks again!

Wed, Mar 20, 4:53 PM · Restricted Project
george.burgess.iv added a comment to D59440: add steps to preprocess file and reduce command line args.

Just a few style nits for you, and this LGTM. I assume rnk and serge-sans-paille are content, so I'm happy to check this in for you once these are addressed.

Wed, Mar 20, 3:43 PM · Restricted Project
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

MSSA bits LGTM (to reiterate, as do the CFLAA bits). Leaving the rest of the patch to the other reviewers

Wed, Mar 20, 11:20 AM · Restricted Project
george.burgess.iv accepted D59564: [LICM & MemorySSA] Don't sink/hoist stores in the presence of ordered loads..

LGTM; thanks!

Wed, Mar 20, 11:11 AM · Restricted Project

Tue, Mar 19

george.burgess.iv added a comment to D59564: [LICM & MemorySSA] Don't sink/hoist stores in the presence of ordered loads..

Thanks for this!

Tue, Mar 19, 5:30 PM · Restricted Project
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

Overall approach LGTM for this selective caching behavior.

Tue, Mar 19, 1:52 PM · Restricted Project

Thu, Mar 14

george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

This LGTM; feel free to submit after Aaron stamps this.

Thu, Mar 14, 1:35 PM · Restricted Project

Tue, Mar 12

george.burgess.iv committed rG87565fe7346c: Add a creduce script for clang crashes (authored by george.burgess.iv).
Add a creduce script for clang crashes
Tue, Mar 12, 10:50 AM
george.burgess.iv accepted D59118: creduce script for clang crashes.

I think that addresses all of the concerns people have put forward; given rnk's comment about one more round of fixes, this LGTM. Will check this in for you shortly.

Tue, Mar 12, 10:32 AM · Restricted Project

Mon, Mar 11

george.burgess.iv added a comment to D59118: creduce script for clang crashes.

I think we should do one more round of fixes, we can commit that for you, and then move on to the next steps

Mon, Mar 11, 4:48 PM · Restricted Project

Fri, Mar 8

george.burgess.iv committed rG4ea679f1f478: [CFLAnders] Fix typo in comment; NFC (authored by george.burgess.iv).
[CFLAnders] Fix typo in comment; NFC
Fri, Mar 8, 11:30 AM

Thu, Mar 7

george.burgess.iv accepted D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp".

LGTM; thanks again!

Thu, Mar 7, 5:52 PM · Restricted Project
george.burgess.iv added a comment to D59118: creduce script for clang crashes.

Thanks for this! Functionally, this looks good. My comments are mostly just simplicity/readability nitpicks.

Thu, Mar 7, 5:23 PM · Restricted Project
george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

Looks solid to me overall; just a few nits.

Thu, Mar 7, 5:07 PM · Restricted Project

Tue, Mar 5

george.burgess.iv added a comment to D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp".

I think @george.burgess.iv is the right person because he appears a lot in git blame :)

Tue, Mar 5, 3:05 PM · Restricted Project

Fri, Mar 1

george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

Thanks for working on this!

Fri, Mar 1, 11:40 AM · Restricted Project

Wed, Feb 27

george.burgess.iv accepted D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..

Thanks again!

Wed, Feb 27, 12:09 PM · Restricted Project

Tue, Feb 26

george.burgess.iv added inline comments to D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..
Tue, Feb 26, 2:58 PM · Restricted Project
george.burgess.iv added a comment to D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..

Thanks for this!

Tue, Feb 26, 10:55 AM · Restricted Project

Wed, Feb 20

george.burgess.iv added a comment to D58047: [LLD][ELF][ARM] Synthesise missing .ARM.exidx sections..

Thank you all for helping with this!

Wed, Feb 20, 11:31 AM

Feb 15 2019

george.burgess.iv accepted D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..

Thanks again!

Feb 15 2019, 2:25 PM · Restricted Project
george.burgess.iv added a reviewer for D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE.: davide.
Feb 15 2019, 1:57 PM · Restricted Project
george.burgess.iv added a comment to D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..

Thanks for doing this! Just two nits for you :)

Feb 15 2019, 11:54 AM · Restricted Project

Feb 11 2019

george.burgess.iv accepted D57968: [LICM] Cap the clobbering calls in LICM..

Deferring to Chandler's LGTM for the approach + first patch; changes since then LGTM.

Feb 11 2019, 5:32 PM · Restricted Project
george.burgess.iv accepted D57973: [MemorySSA] Remove verifyClobberSanity..

LGTM with one more nit. Thanks again!

Feb 11 2019, 11:23 AM · Restricted Project
george.burgess.iv added a comment to D57968: [LICM] Cap the clobbering calls in LICM..

Thanks for this!

Feb 11 2019, 11:16 AM · Restricted Project
george.burgess.iv accepted D57967: [LICM&MSSA] Limit store hoisting..

LGTM; thanks!

Feb 11 2019, 10:49 AM · Restricted Project
george.burgess.iv added a comment to D57973: [MemorySSA] Remove verifyClobberSanity..

Thanks! Just a tiny nit

Feb 11 2019, 10:47 AM · Restricted Project

Feb 8 2019

george.burgess.iv added a comment to D57967: [LICM&MSSA] Limit store hoisting..

Thanks for this!

Feb 8 2019, 12:01 PM · Restricted Project

Jan 30 2019

george.burgess.iv accepted D57199: [MemorySSA] Extend removeMemoryAccess API to optimize MemoryPhis..

LGTM after one nit is addressed.

Jan 30 2019, 1:00 PM

Jan 29 2019

george.burgess.iv added inline comments to D57199: [MemorySSA] Extend removeMemoryAccess API to optimize MemoryPhis..
Jan 29 2019, 3:43 PM

Jan 28 2019

george.burgess.iv added a comment to D57199: [MemorySSA] Extend removeMemoryAccess API to optimize MemoryPhis..

I would prefer to do the flag-flip separately though, in case it unearths some problematic usage.

Jan 28 2019, 7:15 PM

Jan 24 2019

george.burgess.iv added a comment to D57199: [MemorySSA] Extend removeMemoryAccess API to optimize MemoryPhis..

Thanks for this!

Jan 24 2019, 4:28 PM

Jan 23 2019

george.burgess.iv added inline comments to D57129: [SimpleLoopUnswitch] Early check exit for trivial unswitch with MemorySSA..
Jan 23 2019, 5:44 PM

Jan 15 2019

george.burgess.iv added a comment to D56760: Add a new builtin: __builtin_dynamic_object_size.

Thanks for this!

Jan 15 2019, 6:35 PM
george.burgess.iv added a comment to D56720: [MemorySSA] Add caching results of reaching LiveOnEntry MemoryDef to ClobberWalker.

Thanks for this!

Jan 15 2019, 12:01 PM · Restricted Project

Jan 8 2019

george.burgess.iv accepted D56467: [MemorySSA] Remove optimized value when reseting optimized..

Thanks!

Jan 8 2019, 7:27 PM

Jan 4 2019

george.burgess.iv accepted D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

LGTM; thanks again.

Jan 4 2019, 9:41 AM
george.burgess.iv added inline comments to D56285: [MemorySSA] Add SkipSelfWalker..
Jan 4 2019, 9:32 AM

Jan 3 2019

george.burgess.iv accepted D56285: [MemorySSA] Add SkipSelfWalker..

LGTM modulo a naming nit. If you're happy with the suggestion, feel free to submit. Thanks!

Jan 3 2019, 1:41 PM
george.burgess.iv accepted D55957: [MemorySSA] Refactor CachingWalker..

Thanks!

Jan 3 2019, 11:18 AM
george.burgess.iv added a comment to D55957: [MemorySSA] Refactor CachingWalker..

This LGTM at a high level; just a handful of nits for you, and I think this should be good to submit

Jan 3 2019, 9:45 AM

Jan 2 2019

george.burgess.iv added a comment to D55957: [MemorySSA] Refactor CachingWalker..

Thanks for this!

Jan 2 2019, 9:07 AM
george.burgess.iv added a comment to D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

Thanks for this! I like it when patches are small and split up like this one :)

Jan 2 2019, 9:07 AM

Dec 15 2018

george.burgess.iv added a comment to D55641: [CallSite removal] Migrate all Alias Analysis APIs to use the newly minted `CallBase` class instead of the `CallSite` wrapper..

MemorySSA changes LGTM, modulo one comment. Thanks!

Dec 15 2018, 11:42 PM

Dec 13 2018

george.burgess.iv added a comment to D55679: Place .text.hot section before .text..

Chrome OS developed a dependency (perf, not functional) on things in .text.hot coming before things in .text. Namely, they have code that maps the first N MB of Chrome's .text section to hugepages, under the assumption that the code near the beginning of the binary will be hotter than the code near the end of the binary.

Dec 13 2018, 3:58 PM

Dec 4 2018

george.burgess.iv accepted D55268: HowToBuildWithPGO.rst: Fix a few details in the manual steps.

(Also thanks for the reminder that I still need to update this with commentary for the purely-cmake-based approach. :) )

Dec 4 2018, 9:30 AM

Dec 3 2018

george.burgess.iv added a comment to D55060: [ThinLTO] Look through aliases in cache key calculations.

Thanks again! :)

Dec 3 2018, 4:05 PM
george.burgess.iv added a comment to D55060: [ThinLTO] Look through aliases in cache key calculations.

Thanks for the feedback!

Dec 3 2018, 10:42 AM
george.burgess.iv updated the diff for D55060: [ThinLTO] Look through aliases in cache key calculations.

Addressed feedback

Dec 3 2018, 10:41 AM

Nov 29 2018

george.burgess.iv created D55060: [ThinLTO] Look through aliases in cache key calculations.
Nov 29 2018, 9:39 AM

Nov 6 2018

george.burgess.iv added a comment to D4276: Added llvm.is.constant intrinsic.

It may make sense to iterate, as you say, but that can/should be a different patch.

Nov 6 2018, 2:07 PM · deleted

Nov 3 2018

george.burgess.iv added a comment to D53598: Add docs+a script for building clang/LLVM with PGO.

I notice that you're using LLVM_BUILD_INSTRUMENTED=IR, which corresponds to -fprofile-generate (IR-level profiling), instead of -fprofile-instr-generate (clang-level profiling). Did you play around with both and observe that IR-level profiling gave you better results?

Nov 3 2018, 4:13 PM

Oct 31 2018

george.burgess.iv added a comment to D53598: Add docs+a script for building clang/LLVM with PGO.

Thanks for pointing that out!

Oct 31 2018, 2:45 PM

Oct 30 2018

george.burgess.iv added a comment to D49103: Lower llvm.objectsize earlier in our optimization pipeline.

And numbers for building ${large_project}, as promised:

Oct 30 2018, 7:02 PM

Oct 29 2018

george.burgess.iv updated the diff for D49103: Lower llvm.objectsize earlier in our optimization pipeline.

Rebase, and only run this in the non-prelink full-LTO pipeline

Oct 29 2018, 6:55 PM
george.burgess.iv added a comment to D49103: Lower llvm.objectsize earlier in our optimization pipeline.

You mentioned a 1.9% degradation with the current placement. Did you happen to try any other locations in the pipeline?

Oct 29 2018, 6:19 PM
george.burgess.iv added a comment to D49103: Lower llvm.objectsize earlier in our optimization pipeline.

Ping :)

Oct 29 2018, 1:39 PM

Oct 27 2018

george.burgess.iv accepted D53795: [utils] Fix _run_benchmark in collect_and_build_with_pgo.py.

LGTM assuming the _run_benchmark changes are undone.

Oct 27 2018, 3:26 PM

Oct 26 2018

george.burgess.iv added a comment to D53598: Add docs+a script for building clang/LLVM with PGO.

Thanks again!

Oct 26 2018, 1:58 PM

Oct 25 2018

george.burgess.iv added a comment to D53598: Add docs+a script for building clang/LLVM with PGO.

Thank you!

Oct 25 2018, 6:19 PM
george.burgess.iv updated the diff for D53598: Add docs+a script for building clang/LLVM with PGO.

Address feedback

Oct 25 2018, 6:18 PM

Oct 23 2018

george.burgess.iv created D53598: Add docs+a script for building clang/LLVM with PGO.
Oct 23 2018, 11:59 AM

Oct 20 2018

george.burgess.iv abandoned D52245: No review requested: precursor changes for D44748.

Landed these a while back; closing.

Oct 20 2018, 1:19 PM

Oct 9 2018

george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

Thanks again! :)

Oct 9 2018, 11:41 PM
george.burgess.iv accepted D52924: Make __builtin_object_size use the EM_IgnoreSideEffects evaluation mode..

Thanks!

Oct 9 2018, 1:12 PM

Oct 4 2018

george.burgess.iv added a comment to D44748: Track whether the size of a MemoryLocation is precise.

Woo! Thank you very much for the review (and for bearing with me in your repeated requests to minimize this patch :) ).

Oct 4 2018, 8:17 PM

Oct 3 2018

george.burgess.iv added inline comments to D44748: Track whether the size of a MemoryLocation is precise.
Oct 3 2018, 10:38 AM
george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.
Oct 3 2018, 10:38 AM

Sep 28 2018

george.burgess.iv added inline comments to D44748: Track whether the size of a MemoryLocation is precise.
Sep 28 2018, 3:53 PM
george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.

Address feedback

Sep 28 2018, 3:52 PM

Sep 24 2018

george.burgess.iv added inline comments to D51664: [IR] Lazily number instructions for local dominance queries.
Sep 24 2018, 11:15 AM · Restricted Project

Sep 21 2018

george.burgess.iv accepted D52268: [AST] Squeeze some bits in LinkageComputer.

LGTM too.

Sep 21 2018, 11:22 AM · Restricted Project

Sep 19 2018

george.burgess.iv added a comment to D52268: [AST] Squeeze some bits in LinkageComputer.

Thanks for this! LGTM after erichkeane's comments are resolved.

Sep 19 2018, 3:47 PM · Restricted Project

Sep 18 2018

george.burgess.iv updated the diff for D44748: Track whether the size of a MemoryLocation is precise.

Shrunk the diff as requested; the few pre-commit patches required to make this build are available as one patch in https://reviews.llvm.org/D52245 .

Sep 18 2018, 12:55 PM
george.burgess.iv added inline comments to D44748: Track whether the size of a MemoryLocation is precise.
Sep 18 2018, 12:55 PM
george.burgess.iv created D52245: No review requested: precursor changes for D44748.
Sep 18 2018, 12:49 PM

Sep 12 2018

george.burgess.iv added a comment to D51664: [IR] Lazily number instructions for local dominance queries.

This looks good to me, but like said, I don't have sufficient context to stamp it with great confidence.

Sep 12 2018, 3:32 PM · Restricted Project
george.burgess.iv accepted D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..

LGTM, modulo one nit. Thanks!

Sep 12 2018, 10:35 AM

Sep 6 2018

george.burgess.iv added inline comments to D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..
Sep 6 2018, 4:55 PM
george.burgess.iv added a comment to D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Thanks for this!

Sep 6 2018, 4:55 PM

Sep 5 2018

george.burgess.iv accepted D45299: API to update MemorySSA for cloned blocks..

LGTM. Thanks for this!

Sep 5 2018, 5:02 PM
george.burgess.iv accepted D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..

Thanks!

Sep 5 2018, 9:25 AM
george.burgess.iv added a comment to D51664: [IR] Lazily number instructions for local dominance queries.

I have zero context on the various ways we can/do add instructions to a BB, so I can't immediately be helpful with the tricky part of this review. :) I've no complaints about the general direction of this patch, though.

Sep 5 2018, 8:48 AM · Restricted Project

Aug 29 2018

george.burgess.iv accepted D51327: [MemorySSA] Add expesive check for validating clobber accesses..

LGTM after the requested nit. Thanks again!

Aug 29 2018, 10:59 AM
george.burgess.iv accepted D51423: Fix DebugCounterTest when running all SupportTests.

LGTM. Thanks again!

Aug 29 2018, 9:06 AM
george.burgess.iv added a comment to D51423: Fix DebugCounterTest when running all SupportTests.

Thanks for this!

Aug 29 2018, 8:20 AM

Aug 27 2018

george.burgess.iv added a comment to D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Thanks for this!

Aug 27 2018, 3:31 PM

Aug 22 2018

george.burgess.iv added a comment to D45299: API to update MemorySSA for cloned blocks..

Lots of nits, and a few functional concerns. For the functional concerns that revolve around dubious edge additions, I'm happy with fixes or "it's impossible for that to actually happen; added a comment explaining that."

Aug 22 2018, 3:33 PM

Aug 20 2018

george.burgess.iv added inline comments to D51015: [MemorySSA] Make the Updater movable..
Aug 20 2018, 4:53 PM

Aug 14 2018

george.burgess.iv added a comment to D48790: Update MemorySSA in Local utils removing blocks..

Looks fine to me, though I'd prefer if someone familiar with this code had a look, as well.

Aug 14 2018, 7:40 PM
george.burgess.iv accepted D50749: [MemorySSA] Expose the verify as a debug option..

LGTM with a few comments. Thanks!

Aug 14 2018, 7:30 PM
george.burgess.iv added a comment to D45299: API to update MemorySSA for cloned blocks..

I'm not entirely through this patch (I hope to make more progress in the coming few days), but this is what I have for now. Logic's looking solid so far; I'm just nitpicky. :)

Aug 14 2018, 7:18 PM

Aug 13 2018

george.burgess.iv added a comment to D50650: [MemorySSA] Add API to update an incoming block into a MemoryPhi..

George, let me know if you agree with using the generic one and I'll abandon this revision. Thanks!

Aug 13 2018, 8:14 PM
george.burgess.iv added a comment to D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff..

Never touched this code, so all I can offer is a style nit. Thanks for the patch!

Aug 13 2018, 8:03 PM

Aug 9 2018

george.burgess.iv added a comment to D43269: [MemorySSA] Be less aggressive with @llvm.lifetime.start.

Workaround committed as r339411

Aug 9 2018, 10:16 PM