This is an archive of the discontinued LLVM Phabricator instance.

[flang][NFC] Remove obsolete Character helper
ClosedPublic

Authored by clementval on Jan 31 2022, 3:11 AM.

Details

Summary

During the upstreaming process from fir-dev some
new builder have been introduced in the flang/Optimizer/Builder/Character.h
and flang/include/Builder/Runtime/Character.h files.
This patch removes the obsolete Charachter helpers still present
in the lowering directories.

This patch is part of the upstreaming effort from fir-dev branch.

Diff Detail

Event Timeline

clementval created this revision.Jan 31 2022, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 3:11 AM
clementval requested review of this revision.Jan 31 2022, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 3:11 AM

LGTM. Please check why the patch application failed.

This revision is now accepted and ready to land.Jan 31 2022, 3:40 AM

LGTM. Please check why the patch application failed.

It depends on D118593. I was probably too slow to add the dependency and the patch was applied without it.

This revision was automatically updated to reflect the committed changes.
flang/lib/Lower/CMakeLists.txt