This is an archive of the discontinued LLVM Phabricator instance.

[flang][NFC] Remove out of date IO helper
ClosedPublic

Authored by clementval on Jan 31 2022, 3:03 AM.

Details

Summary

Functionality in IO.h and IO.cpp have been upstreamed together with the frontend
when flang landed upstream. Those files are out of date compared with fir-dev.
These functionality will be upstreamed again when needed in the lowering process
with an up to date code and a proper review.

Diff Detail

Event Timeline

clementval created this revision.Jan 31 2022, 3:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 3:03 AM
clementval requested review of this revision.Jan 31 2022, 3:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 3:03 AM
clementval retitled this revision from [flang][NFC] Remove obsolete IO wqhelper to [flang][NFC] Remove obsolete IO helper.Jan 31 2022, 3:09 AM

Please clarify which file has the new IO lowering functions in the commit message. Also, this patch does not have any code changes which uses the new ones. If this has already been done in previous patches, please clarify.

clementval edited the summary of this revision. (Show Details)Jan 31 2022, 3:12 AM
clementval edited the summary of this revision. (Show Details)

Please clarify which file has the new IO lowering functions in the commit message. Also, this patch does not have any code changes which uses the new ones. If this has already been done in previous patches, please clarify.

Description updated.

clementval abandoned this revision.Jan 31 2022, 5:49 AM

These files are actually used later in the lowering.

clementval reclaimed this revision.Jan 31 2022, 6:24 AM
clementval retitled this revision from [flang][NFC] Remove obsolete IO helper to [flang][NFC] Remove out of date IO helper.
clementval edited the summary of this revision. (Show Details)

Reopen the revision to clean out the files.

clementval edited the summary of this revision. (Show Details)Jan 31 2022, 6:40 AM

These files (and the functions it contains) are not currently used. Hence removing it is NFC.

This revision is now accepted and ready to land.Jan 31 2022, 7:01 AM
This revision was automatically updated to reflect the committed changes.
flang/include/flang/Lower/IO.h