[mlir] Silence warnings when building with MSVC

[aganea]

Summary

This fixes the following warnings when building with MSVC 16.11.5:

[1035/1805] Building CXX object tools\mlir\lib\Parser\CMakeFiles\obj.MLIRParser.dir\TypeParser.cpp.obj
D:\git\llvm-project\mlir\lib\Parser\TypeParser.cpp(573): warning C4018: '>': signed/unsigned mismatch
[1187/1805] Building CXX object tools\mlir\lib\Conversion\...g\CMakeFiles\obj.MLIRTosaToLinalg.dir\TosaToLinalg.cpp.obj
D:\git\llvm-project\mlir\lib\Conversion\TosaToLinalg\TosaToLinalg.cpp(1627): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
[1239/1805] Building CXX object tools\mlir\lib\Dialect\GPU...MLIRGPUTransforms.dir\Transforms\AllReduceLowering.cpp.obj
D:\git\llvm-project\mlir\lib\Dialect\GPU\Transforms\AllReduceLowering.cpp(244) : warning C4715: '`anonymous namespace'::GpuAllReduceRewriter::getFactory': not all control paths return a value
[1251/1805] Building CXX object tools\mlir\lib\Dialect\GPU\CMakeFiles\obj.MLIRGPUOps.dir\IR\GPUDialect.cpp.obj
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(107): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(107): note: while calling the constructor 'mlir::FailureOr<mlir::gpu::AllReduceOperation>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::gpu::AllReduceOperation>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(170): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(170): note: while calling the constructor 'mlir::FailureOr<mlir::gpu::Dimension>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::gpu::Dimension>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(233): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(233): note: while calling the constructor 'mlir::FailureOr<mlir::gpu::ShuffleMode>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::gpu::ShuffleMode>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(296): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/GPU/GPUOpsAttributes.cpp.inc(296): note: while calling the constructor 'mlir::FailureOr<mlir::gpu::MMAElementwiseOp>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::gpu::MMAElementwiseOp>::FailureOr'
[1292/1805] Building CXX object tools\mlir\lib\Dialect\LLVMIR\CMakeFiles\obj.MLIRNVVMIR.dir\IR\NVVMDialect.cpp.obj
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(110): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(110): note: while calling the constructor 'mlir::FailureOr<mlir::NVVM::MMAFrag>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::NVVM::MMAFrag>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(180): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(180): note: while calling the constructor 'mlir::FailureOr<mlir::NVVM::MMALayout>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::NVVM::MMALayout>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(250): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(250): note: while calling the constructor 'mlir::FailureOr<mlir::NVVM::MMATypes>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::NVVM::MMATypes>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(317): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/LLVMIR/NVVMOpsAttributes.cpp.inc(317): note: while calling the constructor 'mlir::FailureOr<mlir::NVVM::ShflKind>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::NVVM::ShflKind>::FailureOr'
[1294/1805] Building CXX object tools\mlir\lib\Dialect\Math\Transforms\CMakeFiles\obj.MLIRMathTransforms.dir\PolynomialApproximation.cpp.obj
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(317): warning C4305: 'argument': truncation from 'double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(318): warning C4305: 'argument': truncation from 'double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(319): warning C4305: 'argument': truncation from 'double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(320): warning C4305: 'argument': truncation from 'double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(393): warning C4305: 'argument': truncation from 'double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(1068): warning C4305: 'argument': truncation from 'long double' to 'float'
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(1017): note: while compiling class template member function 'mlir::LogicalResult `anonymous-namespace'::SinAndCosApproximation<true,mlir::math::SinOp>::matchAndRewrite(OpTy,mlir::PatternRewriter &) const'
        with
        [
            OpTy=mlir::math::SinOp
        ]
D:\git\llvm-project\mlir\include\mlir/IR/PatternMatch.h(936): note: see reference to class template instantiation '`anonymous-namespace'::SinAndCosApproximation<true,mlir::math::SinOp>' being compiled
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(1209): note: see reference to function template instantiation 'mlir::RewritePatternSet &mlir::RewritePatternSet::add<`anonymous-namespace'::AtanApproximation,`anonymous-namespace'::Atan2Approximation,`anonymous-namespace'::TanhApproximation,`anonymous-namespace'::LogApproximation,`anonymous-namespace'::Log2Approximation,`anonymous-namespace'::Log1pApproximation,mlir::math::ErfPolynomialApproximation,`anonymous-namespace'::ExpApproximation,`anonymous-namespace'::ExpM1Approximation,`anonymous-namespace'::SinAndCosApproximation<true,mlir::math::SinOp>,`anonymous-namespace'::SinAndCosApproximation<false,mlir::math::CosOp>,mlir::MLIRContext*,,void>(ConstructorArg &&)' being compiled
        with
        [
            ConstructorArg=mlir::MLIRContext *
        ]
D:\git\llvm-project\mlir\lib\Dialect\Math\Transforms\PolynomialApproximation.cpp(1069): warning C4305: 'argument': truncation from 'long double' to 'float'
[1306/1805] Building CXX object tools\mlir\lib\Dialect\OpenACC\CMakeFiles\obj.MLIROpenACC.dir\IR\OpenACC.cpp.obj
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenACC/OpenACCOpsAttributes.cpp.inc(87): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenACC/OpenACCOpsAttributes.cpp.inc(87): note: while calling the constructor 'mlir::FailureOr<mlir::acc::ClauseDefaultValue>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::acc::ClauseDefaultValue>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenACC/OpenACCOpsAttributes.cpp.inc(150): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenACC/OpenACCOpsAttributes.cpp.inc(150): note: while calling the constructor 'mlir::FailureOr<mlir::acc::ReductionOp>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::acc::ReductionOp>::FailureOr'
[1318/1805] Building CXX object tools\mlir\lib\Dialect\OpenMP\CMakeFiles\obj.MLIROpenMP.dir\IR\OpenMPDialect.cpp.obj
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(137): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(137): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseDefault>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseDefault>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(203): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(203): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseDepend>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseDepend>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(270): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(270): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseMemoryOrderKind>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseMemoryOrderKind>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(333): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(333): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseOrderKind>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseOrderKind>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(396): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(396): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseProcBindKind>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseProcBindKind>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(459): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(459): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ClauseScheduleKind>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ClauseScheduleKind>::FailureOr'
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(522): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsAttributes.cpp.inc(522): note: while calling the constructor 'mlir::FailureOr<mlir::omp::ScheduleModifier>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<mlir::omp::ScheduleModifier>::FailureOr'
[1762/1805] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestAttributes.cpp.obj
D:\git\llvm-project\release\tools\mlir\test\lib\Dialect\Test\TestAttrDefs.cpp.inc(983): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
D:\git\llvm-project\release\tools\mlir\test\lib\Dialect\Test\TestAttrDefs.cpp.inc(983): note: while calling the constructor 'mlir::FailureOr<test::TestEnum>::FailureOr(mlir::LogicalResult)'
D:\git\llvm-project\mlir\include\mlir/Support/LogicalResult.h(81): note: see declaration of 'mlir::FailureOr<test::TestEnum>::FailureOr'

It also fixes a warning with clang-cl:

[3665/3748] Building CXX object tools\mlir\unittests\ExecutionEngine\CMakeFiles\MLIRExecutionEngineTests.dir\Invoke.cpp.obj
D:\git\llvm-project\mlir\unittests\ExecutionEngine\Invoke.cpp(43,22): warning: unused function 'lowerToLLVMDialect' [-Wunused-function]
static LogicalResult lowerToLLVMDialect(ModuleOp module) {
                     ^
1 warning generated.

Tested on Windows with MSVC 16.11.9 & clang-cl ToT. Tested on Linux with clang-13.

[aganea]

mlir/include/mlir/IR/EnumAttr.td

31

Unfortunately the previous code was generating here warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied, see https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4927?view=msvc-170

This is because parser.emitError() returns a InFlightDiagnostic which has a cast operator to LogicalResult, then the whole expression constructs a FailureOr.

[mehdi_amini]

mlir/unittests/ExecutionEngine/Invoke.cpp

54–55

Please move the comment with the guard

[aganea]

mlir/unittests/ExecutionEngine/Invoke.cpp

54–55

Will do, thanks for reviewing!

mlir/include/mlir/IR/EnumAttr.td

let parser = [{[&]() -> ::mlir::FailureOr<}] # cppType # [{> {
     auto loc = $_parser.getCurrentLocation();
     ::llvm::StringRef enumKeyword;
     if (::mlir::failed($_parser.parseKeyword(&enumKeyword)))
       return ::mlir::failure();
     auto maybeEnum = }] # enumInfo.cppNamespace # "::" #
                           enumInfo.stringToSymbolFnName # [{(enumKeyword);
     if (maybeEnum)
       return *maybeEnum;
-    return {$_parser.emitError(loc, "expected }] #
+    return {(::mlir::LogicalResult)$_parser.emitError(loc, "expected }] #
     cppType # [{ to be one of: }] #
     !interleave(!foreach(enum, enumInfo.enumerants, enum.str), ", ") # [{")};
   }()}];
   // Print the enum by calling `symbolToString`.
   let printer = "$_printer << " # enumInfo.symbolToStringFnName # "($_self)";
 }
 
 // An attribute backed by a C++ enum. The attribute contains a single

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

if (op.mode() == "BILINEAR") {
       y1x1 = rewriter.create<arith::ExtSIOp>(loc, resultElementTy, y1x1);
 
       if (resultElementTy.getIntOrFloatBitWidth() > 32) {
         dx = rewriter.create<arith::ExtSIOp>(loc, resultElementTy, dx);
         dy = rewriter.create<arith::ExtSIOp>(loc, resultElementTy, dy);
       }
 
       auto unitVal = rewriter.create<arith::ConstantOp>(
-          loc, rewriter.getIntegerAttr(resultElementTy, 1 << shift));
+          loc, rewriter.getIntegerAttr(resultElementTy, 1LL << shift));
       Value rightPart = dx;
       Value leftPart = rewriter.create<arith::SubIOp>(loc, unitVal, dx);
 
       y0x0 = rewriter.create<arith::MulIOp>(loc, y0x0, leftPart);
       y0x1 = rewriter.create<arith::MulIOp>(loc, y0x1, rightPart);
       Value topAcc = rewriter.create<arith::AddIOp>(loc, y0x0, y0x1);
 
       y1x0 = rewriter.create<arith::MulIOp>(loc, y1x0, leftPart);

mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp

case gpu::AllReduceOperation::MAX:
                                  arith::CmpIPredicate::ugt>();
     case gpu::AllReduceOperation::MIN:
       return isFloatingPoint
                  ? getCmpFactory<arith::CmpFOp, arith::CmpFPredicate,
                                  arith::CmpFPredicate::ULT>()
                  : getCmpFactory<arith::CmpIOp, arith::CmpIPredicate,
                                  arith::CmpIPredicate::ult>();
     }
+    llvm_unreachable("unknown GPU AllReduceOperation");
   }
 
   /// Returns an accumulator factory that creates an op of type T.
   template <typename T>
   AccumulatorFactory getFactory() {
     return [&](Value lhs, Value rhs) {
       return create<T>(lhs.getType(), lhs, rhs);
     };

mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp

AtanApproximation::matchAndRewrite(math::AtanOp op,
   Value abs = builder.create<math::AbsOp>(operand);
   Value reciprocal = builder.create<arith::DivFOp>(one, abs);
   Value compare =
       builder.create<arith::CmpFOp>(arith::CmpFPredicate::OLT, abs, reciprocal);
   Value x = builder.create<SelectOp>(compare, abs, reciprocal);
 
   // Perform the Taylor series approximation for atan over the range
   // [-1.0, 1.0].
-  auto n1 = broadcast(builder, f32Cst(builder, 0.14418283), shape);
-  auto n2 = broadcast(builder, f32Cst(builder, -0.34999234), shape);
-  auto n3 = broadcast(builder, f32Cst(builder, -0.01067831), shape);
-  auto n4 = broadcast(builder, f32Cst(builder, 1.00209986), shape);
+  auto n1 = broadcast(builder, f32Cst(builder, 0.14418283f), shape);
+  auto n2 = broadcast(builder, f32Cst(builder, -0.34999234f), shape);
+  auto n3 = broadcast(builder, f32Cst(builder, -0.01067831f), shape);
+  auto n4 = broadcast(builder, f32Cst(builder, 1.00209986f), shape);
 
   Value p = builder.create<math::FmaOp>(x, n1, n2);
   p = builder.create<math::FmaOp>(x, p, n3);
   p = builder.create<math::FmaOp>(x, p, n4);
   p = builder.create<arith::MulFOp>(x, p);
 
   // Remap the solution for over [0.0, 1.0] to [0.0, inf]
   auto halfPi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape);
Atan2Approximation::matchAndRewrite(math::Atan2Op op,
   Value isHalfPi = builder.create<arith::AndIOp>(xZero, yGt);
   auto halfPi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape);
   result = builder.create<SelectOp>(isHalfPi, halfPi, result);
 
   // Handle x = 0, y < 0
   Value yLt = builder.create<arith::CmpFOp>(arith::CmpFPredicate::OLT, y, zero);
   Value isNegativeHalfPiPi = builder.create<arith::AndIOp>(xZero, yLt);
   auto negativeHalfPiPi =
-      broadcast(builder, f32Cst(builder, -1.57079632679), shape);
+      broadcast(builder, f32Cst(builder, -1.57079632679f), shape);
   result =
       builder.create<SelectOp>(isNegativeHalfPiPi, negativeHalfPiPi, result);
 
   // Handle x = 0, y = 0;
   Value yZero =
       builder.create<arith::CmpFOp>(arith::CmpFPredicate::OEQ, y, zero);
   Value isNan = builder.create<arith::AndIOp>(xZero, yZero);
   Value cstNan = broadcast(builder, f32FromBits(builder, 0x7fc00000), shape);
LogicalResult SinAndCosApproximation<isSine, OpTy>::matchAndRewrite(
   auto fmla = [&](Value a, Value b, Value c) {
     return builder.create<math::FmaOp>(a, b, c);
   };
 
   auto bitwiseOr = [&](Value a, Value b) {
     return builder.create<arith::OrIOp>(a, b);
   };
 
-  Value twoOverPi = bcast(f32Cst(builder, TWO_OVER_PI));
-  Value piOverTwo = bcast(f32Cst(builder, PI_OVER_2));
+  Value twoOverPi = bcast(f32Cst(builder, (float)TWO_OVER_PI));
+  Value piOverTwo = bcast(f32Cst(builder, (float)PI_OVER_2));
 
   Value x = op.getOperand();
 
   Value k = floor(mul(x, twoOverPi));
 
   Value y = sub(x, mul(k, piOverTwo));
 
   Value cstOne = bcast(f32Cst(builder, 1.0));

mlir/lib/Parser/TypeParser.cpp

if (getTokenSpelling().size() > 1 && getTokenSpelling()[1] == 'x') {
     // branch).
     assert(getTokenSpelling()[0] == '0' && "invalid integer literal");
     value = 0;
     state.lex.resetPointer(getTokenSpelling().data() + 1);
     consumeToken();
   } else {
     // Make sure this integer value is in bound and valid.
     Optional<uint64_t> dimension = getToken().getUInt64IntegerValue();
-    if (!dimension || *dimension > std::numeric_limits<int64_t>::max())
+    if (!dimension ||
+        *dimension > (uint64_t)std::numeric_limits<int64_t>::max())
       return emitError("invalid dimension");
     value = (int64_t)dimension.getValue();
     consumeToken(Token::integer);
   }
   return success();
 }
 
 /// Parse an 'x' token in a dimension list, handling the case where the x is

mlir/unittests/ExecutionEngine/Invoke.cpp

 #include "mlir/Target/LLVMIR/Export.h"
 #include "llvm/Support/TargetSelect.h"
 #include "llvm/Support/raw_ostream.h"
 
 #include "gmock/gmock.h"
 
 using namespace mlir;
 
+// The JIT isn't supported on Windows at that time
+#ifndef _WIN32
+
 static struct LLVMInitializer {
   LLVMInitializer() {
     llvm::InitializeNativeTarget();
     llvm::InitializeNativeTargetAsmPrinter();
   }
 } initializer;
 
 /// Simple conversion pipeline for the purpose of testing sources written in
 /// dialects lowering to LLVM Dialect.
 static LogicalResult lowerToLLVMDialect(ModuleOp module) {
   PassManager pm(module.getContext());
   pm.addPass(mlir::createMemRefToLLVMPass());
   pm.addNestedPass<FuncOp>(mlir::arith::createConvertArithmeticToLLVMPass());
   pm.addPass(mlir::createLowerToLLVMPass());
   pm.addPass(mlir::createReconcileUnrealizedCastsPass());
   return pm.run(module);
 }
 
-// The JIT isn't supported on Windows at that time
-#ifndef _WIN32
-
 TEST(MLIRExecutionEngine, AddInteger) {
   std::string moduleStr = R"mlir(
   func @foo(%arg0 : i32) -> i32 attributes { llvm.emit_c_interface } {
     %res = arith.addi %arg0, %arg0 : i32
     return %res : i32
   }
   )mlir";
   DialectRegistry registry;
   registerAllDialects(registry);