Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Although it's a bit repetitive, we typically try to run tests with both riscv32 and riscv64 if possible. It looks like this test case actually has identical assembly for RV32 and RV64, so you can just add a second CHECK line and leave them both using the default 'CHECK' prefix.
It would also be helpful to add a comment to the file explaining what it's trying to test. e.g. "This test case checks whether the address of an array is repeatedly rematerialised within a loop.".
Comment Actions
LGTM otherwise.
llvm/test/CodeGen/RISCV/unroll-loop-cse.ll | ||
---|---|---|
4 | You don't need --check-prefix=CHECK at all, since it's the default. |
You don't need --check-prefix=CHECK at all, since it's the default.