Page MenuHomePhabricator

[AArch64][SVE] Avoid using ptrue for ptest in VECREDUCE_OR.
ClosedPublic

Authored by sdesmalen on Jan 25 2022, 7:42 AM.

Diff Detail

Event Timeline

sdesmalen created this revision.Jan 25 2022, 7:42 AM
sdesmalen requested review of this revision.Jan 25 2022, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 7:42 AM
This revision is now accepted and ready to land.Jan 25 2022, 8:50 AM
Matt added a subscriber: Matt.Jan 25 2022, 3:23 PM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
19367–19372

The change makes sense but perhaps warrants a brief comment of why this is Op rather than Pg, since it's subtly different from the getPTest below.

sdesmalen updated this revision to Diff 403569.Jan 27 2022, 3:13 AM

Added check that the predicate is all active (to guard it for when this is used for fixed width vectors), as well as a comment explaining the rationale behind it.

david-arm accepted this revision.Jan 27 2022, 3:16 AM

LGTM! Looks good to me now with the new comments, thanks. :)

This revision was landed with ongoing or failed builds.Jan 27 2022, 3:46 AM
This revision was automatically updated to reflect the committed changes.