This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.
ClosedPublic

Authored by jacquesguan on Jan 23 2022, 11:23 PM.

Details

Summary

The field 'RequiredExtensions' is used to specify the constraint for rvv builtin, and it contains something which is not a sub-extension or extension such as 'RV64'. So the word 'extension' is not accurate now, 'feature' seems better.

Diff Detail

Event Timeline

jacquesguan created this revision.Jan 23 2022, 11:23 PM
jacquesguan requested review of this revision.Jan 23 2022, 11:23 PM
asb added a comment.Jan 24 2022, 3:28 AM

Makes sense to me, but I'll defer to someone else working more actively with this part of the codebase for a final LGTM.

khchen accepted this revision.Jan 24 2022, 6:14 AM

LGTM

This revision is now accepted and ready to land.Jan 24 2022, 6:14 AM
This revision was landed with ongoing or failed builds.Jan 24 2022, 6:26 PM
This revision was automatically updated to reflect the committed changes.