This is an archive of the discontinued LLVM Phabricator instance.

[IRBuilder] Migrate and-folding to value-based FoldAnd.
ClosedPublic

Authored by fhahn on Jan 16 2022, 8:10 AM.

Details

Summary

Similar to the migration of or-folding to FoldOr, there are a few cases
where the fold in IRBuilder::CreateAnd triggered directly. Those have
been updated.

Diff Detail

Event Timeline

fhahn created this revision.Jan 16 2022, 8:10 AM
fhahn requested review of this revision.Jan 16 2022, 8:10 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 16 2022, 8:10 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nikic accepted this revision.Jan 16 2022, 8:22 AM

LGTM

This revision is now accepted and ready to land.Jan 16 2022, 8:22 AM
fhahn updated this revision to Diff 400531.Jan 17 2022, 6:45 AM

Rebase to re-trigger tests. Looks like there are a couple of additional tests that need updating.

fhahn updated this revision to Diff 400583.Jan 17 2022, 9:30 AM
fhahn added a subscriber: Meinersbur.

Fix failing polly tests.

@Meinersbur looks like some Polly tests were relying on the IRBuilder folding and i1 %X, true. This patch moves the logic to a dedicated simplifying folder. If this kind of fold is important, it might be good to switch Polly to use the InstSimplifyFolder.

fhahn updated this revision to Diff 401253.Jan 19 2022, 8:20 AM

rebase to trigger new run of precommit tests

This revision was automatically updated to reflect the committed changes.